Skip to content
This repository has been archived by the owner on Aug 9, 2022. It is now read-only.

disable notification feature from UI #198

Merged
merged 2 commits into from
Nov 18, 2020
Merged

disable notification feature from UI #198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f8988d
disable notification feature from UI
zhongnansu Nov 17, 2020
a39b4d1
rollback poller interval value
zhongnansu Nov 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
222 changes: 0 additions & 222 deletions ...report_definition_details/__tests__/__snapshots__/report_definition_details.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,80 +390,6 @@ exports[`<ReportDefinitionDetails /> panel render 5 hours recurring definition d
<div
class="euiSpacer euiSpacer--l"
/>
<h3
class="euiTitle euiTitle--medium"
>
Notification settings
</h3>
<div
class="euiSpacer euiSpacer--l"
/>
<div
class="euiFlexGroup euiFlexGroup--gutterLarge euiFlexGroup--directionRow euiFlexGroup--responsive"
>
<div
class="euiFlexItem"
>
<dl
class="euiDescriptionList euiDescriptionList--row"
>
<dt
class="euiDescriptionList__title"
>
Email recipients
</dt>
<dd
class="euiDescriptionList__description"
/>
</dl>
</div>
<div
class="euiFlexItem"
>
<dl
class="euiDescriptionList euiDescriptionList--row"
>
<dt
class="euiDescriptionList__title"
>
Email subject
</dt>
<dd
class="euiDescriptionList__description"
/>
</dl>
</div>
<div
class="euiFlexItem"
>
<dl
class="euiDescriptionList euiDescriptionList--row"
>
<dt
class="euiDescriptionList__title"
>
Optional message
</dt>
<dd
class="euiDescriptionList__description"
/>
</dl>
</div>
<div
class="euiFlexItem"
>
<dl
class="euiDescriptionList euiDescriptionList--row"
>
<dt
class="euiDescriptionList__title"
/>
<dd
class="euiDescriptionList__description"
/>
</dl>
</div>
</div>
</div>
<div
aria-live="polite"
Expand Down Expand Up @@ -864,80 +790,6 @@ exports[`<ReportDefinitionDetails /> panel render disabled daily definition, cli
<div
class="euiSpacer euiSpacer--l"
/>
<h3
class="euiTitle euiTitle--medium"
>
Notification settings
</h3>
<div
class="euiSpacer euiSpacer--l"
/>
<div
class="euiFlexGroup euiFlexGroup--gutterLarge euiFlexGroup--directionRow euiFlexGroup--responsive"
>
<div
class="euiFlexItem"
>
<dl
class="euiDescriptionList euiDescriptionList--row"
>
<dt
class="euiDescriptionList__title"
>
Email recipients
</dt>
<dd
class="euiDescriptionList__description"
/>
</dl>
</div>
<div
class="euiFlexItem"
>
<dl
class="euiDescriptionList euiDescriptionList--row"
>
<dt
class="euiDescriptionList__title"
>
Email subject
</dt>
<dd
class="euiDescriptionList__description"
/>
</dl>
</div>
<div
class="euiFlexItem"
>
<dl
class="euiDescriptionList euiDescriptionList--row"
>
<dt
class="euiDescriptionList__title"
>
Optional message
</dt>
<dd
class="euiDescriptionList__description"
/>
</dl>
</div>
<div
class="euiFlexItem"
>
<dl
class="euiDescriptionList euiDescriptionList--row"
>
<dt
class="euiDescriptionList__title"
/>
<dd
class="euiDescriptionList__description"
/>
</dl>
</div>
</div>
</div>
<div
aria-live="polite"
Expand Down Expand Up @@ -1334,80 +1186,6 @@ exports[`<ReportDefinitionDetails /> panel render on demand definition details 1
<div
class="euiSpacer euiSpacer--l"
/>
<h3
class="euiTitle euiTitle--medium"
>
Notification settings
</h3>
<div
class="euiSpacer euiSpacer--l"
/>
<div
class="euiFlexGroup euiFlexGroup--gutterLarge euiFlexGroup--directionRow euiFlexGroup--responsive"
>
<div
class="euiFlexItem"
>
<dl
class="euiDescriptionList euiDescriptionList--row"
>
<dt
class="euiDescriptionList__title"
>
Email recipients
</dt>
<dd
class="euiDescriptionList__description"
/>
</dl>
</div>
<div
class="euiFlexItem"
>
<dl
class="euiDescriptionList euiDescriptionList--row"
>
<dt
class="euiDescriptionList__title"
>
Email subject
</dt>
<dd
class="euiDescriptionList__description"
/>
</dl>
</div>
<div
class="euiFlexItem"
>
<dl
class="euiDescriptionList euiDescriptionList--row"
>
<dt
class="euiDescriptionList__title"
>
Optional message
</dt>
<dd
class="euiDescriptionList__description"
/>
</dl>
</div>
<div
class="euiFlexItem"
>
<dl
class="euiDescriptionList euiDescriptionList--row"
>
<dt
class="euiDescriptionList__title"
/>
<dd
class="euiDescriptionList__description"
/>
</dl>
</div>
</div>
</div>
<div
aria-live="polite"
Expand Down
4 changes: 2 additions & 2 deletions ...na-reports/public/components/main/report_definition_details/report_definition_details.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -620,7 +620,7 @@ export function ReportDefinitionDetails(props) {
<EuiSpacer />
{triggerSection}
<EuiSpacer />
<EuiTitle>
{/* <EuiTitle>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this unused code?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be added back once we plan to add notification. Do you want me to put a comment here?

<h3>Notification settings</h3>
</EuiTitle>
<EuiSpacer />
Expand All @@ -644,7 +644,7 @@ export function ReportDefinitionDetails(props) {
)}
/>
<ReportDetailsComponent />
</EuiFlexGroup>
</EuiFlexGroup> */}
</EuiPageContent>
<EuiGlobalToastList
toasts={toasts}
Expand Down
Loading