This repository has been archived by the owner on Aug 9, 2022. It is now read-only.
disable notification feature from UI #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhongnansu
requested review from
davidcui1225,
akbhatta,
abbashus and
joshuali925
joshuali925
approved these changes
Nov 17, 2020
| @@ -13,4 +13,4 @@ | |||
| * permissions and limitations under the License. | |||
| */ | |||
|
|
|||
| export const POLL_INTERVAL = 1000 * 60 * 5; // in milliseconds (5 min) | |||
| export const POLL_INTERVAL = 1000 * 60 * 0.5; // in milliseconds (5 min) | |||
There was a problem hiding this comment.
the comment should be 30 seconds instead of 5 min, and what does POLL_INTERVAL do?
There was a problem hiding this comment.
I always forgot to revert that value, thx! We are using a fixed interval to poll background jobs for reporting. For develop purpose, I always change it to a small value.
| @@ -620,7 +620,7 @@ export function ReportDefinitionDetails(props) { | |||
| <EuiSpacer /> | |||
| {triggerSection} | |||
| <EuiSpacer /> | |||
| <EuiTitle> | |||
| {/* <EuiTitle> | |||
There was a problem hiding this comment.
Can we remove this unused code?
There was a problem hiding this comment.
This will be added back once we plan to add notification. Do you want me to put a comment here?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
remove notification from following pages
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.