Skip to content
This repository has been archived by the owner on Aug 9, 2022. It is now read-only.

Error in CSV report #327

Closed
Artain opened this issue Feb 19, 2021 · 14 comments
Closed

Error in CSV report #327

Artain opened this issue Feb 19, 2021 · 14 comments
Labels
bug Something isn't working

Comments

@Artain
Copy link

Artain commented Feb 19, 2021

Version

Opendistro Elasticsearch 1.13.0 standalone linux
Opendistro Kibana 1.13.0 standalone linux

Error description

If the saved discover table includes a null value the csv export will fail with the error message:

[08:16:09.781] [error][opendistroReportsKibana][plugins] Failed to generate report: TypeError: Cannot read property 'toString' of null
  log   [08:16:09.782] [error][opendistroReportsKibana][plugins] TypeError: Cannot read property 'toString' of null
    at sanitize (/srv/opendistroforelasticsearch-kibana/plugins/opendistroReportsKibana/server/routes/utils/dataReportHelpers.ts:227:18)
    at getEsData (/srv/opendistroforelasticsearch-kibana/plugins/opendistroReportsKibana/server/routes/utils/dataReportHelpers.ts:172:34)
    at convertEsDataToCsv (/srv/opendistroforelasticsearch-kibana/plugins/opendistroReportsKibana/server/routes/utils/savedSearchReportHelper.ts:266:18)
    at generateReportData (/srv/opendistroforelasticsearch-kibana/plugins/opendistroReportsKibana/server/routes/utils/savedSearchReportHelper.ts:151:10)
    at process._tickCallback (internal/process/next_tick.js:68:7)
 error  [08:16:07.104]  Error: Internal Server Error
    at HapiResponseAdapter.toError (/srv/opendistroforelasticsearch-kibana/src/core/server/http/router/response_adapter.js:132:19)
    at HapiResponseAdapter.toHapiResponse (/srv/opendistroforelasticsearch-kibana/src/core/server/http/router/response_adapter.js:86:19)
    at HapiResponseAdapter.handle (/srv/opendistroforelasticsearch-kibana/src/core/server/http/router/response_adapter.js:81:17)
    at Router.handle (/srv/opendistroforelasticsearch-kibana/src/core/server/http/router/router.js:164:34)
    at process._tickCallback (internal/process/next_tick.js:68:7)

@zhongnansu zhongnansu added the bug Something isn't working label Feb 19, 2021
@hollden
Copy link

hollden commented Feb 19, 2021

I have almost the same error on 1.12:

{"type":"log","@timestamp":"2021-02-18T07:56:03Z","tags":["error","plugins","opendistroReportsKibana"],"pid":21258,"message":"Failed to generate report by id: TypeError: Cannot read property 'settings' of undefined"}
{"type":"log","@timestamp":"2021-02-18T07:56:03Z","tags":["error","plugins","opendistroReportsKibana"],"pid":21258,"message":"TypeError: Cannot read property 'settings' of undefined\n    at getMaxResultSize (/usr/share/kibana/plugins/opendistroReportsKibana/server/routes/utils/savedSearchReportHelper.ts:163:35)\n    at process._tickCallback (internal/process/next_tick.js:68:7)"}

@Artain
Copy link
Author

Artain commented Feb 19, 2021

@hollden please check #313 your error should be fixed with version 1.13.

@alexz00
Copy link

alexz00 commented Feb 19, 2021

Hi,
I'm facing errors too when generating a CSV report:

If I click on "Create report definition" or "Generate CSV" from the Discover Panel, nothing happens and the following exception is traced:

Uncaught TypeError: Invalid attempt to destructure non-iterable instance.
In order to be iterable, non-array objects must have a [Symbol.iterator]() method.
    at _nonIterableRest (:5601/36136/bundles/plugin/opendistroReportsKibana/opendistroReportsKibana.plugin.js:1)
    at _slicedToArray (:5601/36136/bundles/plugin/opendistroReportsKibana/opendistroReportsKibana.plugin.js:1)
    at getTimeFieldsFromUrl (:5601/36136/bundles/plugin/opendistroReportsKibana/opendistroReportsKibana.plugin.js:1)
    at contextMenuCreateReportDefinition (:5601/36136/bundles/plugin/opendistroReportsKibana/opendistroReportsKibana.plugin.js:1)
    at HTMLButtonElement.<anonymous> (:5601/36136/bundles/plugin/opendistroReportsKibana/opendistroReportsKibana.plugin.js:1)
    at HTMLDocument.dispatch (:5601/36136/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:404)
    at HTMLDocument.m.handle (:5601/36136/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:404)

I'm using the ODFE 1.13.0.0 plugin (manually installed on Kibana 7.10.2 OSS).

@pySilver
Copy link

I'm getting a little bit different error:

POST https://<redacted>/api/reporting/generateReport?timezone=Europe/Warsaw
{"statusCode":500,"error":"Internal Server Error","message":"Cannot read property 'settings' of undefined"}

@zhongnansu
Copy link
Member

@pySilver @hollden from the error log this should be related to #249, and the fix is included in 1.13.0 release. Please check

@pySilver
Copy link

pySilver commented Feb 19, 2021

@zhongnansu I've just switched to 1.13.0 (from 1.12.0), reports aren't generating but the error is different now :(

While clicking "Download CSV" no network communication happens and UI overlay does not appear. However browser console now has the following error:

Uncaught TypeError: Cannot read property 'diff' of undefined
    at getTimeFieldsFromUrl (opendistroReportsKibana.plugin.js:1)
    at HTMLButtonElement.<anonymous> (opendistroReportsKibana.plugin.js:1)
    at HTMLDocument.dispatch (kbn-ui-shared-deps.js:404)
    at HTMLDocument.m.handle (kbn-ui-shared-deps.js:404)

@zhongnansu
Copy link
Member

@pySilver can you provide the url at the time when you click the "Download csv" button?

@zhongnansu
Copy link
Member

@Artain we'll look into this

@pySilver
Copy link

@zhongnansu sure. Btw, now for some reason download csv isn't even available (grayed): Screenshot: https://take.ms/M1bh9

URL:

<kibana.domain>/app/discover#/?notFound=search&notFoundMessage=Could%20not%20locate%20that%20search%20(id:%203540a600-3751-11eb-9c40-cfb624fcd801)&_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now%2Fd,to:now%2Fd))&_a=(columns:!(RequestPath,OriginStatus),filters:!(('$state':(store:appState),meta:(alias:!n,disabled:!f,index:bc899790-374f-11eb-9c40-cfb624fcd801,key:OriginStatus,negate:!f,params:(query:'404'),type:phrase),query:(match_phrase:(OriginStatus:'404')))),index:bc899790-374f-11eb-9c40-cfb624fcd801,interval:auto,query:(language:kuery,query:'request_User-Agent:%20%22Googlebot%22%20and%20(RequestHost:%20%redacted.com%22)%20and%20RequestPath:%20%22%2Fpl%2F%22'),sort:!())

@perkons
Copy link

perkons commented Mar 3, 2021

It is still an issue in version 1.13.0
CentOS 8
I am getting this error when trying to Generate CSV:

{"type":"log","@timestamp":"2021-03-03T11:06:29Z","tags":["error","plugins","opendistroReportsKibana"],"pid":41895,"message":"Failed to generate report: TypeError: JSON.parse(...).query.query.replace is not a function"}
{"type":"log","@timestamp":"2021-03-03T11:06:29Z","tags":["error","plugins","opendistroReportsKibana"],"pid":41895,"message":"TypeError: JSON.parse(...).query.query.replace is not a function
at buildQuery (/usr/share/kibana/plugins/opendistroReportsKibana/server/routes/utils/dataReportHelpers.ts:115:18)\n    at getEsDataSize (/usr/share/kibana/plugins/opendistroReportsKibana/server/routes/utils/savedSearchReportHelper.ts:179:22)
at generateReportData (/usr/share/kibana/plugins/opendistroReportsKibana/server/routes/utils/savedSearchReportHelper.ts:138:25)\n    at process._tickCallback (internal/process/next_tick.js:68:7)"}
{"type":"error","@timestamp":"2021-03-03T11:06:27Z","tags":[],"pid":41895,"level":"error","error":{"message":"Internal Server Error","name":"Error","stack":"Error: Internal Server Error
at HapiResponseAdapter.toError (/usr/share/kibana/src/core/server/http/router/response_adapter.js:132:19)\n    at HapiResponseAdapter.toHapiResponse (/usr/share/kibana/src/core/server/http/router/response_adapter.js:86:19)
at HapiResponseAdapter.handle (/usr/share/kibana/src/core/server/http/router/response_adapter.js:81:17)\n    at Router.handle (/usr/share/kibana/src/core/server/http/router/router.js:164:34)
at process._tickCallback (internal/process/next_tick.js:68:7)"},"url":{"protocol":null,"slashes":null,"auth":null,"host":null,"port":null,"hostname":null,"hash":null,"search":"?timezone=Europe/Berlin","query":{"timezone":"Europe/Berlin"},
"pathname":"/api/reporting/generateReport","path":"/api/reporting/generateReport?timezone=Europe/Berlin","href":"/api/reporting/generateReport?timezone=Europe/Berlin"},"message":"Internal Server Error"}

I also did install the dependencies mentioned here https://github.com/opendistro-for-elasticsearch/kibana-reports/blob/dev/kibana-reports/rendering-engine/headless-chrome/README.md#additional-libaries and tested with the headles-chromium, same result.

@melvinkokxw
Copy link

This is still an issue in 1.13.0, and I located a possible location for the issue:

The sanitize function uses the toString method on null values.

A workaround working for me is to continue if the value is null:

if (doc[field] == null)
    continue

@jasonrojas
Copy link

I am also seeing the same thing with the 1.13.2 update.

{"type":"log","@timestamp":"2021-04-16T23:17:26Z","tags":["error","plugins","opendistroReportsKibana"],"pid":30607,"message":"TypeError: JSON.parse(...).query.query.replace is not a function\n at buildQuery (/usr/share/kibana/plugins/opendistroReportsKibana/server/routes/utils/dataReportHelpers.ts:115:18)\n at getEsDataSize (/usr/share/kibana/plugins/opendistroReportsKibana/server/routes/utils/savedSearchReportHelper.ts:179:22)\n at generateReportData (/usr/share/kibana/plugins/opendistroReportsKibana/server/routes/utils/savedSearchReportHelper.ts:138:25)\n at process._tickCallback (internal/process/next_tick.js:68:7)"} {"type":"error","@timestamp":"2021-04-16T23:17:26Z","tags":[],"pid":30607,"level":"error","error":{"message":"Internal Server Error","name":"Error","stack":"Error: Internal Server Error\n at HapiResponseAdapter.toError (/usr/share/kibana/src/core/server/http/router/response_adapter.js:132:19)\n at HapiResponseAdapter.toHapiResponse (/usr/share/kibana/src/core/server/http/router/response_adapter.js:86:19)\n at HapiResponseAdapter.handle (/usr/share/kibana/src/core/server/http/router/response_adapter.js:81:17)\n at Router.handle (/usr/share/kibana/src/core/server/http/router/router.js:164:34)\n at process._tickCallback (internal/process/next_tick.js:68:7)"},"url":{"protocol":null,"slashes":null,"auth":null,"host":null,"port":null,"hostname":null,"hash":null,"search":"?timezone=America/Los_Angeles","query":{"timezone":"America/Los_Angeles"},"pathname":"/api/reporting/generateReport","path":"/api/reporting/generateReport?timezone=America/Los_Angeles","href":"/api/reporting/generateReport?timezone=America/Los_Angeles"},"message":"Internal Server Error"}

uzhinskiy added a commit to uzhinskiy/kibana-reports that referenced this issue Apr 18, 2021
@Marc-Whiteman
Copy link

Marc-Whiteman commented Apr 26, 2021

I have the same "Internal Server Error" as jasonrojas with ver 1.12.0

@zhongnansu
Copy link
Member

zhongnansu commented May 13, 2021

This issue has been moved to Dashboards reports. We'll merge in the PR to Opendistro still, and apply the fix to the new repo. For tracking and further discussion, please go to issue in Dashboards-reports opensearch-project/reporting#40

zhongnansu pushed a commit to opensearch-project/reporting that referenced this issue May 21, 2021
zhongnansu pushed a commit to opensearch-project/reporting that referenced this issue May 24, 2021
zhongnansu pushed a commit to zhongnansu/kibana-reports that referenced this issue Jul 1, 2021
zhongnansu pushed a commit to zhongnansu/kibana-reports that referenced this issue Jul 1, 2021
ps48 added a commit to opensearch-project/reporting that referenced this issue Jul 28, 2022
* Fix release notes version (#28)

Signed-off-by: Zhongnan Su <[email protected]>

* Migrate Reporting Notebooks Integration (#21)

Signed-off-by: David Cui <[email protected]>

* Add Logic to Auto-populate Notebooks from Context Menu (#30)

Signed-off-by: David Cui <[email protected]>

* Change opendistro to opensearch in email template (#31)

Signed-off-by: Joshua Li <[email protected]>

* Fix case sensitive directory name for chromium zip (#35)

Signed-off-by: David Cui <[email protected]>

Co-authored-by: Carl Meadows <[email protected]>
Co-authored-by: Zhongnan Su <[email protected]>
Co-authored-by: Joshua Li <[email protected]>

* Use output_only Parameter for notebook reports (#32)


Signed-off-by: David Cui <[email protected]>

* replace osd-version header to remove need for version number matching (#37)

Signed-off-by: David Cui <[email protected]>

* Remove visualization editor in visualization reports (#50)

Signed-off-by: Joshua Li <[email protected]>

* add condition to fix negative value display (#51)

Signed-off-by: David Cui <[email protected]>

* [Query Builder] Correctly handle match phrases when a single value is specified or when the match phrases is negated (#33)

* [Build query] Correctly handle phrases filter that specify only one single value

Contrary to the phrase filter type which always specify a meta.params.query, the phrases filter type never specify a meta.params.query even when a single value is selected.
This anomaly trigger an error generated by the MonoFieldQueryBase included in the elastic-builder dependency and prevent the generation of the report.

Signed-off-by: Kévin Masseix <[email protected]>

* [Build query] Correctly handle negated phrases filter that specify only one single value

Signed-off-by: Kévin Masseix <[email protected]>

* [Build query] Correctlty handle negated phrases to exclude them from the report instead of including them

Signed-off-by: Kévin Masseix <[email protected]>

* Pass processing if doc[field] == null (#361)

Pass processing if doc[field] == null
Based on opendistro-for-elasticsearch/kibana-reports#327 (comment)

* add test case for commit 368eb03e200b755870f1ad373e67561201ab6f31 (#370)

Add missing test case for the fix "pass doc[field] == null"

* Unhash page url in case store URLs in session storage is enabled from Kibana advanced setting (#371)

* Update Namespaces/APIs/Documentation for OpenSearch (#55)

Signed-off-by: David Cui <[email protected]>

* bump path-parse version to 1.0.7 to address CVE (#59)

Signed-off-by: David Cui <[email protected]>

* increase chromium timeout to 100s (#58)

Signed-off-by: Zhongnan Su <[email protected]>

* Fix csv parsing function (#53)

* Fix csv parsing function

Signed-off-by: Joshua Li <[email protected]>

* Flatten nested results for csv

Signed-off-by: Joshua Li <[email protected]>

* Add test case for nested fields

Signed-off-by: Joshua Li <[email protected]>

* Add release notes for rc1 (#60)


Signed-off-by: David Cui <[email protected]>

* configure index settings to have default 1 replica and auto-expand upperbound 2 (#62)

Signed-off-by: Zhongnan Su <[email protected]>

* Rc1 release note patch (#63)


Signed-off-by: David Cui <[email protected]>

* Bump OpenSearch Dashboards version to 1.0 (#64)


Signed-off-by: David Cui <[email protected]>

* Revert .opensearch_dashboards index references to .kibana (#67)

Signed-off-by: David Cui <[email protected]>

* Add diagrams for integration with Notifications plugin (#75)

* add puml diagrams for integration with Notifications plugin
Signed-off-by: David Cui <[email protected]>

* amend Notifications plugin naming in diagram
Signed-off-by: David Cui <[email protected]>

* Add i18n translation support (#362)

* PDF report is no more a screenshot, increasing the overall quality

Also a issue with chrome font rendering was fixed

* Add Notifications to docs (#87)

* moved docs to root folder, update readme to include Notifications roadmap
Signed-off-by: David Cui <[email protected]>

* update readme to clarify current status of supported features
Signed-off-by: David Cui <[email protected]>

* Better support sorting for csv report based on saved search (#86)

* Change Delivery Request Body for Notifications (#85)

* adding opensearch changed api for report definition to save branch
Signed-off-by: David Cui <[email protected]>

* change delivery request body, update test cases
Signed-off-by: David Cui <[email protected]>

* remove console.log statement, fix DeliveryType type members to use snake case
Signed-off-by: David Cui <[email protected]>

* convert all snake case to camel case
Signed-off-by: David Cui <[email protected]>

* make configId required in schema
Signed-off-by: David Cui <[email protected]>

* Remove legacy notifications/delivery related code (#94)

* remove legacy notifications/delivery related code
Signed-off-by: David Cui <[email protected]>

* remove commented out reference
Signed-off-by: David Cui <[email protected]>

* Remove dependency on demo.elastic and use local mock html for testing (#100)

* Add code cov back (#98)

Signed-off-by: Zhongnan Su <[email protected]>

* update workflow to rename artifact in kebab case (#102)

Signed-off-by: Zhongnan Su <[email protected]>

* bump dependency version (#101)

Signed-off-by: Zhongnan Su <[email protected]>

* level up markdowns and readme (#97)

Signed-off-by: Zhongnan Su <[email protected]>

* Bump to version 1.0.0.0 (#103)

Signed-off-by: Zhongnan Su <[email protected]>

* Bump test resource(job-scheduler) to 1.0.0.0 (#105)

Signed-off-by: Zhongnan Su <[email protected]>

* fix failed cypress integ-testing (#106)

Signed-off-by: Zhongnan Su <[email protected]>

* Bump node version, fix workflow and gradle build (#108)

* Bump nodejs version to keep up with upstream

Signed-off-by: Zhongnan Su <[email protected]>

* fix github workflow

Signed-off-by: Zhongnan Su <[email protected]>

* Add release notes for 1.0.0.0 (#104)

Signed-off-by: Zhongnan Su <[email protected]>

* Fix notebooks context menu (#109)

Signed-off-by: Joshua Li <[email protected]>

* Fix context menu download request body after schema change to add notifiaction (#115)

Signed-off-by: Zhongnan Su <[email protected]>

* Exclude time range from report details for Notebooks  (#117)

* exclude time range check for notebooks reports
Signed-off-by: David Cui <[email protected]>

* use report source identifier over url partial match
Signed-off-by: David Cui <[email protected]>

* add report details fix to release notes
Signed-off-by: David Cui <[email protected]>

* add more bug fixes to release notes
Signed-off-by: David Cui <[email protected]>

* Update regex for notebooks reports (#118)

Signed-off-by: Joshua Li <[email protected]>

* Add integtest script to the repo

Signed-off-by: Peter Zhu <[email protected]>

* Improve osd bootstrap on dub directory

Signed-off-by: Peter Zhu <[email protected]>

* Improve osd bootstrap on dub directory

Signed-off-by: Peter Zhu <[email protected]>

* Exclude Faulty Integration Test  (#122)

Exclude broken ITs from upstream OpenSearch

* Fix cypress reporting (#123)

* fix create test
Signed-off-by: David Cui <[email protected]>

* toggle video on for cypress testing (#124)

Signed-off-by: David Cui <[email protected]>

* Update Doc Links (#127)

* update doc links in dashboards-reports
Signed-off-by: David Cui <[email protected]>

* Update template to reflect new branding (#128)

Signed-off-by: kgcreative <[email protected]>

* Update UI for Notifications Integration (#126)

Update reporting front-end for Notifications integration

Signed-off-by: David Cui <[email protected]>

* Add themed logo to README (#130)

Signed-off-by: Miki <[email protected]>

* Fix url validation (#132)

Signed-off-by: Joshua Li <[email protected]>

* Fix url validation for context menu (#134)

* Fix url validation for context menu

Signed-off-by: Joshua Li <[email protected]>

* Fix url validation

Signed-off-by: Joshua Li <[email protected]>

* Connect Notifications APIs to Reporting (#131)

* call notifications APIs from reporting, saving progress
Signed-off-by: David Cui <[email protected]>

* enable notifications integration, update view in details pages, update tests
Signed-off-by: David Cui <[email protected]>

* address comments, add server APIs to call backend notifications APIs to reduce dependency
Signed-off-by: David Cui <[email protected]>

* add get_event API to confirm test messages are sent successfully and throw error if not
Signed-off-by: David Cui <[email protected]>

* add input validation for delivery subject and message, hide notifications section if opensearch notifications is not installed
Signed-off-by: David Cui <[email protected]>

* renamed constant for notifications to follow API_PREFIX convention
Signed-off-by: David Cui <[email protected]>

* rename notifications constant to reporting_notifications
Signed-off-by: David Cui <[email protected]>

* add list of failed channels on test message failure
Signed-off-by: David Cui <[email protected]>

* Fix snapshot build and upgrade to OpenSearch 1.1. (#140)

Signed-off-by: dblock <[email protected]>

* Add release notes for 1.0.1 release (#143)

Signed-off-by: Joshua Li <[email protected]>

* Bump to 1.1 in main (#150)

* bump version to 1.1, hide delivery section
Signed-off-by: David Cui <[email protected]>

* Dont hide delivery by default
Signed-off-by: David Cui <[email protected]>

* bump version to 1.1 in dashboards reports workflow
Signed-off-by: David Cui <[email protected]>

* fix OSD branch to use main
Signed-off-by: David Cui <[email protected]>

* change from main to 1.x for dashboards version
Signed-off-by: David Cui <[email protected]>

* Bump opensearch ref to 1.1 in CI (#155)

* Removed integtest.sh. (#157)

Signed-off-by: dblock <[email protected]>

* Taking RBAC settings from Alerting plugin default to false

Other changes:
1. Legacy settings removed because all relavent settings are removed or taken from Alerting plugin
2. Poll API removed as it is not used

[Tests]
All existing tests passed

Signed-off-by: @akbhatta

* Bump tmpl from 1.0.4 to 1.0.5 in /dashboards-reports (#164)

Bumps [tmpl](https://github.com/daaku/nodejs-tmpl) from 1.0.4 to 1.0.5.
- [Release notes](https://github.com/daaku/nodejs-tmpl/releases)
- [Commits](https://github.com/daaku/nodejs-tmpl/commits/v1.0.5)

---
updated-dependencies:
- dependency-name: tmpl
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix quoting and url-encoding (#153)

* Replace '%2F' with '/' in relative dates

Signed-off-by: Konstantin Roussou <[email protected]>

* Ensure proper quoting of converted dates in URL

Signed-off-by: Konstantin Roussou <[email protected]>

* Use generic URL decoding

Co-authored-by: Zhongnan Su <[email protected]>

* Use roundUp for toDate

Co-authored-by: Zhongnan Su <[email protected]>

* Make date transformation same as in context_menu_helpers.js

Co-authored-by: Zhongnan Su <[email protected]>

* Integrate notifications backend (#129)

* Remove hard coded localhost when calling API (#172)

* rename plugin helper config file name to consistent with OSD (#180)

Signed-off-by: Tengda He <[email protected]>

* Add metrics for sending notifications (#173)

* Add logic to build report detail page link and send as part of message for non-email channels (#182)

* forward origin plus basePath to backend

* Add build report link function and forward link as part of message

* Update validation for observability notebooks integration (#174)

* Build email message from template with reports links (#184)

* remove the email tempalte and helpers from dashboards plugin

* build email message from template for reporting notifcation

Signed-off-by: Zhongnan Su <[email protected]>

* Support range filters for csv reports (#185)

* Forward extra headers while using headless chromium (#194)

* Use advanced settings for date format in csv reports (#186)

* add check in ReportInstanceActions to fix on demand report creation after report definition creation (#196)

Signed-off by: David Cui <[email protected]>

* Catch Notifications Errors on Details Pages (#197)

* add catch statements to notifications get_configs to avoid crashing details pages
Signed-off by: David Cui <[email protected]>

* remove console log statment
Signed-off by: David Cui <[email protected]>

* remove notifications integration from details pages and update snapshots (#210)

Signed-off-by: David Cui <[email protected]>

* fix csv missing metadata fields issue and empty report on all(_source) fields (#206)

* remove notifications references from create and edit report definition pages (#212)

Signed-off by: David Cui <[email protected]>

* refactor logic for creating DSL from saved object using buildOpensearchQuery() (#213)

* Remove calling notifications in reports scheduler (#211)

* Use advanced settings for csv separator and visual report timezone (#209)

* Bump to version 1.2 (#203)

* Bump to version 1.2

Bump OpenSearch and OpenSearch Dashboards plugins to 1.2

Related issue:
#167

Signed-off-by: Kawika Avilla <[email protected]>

* Use maven for building reports scheduler

Signed-off-by: Joshua Li <[email protected]>

Co-authored-by: Joshua Li <[email protected]>

* Add dco and release drafter workflows (#217)

Signed-off-by: Joshua Li <[email protected]>

* update readme notification section (#216)

Signed-off-by: Zhongnan Su <[email protected]>

* revert paths to opendistro to keep cluster permissions same with ODFE (#218)

Signed-off-by: David Cui <[email protected]>

* Create opensearch-dashboards-reports.release-notes-1.2.0.0.md

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

* Update the copyright notices to reflect OpenSearch Contributors (#220)

* update the copyright notices to reflect OpenSearch Contributors

Signed-off-by: David Cui <[email protected]>

* add .txt to NOTICE to resolve linkchecker error

Signed-off-by: David Cui <[email protected]>

* changes

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

* changes

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

* Remove notifications actions in reports scheduler (#221)

Signed-off-by: Joshua Li <[email protected]>

* add reporting osd server configurations (#222)

Signed-off-by: Zhongnan Su <[email protected]>

* Add suggested font packages in troubleshooting tips (#189)

* add suggested font packages in troubleshooting tips
Signed-off-by: David Cui <[email protected]>

* add links to package documentation in README for font packages
Signed-off-by: David Cui <[email protected]>

* add more descriptive title under Troubleshooting

Signed-off-by: David Cui <[email protected]>

* add link to headless-chrome installation and add ipa-gothic-fonts link to centos 7

Signed-off-by: David Cui <[email protected]>

* Update Copyright Headers (#226)

* update copyright header for all files

Signed-off-by: David Cui <[email protected]>

* fix ktlint errors with extra whitespace

Signed-off-by: David Cui <[email protected]>

* Add support for codeowners to repo (#227)

Signed-off-by: Ryan Bogan <[email protected]>

* Fix reporting validation for observability (#231)

* Update reporting validation for observability

Signed-off-by: Joshua Li <[email protected]>

* update tests

Signed-off-by: Joshua Li <[email protected]>

* remove poller code from frontend plugin (#235)

Signed-off-by: Zhongnan Su <[email protected]>

* bump reports-scheduler to 1.3 (#241)

Signed-off-by: Zhongnan Su <[email protected]>

* Fix apt source and link checker for CI (#245)

* Update apt source in CI

Signed-off-by: Joshua Li <[email protected]>

* Try fix link checker

Signed-off-by: Joshua Li <[email protected]>

* Add Case Coverage tests for Create Report Definition (#239)

* add & refactor cypress tests, add css selectors in report settings & report trigger

Signed-off-by: David Cui <[email protected]>

* remove comment and update jest snapshot

Signed-off-by: David Cui <[email protected]>

* add bwc test for reports-scheduler (#244)

Signed-off-by: Zhongnan Su <[email protected]>

* added code summary table (#243)

* added code summary table

Signed-off-by: Shenoy Pratik <[email protected]>

* modularized tables, fixed links

Signed-off-by: Shenoy Pratik <[email protected]>

* updated header, changed bwc link

Signed-off-by: Shenoy Pratik <[email protected]>

* Add Cypress Case Coverage on Details Pages (#250)

* add and refactor cypress tests for details pages

Signed-off-by: David Cui <[email protected]>

* update jest snapshots

Signed-off-by: David Cui <[email protected]>

* add utils.js file to store functions used in multiple cypress tests

Signed-off-by: David Cui <[email protected]>

* add gradle task to run integtest against remote cluster (#247)

Signed-off-by: Zhongnan Su <[email protected]>

* added untriaged and nolabel badges

Signed-off-by: Shenoy Pratik <[email protected]>

* bump dashboards-reports version to 1.3 (#265)

Signed-off-by: Zhongnan Su <[email protected]>

* add UT for request/reseponse model (#264)

Signed-off-by: Zhongnan Su <[email protected]>

* Add .whitesource configuration file

* Address Reporting CVEs (#267)

* update vulnerable package versions

Signed-off-by: David Cui <[email protected]>

* change ansi-regex to 5.0.1 to pass bootstrap

Signed-off-by: David Cui <[email protected]>

* update yarn lock for cve fixes (#271)

Signed-off-by: David Cui <[email protected]>

* add release notes for 1.2.4

Signed-off-by: David Cui <[email protected]>

* remove jcenter repo from gradle build

Signed-off-by: Shenoy Pratik <[email protected]>

* update guava to 31.0.1-jre

Signed-off-by: Shenoy Pratik <[email protected]>

* WS package update (#283)

* updated ws version

Signed-off-by: Shenoy Pratik <[email protected]>

* moved ws package to resolutions

Signed-off-by: Shenoy Pratik <[email protected]>

* updated yarn lock

Signed-off-by: Shenoy Pratik <[email protected]>

* add auto-backport functionality for reporting (#286)

Add auto-backport and auto-delete workflows for reporting

Signed-off-by: David Cui <[email protected]>

* Change Default CI version to JDK 11 (#290)

* change default CI version to JDK 11, add JDK versions to CI matrix and document changes in developer guide

Signed-off-by: David Cui <[email protected]>

* remove incorrect tag form issue template (#294)

Signed-off-by: Zhongnan Su <[email protected]>

* Fix empty or multiple date values in csv (#293)

Signed-off-by: Zhongnan Su <[email protected]>

* Update the saved object id matcher regex to match custom id (#295)

Signed-off-by: Zhongnan Su <[email protected]>

* Replace Centos links to fix link checker CI (#297)

exclude centos links from linkchecker

Signed-off-by: David Cui <[email protected]>

* update regex to match custom saved object id (#298)

Signed-off-by: Zhongnan Su <[email protected]>

* Fix reporting uuid parsing (#300)

Signed-off-by: Joshua Li <[email protected]>

* Add java 8 support in compile and test (#304) (#305)

* add java 8 support in compile and test

Signed-off-by: Zhongnan Su <[email protected]>
(cherry picked from commit e753b07)

Co-authored-by: Zhongnan Su <[email protected]>

* Add 1.3 release notes (#307) (#308)

* Add 1.3 release notes

Signed-off-by: Zhongnan Su <[email protected]>
(cherry picked from commit 2e904c5)

Co-authored-by: Zhongnan Su <[email protected]>

* Bump version to 1.3.1 (#324)

Signed-off-by: Sayali Gaikawad <[email protected]>

* Bump reports dashboards to 1.3.1 (#331)

Signed-off-by: Joshua Li <[email protected]>

* Incremented version to 1.3.2. (#352)

Signed-off-by: Zelin Hao <[email protected]>

* Version bump 1.3.3

Signed-off-by: pgodithi <[email protected]>

* Version bump 1.3.3

Signed-off-by: pgodithi <[email protected]>

* Version bump 1.3.3

Signed-off-by: pgodithi <[email protected]>

* [1.3] Bump minimist to 1.2.6 (#367)

Signed-off-by: Joshua Li <[email protected]>

* Move HTML sanitization from client to server side (#382) (#386)

Move HTML sanitization to server, store markdown over HTML, remove unused imports

Signed-off-by: David Cui <[email protected]>

Co-authored-by: David Cui <[email protected]>

* Incremented version to 1.3.4. (#389)

* Incremented version to 1.3.4.

Signed-off-by: Zelin Hao <[email protected]>

* Add JS snapshot

Signed-off-by: Zelin Hao <[email protected]>

* Add release notes for 1.3.4.0 (#393) (#394)

Signed-off-by: Joshua Li <[email protected]>
(cherry picked from commit 8e01eaa)

Co-authored-by: Joshua Li <[email protected]>

Co-authored-by: Zhongnan Su <[email protected]>
Co-authored-by: David Cui <[email protected]>
Co-authored-by: Joshua <[email protected]>
Co-authored-by: Carl Meadows <[email protected]>
Co-authored-by: Kevin Masseix <[email protected]>
Co-authored-by: Uzhinskiy Boris <[email protected]>
Co-authored-by: David Cui <[email protected]>
Co-authored-by: starcatter <[email protected]>
Co-authored-by: Elias Soares <[email protected]>
Co-authored-by: Peter Zhu <[email protected]>
Co-authored-by: Kevin Garcia <[email protected]>
Co-authored-by: Miki <[email protected]>
Co-authored-by: David Cui <[email protected]>
Co-authored-by: Daniel Doubrovkine (dB.) <[email protected]>
Co-authored-by: Anantha Krishna Bhatta <[email protected]>
Co-authored-by: Anantha Krishna Bhatta <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: kroussou <[email protected]>
Co-authored-by: Tengda-He <[email protected]>
Co-authored-by: Kawika Avilla <[email protected]>
Co-authored-by: Kavitha Conjeevaram Mohan <[email protected]>
Co-authored-by: Kavitha Conjeevaram Mohan <[email protected]>
Co-authored-by: Ryan Bogan <[email protected]>
Co-authored-by: whitesource-for-github.aaakk.us.kg[bot] <50673670+whitesource-for-github.aaakk.us.kg[bot]@users.noreply.github.com>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: Sayali Gaikawad <[email protected]>
Co-authored-by: Zelin Hao <[email protected]>
Co-authored-by: pgodithi <[email protected]>
Co-authored-by: Anirudha (Ani) Jadhav <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

9 participants