Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] doc[field] == null causing error in CSV report #40

Closed
zhongnansu opened this issue May 13, 2021 · 4 comments
Closed

[BUG] doc[field] == null causing error in CSV report #40

zhongnansu opened this issue May 13, 2021 · 4 comments
Assignees
Labels
bug Something isn't working untriaged
Milestone

Comments

@zhongnansu
Copy link
Member

zhongnansu commented May 13, 2021

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Plugins
Please list all plugins currently enabled.

Screenshots
If applicable, add screenshots to help explain your problem.

Host/Environment (please complete the following information):

  • OS: [e.g. iOS]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.


Version

Opendistro Elasticsearch 1.13.0 standalone linux
Opendistro Kibana 1.13.0 standalone linux

Error description

If the saved discover table includes a null value the csv export will fail with the error message:

[08:16:09.781] [error][opendistroReportsKibana][plugins] Failed to generate report: TypeError: Cannot read property 'toString' of null
  log   [08:16:09.782] [error][opendistroReportsKibana][plugins] TypeError: Cannot read property 'toString' of null
    at sanitize (/srv/opendistroforelasticsearch-kibana/plugins/opendistroReportsKibana/server/routes/utils/dataReportHelpers.ts:227:18)
    at getEsData (/srv/opendistroforelasticsearch-kibana/plugins/opendistroReportsKibana/server/routes/utils/dataReportHelpers.ts:172:34)
    at convertEsDataToCsv (/srv/opendistroforelasticsearch-kibana/plugins/opendistroReportsKibana/server/routes/utils/savedSearchReportHelper.ts:266:18)
    at generateReportData (/srv/opendistroforelasticsearch-kibana/plugins/opendistroReportsKibana/server/routes/utils/savedSearchReportHelper.ts:151:10)
    at process._tickCallback (internal/process/next_tick.js:68:7)
 error  [08:16:07.104]  Error: Internal Server Error
    at HapiResponseAdapter.toError (/srv/opendistroforelasticsearch-kibana/src/core/server/http/router/response_adapter.js:132:19)
    at HapiResponseAdapter.toHapiResponse (/srv/opendistroforelasticsearch-kibana/src/core/server/http/router/response_adapter.js:86:19)
    at HapiResponseAdapter.handle (/srv/opendistroforelasticsearch-kibana/src/core/server/http/router/response_adapter.js:81:17)
    at Router.handle (/srv/opendistroforelasticsearch-kibana/src/core/server/http/router/router.js:164:34)
    at process._tickCallback (internal/process/next_tick.js:68:7)

This issue is submitted by @Artain
opendistro-for-elasticsearch/kibana-reports#327

@ostigley
Copy link

@zhongnansu thanks for merging PR #361. What is the release schedule looking like? I'm keen to install this update.

@zhongnansu
Copy link
Member Author

zhongnansu commented Jun 10, 2021

@ostigley Hi, the PR you referred to has been merged to our latest rc1 release. Please check it out : )
https://opensearch.org/downloads.html

@ostigley
Copy link

ostigley commented Jun 13, 2021

Thanks @zhongnansu. I'm using docker for my opendistro stack, so I was hoping to have version 1.13.2.? ready to install in my docker file for this plugin: https://github.com/opendistro-for-elasticsearch/kibana-reports. 1.13.2.0 installs with bugs.

Thanks again for merging the fix though. Let me know if i've miss-understood anything.

@zhongnansu
Copy link
Member Author

Thanks @zhongnansu. I'm using docker for my opendistro stack, so I was hoping to have version 1.13.2.? ready to install in my docker file for this plugin: https://github.com/opendistro-for-elasticsearch/kibana-reports. 1.13.2.0 installs with bugs.

Thanks again for merging the fix though. Let me know if i've miss-understood anything.

Currently there's no plan for any security related patch release on the opendistro stack, since we have migrated to the OpenSearch. I asked the team in this thread https://github.com/opensearch-project/opensearch-plugins/issues/69

You can however build your own artifact since the opendistro codebase is still there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working untriaged
Projects
None yet
Development

No branches or pull requests

2 participants