Added validation that vector is not NaN

src/main/java/com/amazon/opendistroforelasticsearch/knn/index/KNNVectorFieldMapper.java

@@ -246,15 +246,35 @@ public void parse(ParseContext context) throws IOException {
 
         ArrayList<Float> vector = new ArrayList<>();
         XContentParser.Token token = context.parser().currentToken();
-
+        float value;
         if (token == XContentParser.Token.START_ARRAY) {
             token = context.parser().nextToken();
             while (token != XContentParser.Token.END_ARRAY) {
-                vector.add(context.parser().floatValue());
+                value = context.parser().floatValue();
+
+                if (Float.isNaN(value)) {
+                    throw new IllegalArgumentException("KNN vector values cannot be NaN");
+                }
+
+                if (Float.isInfinite(value)) {
+                    throw new IllegalArgumentException("KNN vector values cannot be infinity");
+                }
+
+                vector.add(value);
                 token = context.parser().nextToken();
             }
         } else if (token == XContentParser.Token.VALUE_NUMBER) {
-            vector.add(context.parser().floatValue());
+            value = context.parser().floatValue();
+
+            if (Float.isNaN(value)) {
+                throw new IllegalArgumentException("KNN vector values cannot be NaN");
+            }
+
+            if (Float.isInfinite(value)) {
+                throw new IllegalArgumentException("KNN vector values cannot be infinity");
+            }
+
+            vector.add(value);
             context.parser().nextToken();
         }
 

src/test/java/com/amazon/opendistroforelasticsearch/knn/index/KNNESIT.java

@@ -155,6 +155,30 @@ public void testVectorMappingValidationInvalidDimension() {
                 KNNVectorFieldMapper.MAX_DIMENSION + " for vector: " + FIELD_NAME));
     }
 
+    public void testVectorMappingValidationInvalidVectorNaN() throws IOException {
+        Settings settings = Settings.builder()
+                .put(getKNNDefaultIndexSettings())
+                .build();
+
+        createKnnIndex(INDEX_NAME, settings, createKnnIndexMapping(FIELD_NAME, 2));
+
+        Float[] vector = {Float.NaN, Float.NaN};
+        Exception ex = expectThrows(ResponseException.class, () -> addKnnDoc(INDEX_NAME, "3", FIELD_NAME, vector));
+        assertThat(ex.getMessage(), containsString("KNN vector values cannot be NaN"));
+    }
+
+    public void testVectorMappingValidationInvalidVectorInfinity() throws IOException {
+        Settings settings = Settings.builder()
+                .put(getKNNDefaultIndexSettings())
+                .build();
+
+        createKnnIndex(INDEX_NAME, settings, createKnnIndexMapping(FIELD_NAME, 2));
+
+        Float[] vector = {Float.POSITIVE_INFINITY, Float.POSITIVE_INFINITY};
+        Exception ex = expectThrows(ResponseException.class, () -> addKnnDoc(INDEX_NAME, "3", FIELD_NAME, vector));
+        assertThat(ex.getMessage(), containsString("KNN vector values cannot be infinity"));
+    }
+
     public void testVectorMappingValidationUpdateDimension() throws Exception {
         Settings settings = Settings.builder()
                                     .put(getKNNDefaultIndexSettings())