This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Added validation that vector is not NaN #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vamshin
reviewed
Apr 27, 2020
| @@ -250,10 +250,16 @@ public void parse(ParseContext context) throws IOException { | |||
| if (token == XContentParser.Token.START_ARRAY) { | |||
| token = context.parser().nextToken(); | |||
| while (token != XContentParser.Token.END_ARRAY) { | |||
| if (Float.isNaN(context.parser().floatValue())) { | |||
There was a problem hiding this comment.
Should we also add check for Float.isInfinite?
https://docs.oracle.com/javase/7/docs/api/java/lang/Float.html#isInfinite(float)
There was a problem hiding this comment.
Yes I think that makes sense.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#99
Description of changes:
Added validation in VectorFieldMapper to check for vector values of NaN and throwing an Exception if so.
Added test case.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.