Bugfix/mask credentials #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsauter
approved these changes
May 19, 2020
There was a problem hiding this comment.
Fine by me. I opened #345 as a follow-up as here we are just dealing with a problem which we shouldn't have in the first place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #212
While I was not able to reproduce the issue that credentials inside withCredential blocks were displayed in blue ocean (as mentioned in the issue) anymore, I found next to the Snyk issue another one when receiving bitbucket token via the API. The response (with the token) is read by readJSON outside of a withCredentials block which prints it in the output log. I just moved it inside, I don't see any change in the logic doing that.