Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

odsComponentStageCopyImage outputs/logs skopeo registry credentials (src, dst) #1178

Open
tbugfinder opened this issue Oct 29, 2024 · 0 comments

Comments

@tbugfinder
Copy link
Contributor

The odsComponentStageCopyImage logs the source and destination credentials as the shell output is not masked or postprocessed.

A simple approach could be using set +x or adding some wtihCredentials code.
Using set +x might be quickest solution however a user might still need details of the command.

script: """
skopeo copy ${copyparams} \
--src-tls-verify=${this.options.verifyTLS} ${sourcetoken} \
${this.options.registry}/${this.options.repo}/${this.options.image} \
--dest-creds openshift:${targetInternalRegistryToken} \
${dockerProtocol}${context.clusterRegistryAddress}/${context.cdProject}/${this.options.image} \
--dest-tls-verify=${this.options.verifyTLS}

Ref: #212 #341

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant