It takes more than 10 minutes for kserve-controller to be created during 2.17 installation

[lburgazzoli]

Description

The Kserve component requires certain resources to be available and ready, which may not always be the case, especially when the the operator starts on a fresh installation. To handle this, a wait condition was implemented; however, it did not properly check for errors. As a result, the wait loop was prematurely stopped, and no retry attempts were made until the next reconcile loop. Additionally, the Kserve component was not monitoring the DSCI, leading to further delays as any transition phases of the DSCI were ignored

https://issues.redhat.com/browse/RHOAIENG-18425

How Has This Been Tested?

1. create DSCI and DSC as part of the same yaml file (with serverless enabled and kserve enabled as well)
2. apply the file
3. watch the Kserve component progressing

Screenshot or short clip

DSCI created at 2025-01-24T16:05:19Z

apiVersion: v1
items:
- apiVersion: dscinitialization.opendatahub.io/v1
  kind: DSCInitialization
  metadata:
    creationTimestamp: "2025-01-24T16:05:19Z"

Kserve created at 2025-01-24T16:05:20Z
Kserve becomes ready at 2025-01-24T16:06:34Z

apiVersion: components.platform.opendatahub.io/v1alpha1
kind: Kserve
metadata:
  annotations:
    component.opendatahub.io/management-state: Managed
  creationTimestamp: "2025-01-24T16:05:20Z"
  name: default-kserve
status:
  conditions:
  - lastTransitionTime: "2025-01-24T16:06:34Z"
    message: 1/1 deployments ready
    observedGeneration: 1
    reason: Ready
    status: "True"
    type: Ready
  defaultDeploymentMode: Serverless
  observedGeneration: 1
  phase: Ready

Merge criteria

• You have read the contributors guide.
• Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
• Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

[codecov]

Codecov Report

Attention: Patch coverage is 25.80645% with 23 lines in your changes missing coverage. Please review.

Project coverage is 19.83%. Comparing base (bc63cfd) to head (1ce975e).
Report is 5 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/controller/predicates/resources/resources.go	0.00%	19 Missing ⚠️
pkg/feature/servicemesh/conditions.go	66.66%	2 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1564      +/-   ##
==========================================
- Coverage   19.84%   19.83%   -0.02%     
==========================================
  Files         159      159              
  Lines       10794    10820      +26     
==========================================
+ Hits         2142     2146       +4     
- Misses       8424     8445      +21     
- Partials      228      229       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[zdtsw]

LGTM

[MarianMacik]

LGTM

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CFSNM, MarianMacik, zdtsw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [CFSNM,MarianMacik,zdtsw]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment