-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid modelmesh and Kserve loop on updating shared CRDs #1547
Avoid modelmesh and Kserve loop on updating shared CRDs #1547
Conversation
Probably it should be named something like "Avoid modelmesh and Kserve loop on updating shared CRDs" because now it's just a declaration of a fact. |
The KServe and ModelMesh are shipping the same CRDs as part of their manifests but with different versions, this cause the respective component reconcilers to keep trying to install their respective version, ending in a infinite loop. This commit does not solve the underlying problem of having two components shipping the same CRDs with different versions, but avoids the infinite reconcile loop. The CRDs that is actually installed on the cluster is undefined, the latest one that is applied wins
1fc3065
to
36b829c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested with change local, works as fixing the reconcilation issue when both kserve and modelmesh are enabled at the same time
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zdtsw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test all |
/test opendatahub-operator-e2e |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1547 +/- ##
==========================================
+ Coverage 19.70% 19.81% +0.11%
==========================================
Files 160 160
Lines 10979 10917 -62
==========================================
Hits 2163 2163
+ Misses 8588 8526 -62
Partials 228 228 ☔ View full report in Codecov by Sentry. |
5bcbaba
into
opendatahub-io:main
commit 0f1cf7dd9ca20e41c97a1590e18dc888b68e9fd5 Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 11:40:58 2025 +0100 fix lint error commit 473e86f55fd87e496c5d4251d075dc1082ce6e4c Author: Ugo Giordano <[email protected]> Date: Mon Jan 27 16:42:00 2025 +0100 Map component versions to RHOAI status for better visibility commit 3d47679 Merge: d706b92 bd00c9b Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 11:32:16 2025 +0100 Merge branch 'main' into RHOAIENG-11648/component-mapping-refactor commit d706b92 Author: Ugo Giordano <[email protected]> Date: Tue Jan 28 18:00:29 2025 +0100 Remove fetch releases action from dashboard & e2e tests commit 4e0deb2 Author: Ugo Giordano <[email protected]> Date: Tue Jan 28 16:10:28 2025 +0100 unit test e2e tests commit bd00c9b Author: Luca Burgazzoli <[email protected]> Date: Tue Jan 28 23:53:01 2025 +0100 Improve Kserve's FeatureTraker handing (opendatahub-io#1562) * Improve Kserve's FeatureTraker handing - Make it possible to set FT's OwnerReference as Controller reference so the kubernetes garbage collector can block owner deletion till the FT has been deleted - Make it possible to set FT's generated resources OwnerReference as Controller reference so the kubernetes garbage collector can block FT deletion till the resources have been deleted - Add an Kserver reconciler action to remove legacy ownership on DSCI/DSC is any and related e2e tests * Update RBACs * Update RBACs * Fix findings * Update pkg/cluster/meta.go Co-authored-by: Gerard Ryan <[email protected]> * Fix renaming * Remove unrelated methods --------- Co-authored-by: Gerard Ryan <[email protected]> commit df5495e Author: Wen Zhou <[email protected]> Date: Tue Jan 28 21:21:23 2025 +0100 docs: remove duplicated files and update integration docs (opendatahub-io#1575) Signed-off-by: Wen Zhou <[email protected]> commit ca2f619 Author: Wen Zhou <[email protected]> Date: Tue Jan 28 21:02:36 2025 +0100 fix: missing update permission on dashboard object (opendatahub-io#1576) - add update on all cases Signed-off-by: Wen Zhou <[email protected]> commit a996732 Author: Wen Zhou <[email protected]> Date: Tue Jan 28 20:50:56 2025 +0100 fix: fix wrong map for DSP images (opendatahub-io#1577) - the old images are from 2.15 which have been updated during 2.16 Signed-off-by: Wen Zhou <[email protected]> commit 94095f9 Author: Dipanshu Gupta <[email protected]> Date: Tue Jan 28 21:57:25 2025 +0530 Setup admin permissions for hardware profiles (opendatahub-io#1573) commit 3056ab4 Author: Ajay Jaganathan <[email protected]> Date: Tue Jan 28 17:58:06 2025 +0530 (fix): point to correct path for component integration doc (opendatahub-io#1574) commit d538956 Author: Luca Burgazzoli <[email protected]> Date: Tue Jan 28 10:01:48 2025 +0100 chore: use constants from the status package where possible (opendatahub-io#1541) Co-authored-by: Wen Zhou <[email protected]> commit 9aed5e0 Author: Andrew Ballantyne <[email protected]> Date: Mon Jan 27 13:20:04 2025 -0500 Clarify and update permissions (opendatahub-io#1538) * Add readme to explain values of permissions * NIM Accounts are namespaced resources * Update permissions to fulfill doc design * Based on feedback, less hard-fast ruling wording in the README commit 5e60591 Author: Wen Zhou <[email protected]> Date: Mon Jan 27 17:33:51 2025 +0100 test: disable monitoring config in DSCI for ODH e2e test (opendatahub-io#1570) - we do not enable monitoring in ODH logic - we should keep it enable for rhoai branch Signed-off-by: Wen Zhou <[email protected]> commit a8eb6ff Author: Ugo Giordano <[email protected]> Date: Mon Jan 27 16:51:31 2025 +0100 fix lint add updated api doc commit 4b76ca4 Author: Ugo Giordano <[email protected]> Date: Mon Jan 27 16:42:00 2025 +0100 Map component versions to RHOAI status for better visibility commit 48341ff Author: Luca Burgazzoli <[email protected]> Date: Mon Jan 27 15:38:21 2025 +0100 It takes more than 10 minutes for kserve-controller to be created during 2.17 installation (opendatahub-io#1564) * It takes more than 10 minutes for kserve-controller to be created during 2.17 installation * cleanup commit b0a0f87 Author: Wen Zhou <[email protected]> Date: Mon Jan 27 13:53:40 2025 +0100 update: clean up old code before refactor (opendatahub-io#1494) * update: clean up old code before refactor - remove reference we explicilty check on odhdashboardconfig and kserve - remove customized config on controller QPS - remove RemoveLabel which is not called anywhere Signed-off-by: Wen Zhou <[email protected]> * update: - remove function for upgrade cleanup introduced before 2.8 - remove flags to main: operator namespace and application namespace ( operator namespace is passing as env variable, app namespace is done by DSCI ) Signed-off-by: Wen Zhou <[email protected]> * fix: Auth CR is cluster-scoped no need to set namespace for request - application namespace is removed from reconciler of dsci Signed-off-by: Wen Zhou <[email protected]> * fix: wrong code for upgrade path + rebase error Signed-off-by: Wen Zhou <[email protected]> --------- Signed-off-by: Wen Zhou <[email protected]> commit 7b4dfc2 Author: Wen Zhou <[email protected]> Date: Mon Jan 27 12:01:07 2025 +0100 fix: for upgrade case we will need update permission on buildconfig to revmoew ownerref from dsc (opendatahub-io#1567) Signed-off-by: Wen Zhou <[email protected]> commit a00aa61 Author: Wen Zhou <[email protected]> Date: Mon Jan 27 09:00:32 2025 +0100 fix: add matchlabel on NWP for customized appliation (opendatahub-io#1566) - update README and troubleshooting Signed-off-by: Wen Zhou <[email protected]> commit eb42450 Author: Manjunath Kumatagi <[email protected]> Date: Fri Jan 24 19:11:14 2025 +0530 Build platform independent binary based on the target platform (opendatahub-io#1549) commit bc63cfd Author: Wen Zhou <[email protected]> Date: Thu Jan 23 21:04:44 2025 +0100 update: change previous workaround for subscription and add smcp in the list (opendatahub-io#1557) - remove subs from client cache - add smcp into exclude cache Signed-off-by: Wen Zhou <[email protected]> commit 63d4eab Author: Wen Zhou <[email protected]> Date: Thu Jan 23 18:44:37 2025 +0100 fix: missing monitoring NS for NWP if user opt customized app NS (opendatahub-io#1558) Signed-off-by: Wen Zhou <[email protected]> commit 912dcaa Author: Ugo Giordano <[email protected]> Date: Thu Jan 23 16:56:32 2025 +0100 Align get_all_manifests.sh with Kubeflow main branch (opendatahub-io#1550) commit ce7b381 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Thu Jan 23 14:08:54 2025 +0100 Update version to 2.23.1 (opendatahub-io#1553) Co-authored-by: zdtsw <[email protected]> commit 9845f7e Author: Wen Zhou <[email protected]> Date: Thu Jan 23 14:07:25 2025 +0100 update: various fix backport from RHOAI (opendatahub-io#1536) - fix missing RHOAI monitoring namespace for self-managed - fix wrong namespace name in manifests - update hardcode label name - fix misleading log message Signed-off-by: Wen Zhou <[email protected]> commit 871c799 Author: Wen Zhou <[email protected]> Date: Thu Jan 23 13:21:29 2025 +0100 fix: as a workaround for getting knative opreator check, set cache (opendatahub-io#1555) Signed-off-by: Wen Zhou <[email protected]> commit 28d0fa1 Author: Wen Zhou <[email protected]> Date: Thu Jan 23 11:49:37 2025 +0100 fix: add missing namespace for console in managed cluster (opendatahub-io#1552) - blackbox require this - move into const in cluster pkg Signed-off-by: Wen Zhou <[email protected]> commit 5bcbaba Author: Luca Burgazzoli <[email protected]> Date: Wed Jan 22 19:31:20 2025 +0100 Avoid modelmesh and Kserve loop on updating shared CRDs (opendatahub-io#1547) The KServe and ModelMesh are shipping the same CRDs as part of their manifests but with different versions, this cause the respective component reconcilers to keep trying to install their respective version, ending in a infinite loop. This commit does not solve the underlying problem of having two components shipping the same CRDs with different versions, but avoids the infinite reconcile loop. The CRDs that is actually installed on the cluster is undefined, the latest one that is applied wins commit 8c7fef2 Author: Luca Burgazzoli <[email protected]> Date: Wed Jan 22 15:45:51 2025 +0100 chore: remove unused code (opendatahub-io#1543) * chore: remove unused TrimToRFC1123Name function * chore: remove unused pkg/cluster/roles functions * chore: remove unused pkg/cluster/resources functions commit e83f2fc Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Wed Jan 22 13:49:00 2025 +0100 Update version to 2.23.0 (opendatahub-io#1544) Co-authored-by: zdtsw <[email protected]> commit 21eba1b Author: Luca Burgazzoli <[email protected]> Date: Wed Jan 22 12:38:49 2025 +0100 chore: cleanup Monitoring's initialize action (opendatahub-io#1542) The Monitoring controller is initialized only when the platform is managed, hence there's no need to conditionally add manifests commit 5321b8c Author: Luca Burgazzoli <[email protected]> Date: Wed Jan 22 11:05:23 2025 +0100 fix: use Monitoring.Spec.Namespace instead of the DSCI one (opendatahub-io#1540) This reduce the direct dependency from Monitoring to DSCI
commit 8caaedfbbc7da4890f41496275a71e4364730646 Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 16:09:34 2025 +0100 added generated files commit aedbf41 Merge: 9135927 6e134b1 Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 16:00:38 2025 +0100 Merge branch 'main' into RHOAIENG-11648/component-mapping-refactor commit 9135927 Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 15:28:08 2025 +0100 removed releases from dashboard since not needed and renamed ComponentReleaseStatus into ComponentRelease commit 237806d Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 12:56:50 2025 +0100 removed releases from dashboard since not needed commit 6e134b1 Author: Wen Zhou <[email protected]> Date: Wed Jan 29 12:41:18 2025 +0100 fix: missing permission to update prometheusrules (opendatahub-io#1581) Signed-off-by: Wen Zhou <[email protected]> commit a044cda Merge: 2571965 bd00c9b Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 12:13:12 2025 +0100 Merge branch 'main' into RHOAIENG-11648/component-mapping-refactor commit 2571965 Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 11:42:27 2025 +0100 Map component versions to RHOAI status for better visibility commit 0f1cf7dd9ca20e41c97a1590e18dc888b68e9fd5 Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 11:40:58 2025 +0100 fix lint error commit 473e86f55fd87e496c5d4251d075dc1082ce6e4c Author: Ugo Giordano <[email protected]> Date: Mon Jan 27 16:42:00 2025 +0100 Map component versions to RHOAI status for better visibility commit 3d47679 Merge: d706b92 bd00c9b Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 11:32:16 2025 +0100 Merge branch 'main' into RHOAIENG-11648/component-mapping-refactor commit d706b92 Author: Ugo Giordano <[email protected]> Date: Tue Jan 28 18:00:29 2025 +0100 Remove fetch releases action from dashboard & e2e tests commit 4e0deb2 Author: Ugo Giordano <[email protected]> Date: Tue Jan 28 16:10:28 2025 +0100 unit test e2e tests commit bd00c9b Author: Luca Burgazzoli <[email protected]> Date: Tue Jan 28 23:53:01 2025 +0100 Improve Kserve's FeatureTraker handing (opendatahub-io#1562) * Improve Kserve's FeatureTraker handing - Make it possible to set FT's OwnerReference as Controller reference so the kubernetes garbage collector can block owner deletion till the FT has been deleted - Make it possible to set FT's generated resources OwnerReference as Controller reference so the kubernetes garbage collector can block FT deletion till the resources have been deleted - Add an Kserver reconciler action to remove legacy ownership on DSCI/DSC is any and related e2e tests * Update RBACs * Update RBACs * Fix findings * Update pkg/cluster/meta.go Co-authored-by: Gerard Ryan <[email protected]> * Fix renaming * Remove unrelated methods --------- Co-authored-by: Gerard Ryan <[email protected]> commit df5495e Author: Wen Zhou <[email protected]> Date: Tue Jan 28 21:21:23 2025 +0100 docs: remove duplicated files and update integration docs (opendatahub-io#1575) Signed-off-by: Wen Zhou <[email protected]> commit ca2f619 Author: Wen Zhou <[email protected]> Date: Tue Jan 28 21:02:36 2025 +0100 fix: missing update permission on dashboard object (opendatahub-io#1576) - add update on all cases Signed-off-by: Wen Zhou <[email protected]> commit a996732 Author: Wen Zhou <[email protected]> Date: Tue Jan 28 20:50:56 2025 +0100 fix: fix wrong map for DSP images (opendatahub-io#1577) - the old images are from 2.15 which have been updated during 2.16 Signed-off-by: Wen Zhou <[email protected]> commit 94095f9 Author: Dipanshu Gupta <[email protected]> Date: Tue Jan 28 21:57:25 2025 +0530 Setup admin permissions for hardware profiles (opendatahub-io#1573) commit 3056ab4 Author: Ajay Jaganathan <[email protected]> Date: Tue Jan 28 17:58:06 2025 +0530 (fix): point to correct path for component integration doc (opendatahub-io#1574) commit d538956 Author: Luca Burgazzoli <[email protected]> Date: Tue Jan 28 10:01:48 2025 +0100 chore: use constants from the status package where possible (opendatahub-io#1541) Co-authored-by: Wen Zhou <[email protected]> commit 9aed5e0 Author: Andrew Ballantyne <[email protected]> Date: Mon Jan 27 13:20:04 2025 -0500 Clarify and update permissions (opendatahub-io#1538) * Add readme to explain values of permissions * NIM Accounts are namespaced resources * Update permissions to fulfill doc design * Based on feedback, less hard-fast ruling wording in the README commit 5e60591 Author: Wen Zhou <[email protected]> Date: Mon Jan 27 17:33:51 2025 +0100 test: disable monitoring config in DSCI for ODH e2e test (opendatahub-io#1570) - we do not enable monitoring in ODH logic - we should keep it enable for rhoai branch Signed-off-by: Wen Zhou <[email protected]> commit a8eb6ff Author: Ugo Giordano <[email protected]> Date: Mon Jan 27 16:51:31 2025 +0100 fix lint add updated api doc commit 4b76ca4 Author: Ugo Giordano <[email protected]> Date: Mon Jan 27 16:42:00 2025 +0100 Map component versions to RHOAI status for better visibility commit 48341ff Author: Luca Burgazzoli <[email protected]> Date: Mon Jan 27 15:38:21 2025 +0100 It takes more than 10 minutes for kserve-controller to be created during 2.17 installation (opendatahub-io#1564) * It takes more than 10 minutes for kserve-controller to be created during 2.17 installation * cleanup commit b0a0f87 Author: Wen Zhou <[email protected]> Date: Mon Jan 27 13:53:40 2025 +0100 update: clean up old code before refactor (opendatahub-io#1494) * update: clean up old code before refactor - remove reference we explicilty check on odhdashboardconfig and kserve - remove customized config on controller QPS - remove RemoveLabel which is not called anywhere Signed-off-by: Wen Zhou <[email protected]> * update: - remove function for upgrade cleanup introduced before 2.8 - remove flags to main: operator namespace and application namespace ( operator namespace is passing as env variable, app namespace is done by DSCI ) Signed-off-by: Wen Zhou <[email protected]> * fix: Auth CR is cluster-scoped no need to set namespace for request - application namespace is removed from reconciler of dsci Signed-off-by: Wen Zhou <[email protected]> * fix: wrong code for upgrade path + rebase error Signed-off-by: Wen Zhou <[email protected]> --------- Signed-off-by: Wen Zhou <[email protected]> commit 7b4dfc2 Author: Wen Zhou <[email protected]> Date: Mon Jan 27 12:01:07 2025 +0100 fix: for upgrade case we will need update permission on buildconfig to revmoew ownerref from dsc (opendatahub-io#1567) Signed-off-by: Wen Zhou <[email protected]> commit a00aa61 Author: Wen Zhou <[email protected]> Date: Mon Jan 27 09:00:32 2025 +0100 fix: add matchlabel on NWP for customized appliation (opendatahub-io#1566) - update README and troubleshooting Signed-off-by: Wen Zhou <[email protected]> commit eb42450 Author: Manjunath Kumatagi <[email protected]> Date: Fri Jan 24 19:11:14 2025 +0530 Build platform independent binary based on the target platform (opendatahub-io#1549) commit bc63cfd Author: Wen Zhou <[email protected]> Date: Thu Jan 23 21:04:44 2025 +0100 update: change previous workaround for subscription and add smcp in the list (opendatahub-io#1557) - remove subs from client cache - add smcp into exclude cache Signed-off-by: Wen Zhou <[email protected]> commit 63d4eab Author: Wen Zhou <[email protected]> Date: Thu Jan 23 18:44:37 2025 +0100 fix: missing monitoring NS for NWP if user opt customized app NS (opendatahub-io#1558) Signed-off-by: Wen Zhou <[email protected]> commit 912dcaa Author: Ugo Giordano <[email protected]> Date: Thu Jan 23 16:56:32 2025 +0100 Align get_all_manifests.sh with Kubeflow main branch (opendatahub-io#1550) commit ce7b381 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Thu Jan 23 14:08:54 2025 +0100 Update version to 2.23.1 (opendatahub-io#1553) Co-authored-by: zdtsw <[email protected]> commit 9845f7e Author: Wen Zhou <[email protected]> Date: Thu Jan 23 14:07:25 2025 +0100 update: various fix backport from RHOAI (opendatahub-io#1536) - fix missing RHOAI monitoring namespace for self-managed - fix wrong namespace name in manifests - update hardcode label name - fix misleading log message Signed-off-by: Wen Zhou <[email protected]> commit 871c799 Author: Wen Zhou <[email protected]> Date: Thu Jan 23 13:21:29 2025 +0100 fix: as a workaround for getting knative opreator check, set cache (opendatahub-io#1555) Signed-off-by: Wen Zhou <[email protected]> commit 28d0fa1 Author: Wen Zhou <[email protected]> Date: Thu Jan 23 11:49:37 2025 +0100 fix: add missing namespace for console in managed cluster (opendatahub-io#1552) - blackbox require this - move into const in cluster pkg Signed-off-by: Wen Zhou <[email protected]> commit 5bcbaba Author: Luca Burgazzoli <[email protected]> Date: Wed Jan 22 19:31:20 2025 +0100 Avoid modelmesh and Kserve loop on updating shared CRDs (opendatahub-io#1547) The KServe and ModelMesh are shipping the same CRDs as part of their manifests but with different versions, this cause the respective component reconcilers to keep trying to install their respective version, ending in a infinite loop. This commit does not solve the underlying problem of having two components shipping the same CRDs with different versions, but avoids the infinite reconcile loop. The CRDs that is actually installed on the cluster is undefined, the latest one that is applied wins commit 8c7fef2 Author: Luca Burgazzoli <[email protected]> Date: Wed Jan 22 15:45:51 2025 +0100 chore: remove unused code (opendatahub-io#1543) * chore: remove unused TrimToRFC1123Name function * chore: remove unused pkg/cluster/roles functions * chore: remove unused pkg/cluster/resources functions commit e83f2fc Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Wed Jan 22 13:49:00 2025 +0100 Update version to 2.23.0 (opendatahub-io#1544) Co-authored-by: zdtsw <[email protected]> commit 21eba1b Author: Luca Burgazzoli <[email protected]> Date: Wed Jan 22 12:38:49 2025 +0100 chore: cleanup Monitoring's initialize action (opendatahub-io#1542) The Monitoring controller is initialized only when the platform is managed, hence there's no need to conditionally add manifests commit 5321b8c Author: Luca Burgazzoli <[email protected]> Date: Wed Jan 22 11:05:23 2025 +0100 fix: use Monitoring.Spec.Namespace instead of the DSCI one (opendatahub-io#1540) This reduce the direct dependency from Monitoring to DSCI
commit 8caaedfbbc7da4890f41496275a71e4364730646 Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 16:09:34 2025 +0100 added generated files commit aedbf41 Merge: 9135927 6e134b1 Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 16:00:38 2025 +0100 Merge branch 'main' into RHOAIENG-11648/component-mapping-refactor commit 9135927 Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 15:28:08 2025 +0100 removed releases from dashboard since not needed and renamed ComponentReleaseStatus into ComponentRelease commit 237806d Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 12:56:50 2025 +0100 removed releases from dashboard since not needed commit 6e134b1 Author: Wen Zhou <[email protected]> Date: Wed Jan 29 12:41:18 2025 +0100 fix: missing permission to update prometheusrules (opendatahub-io#1581) Signed-off-by: Wen Zhou <[email protected]> commit a044cda Merge: 2571965 bd00c9b Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 12:13:12 2025 +0100 Merge branch 'main' into RHOAIENG-11648/component-mapping-refactor commit 2571965 Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 11:42:27 2025 +0100 Map component versions to RHOAI status for better visibility commit 0f1cf7dd9ca20e41c97a1590e18dc888b68e9fd5 Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 11:40:58 2025 +0100 fix lint error commit 473e86f55fd87e496c5d4251d075dc1082ce6e4c Author: Ugo Giordano <[email protected]> Date: Mon Jan 27 16:42:00 2025 +0100 Map component versions to RHOAI status for better visibility commit 3d47679 Merge: d706b92 bd00c9b Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 11:32:16 2025 +0100 Merge branch 'main' into RHOAIENG-11648/component-mapping-refactor commit d706b92 Author: Ugo Giordano <[email protected]> Date: Tue Jan 28 18:00:29 2025 +0100 Remove fetch releases action from dashboard & e2e tests commit 4e0deb2 Author: Ugo Giordano <[email protected]> Date: Tue Jan 28 16:10:28 2025 +0100 unit test e2e tests commit bd00c9b Author: Luca Burgazzoli <[email protected]> Date: Tue Jan 28 23:53:01 2025 +0100 Improve Kserve's FeatureTraker handing (opendatahub-io#1562) * Improve Kserve's FeatureTraker handing - Make it possible to set FT's OwnerReference as Controller reference so the kubernetes garbage collector can block owner deletion till the FT has been deleted - Make it possible to set FT's generated resources OwnerReference as Controller reference so the kubernetes garbage collector can block FT deletion till the resources have been deleted - Add an Kserver reconciler action to remove legacy ownership on DSCI/DSC is any and related e2e tests * Update RBACs * Update RBACs * Fix findings * Update pkg/cluster/meta.go Co-authored-by: Gerard Ryan <[email protected]> * Fix renaming * Remove unrelated methods --------- Co-authored-by: Gerard Ryan <[email protected]> commit df5495e Author: Wen Zhou <[email protected]> Date: Tue Jan 28 21:21:23 2025 +0100 docs: remove duplicated files and update integration docs (opendatahub-io#1575) Signed-off-by: Wen Zhou <[email protected]> commit ca2f619 Author: Wen Zhou <[email protected]> Date: Tue Jan 28 21:02:36 2025 +0100 fix: missing update permission on dashboard object (opendatahub-io#1576) - add update on all cases Signed-off-by: Wen Zhou <[email protected]> commit a996732 Author: Wen Zhou <[email protected]> Date: Tue Jan 28 20:50:56 2025 +0100 fix: fix wrong map for DSP images (opendatahub-io#1577) - the old images are from 2.15 which have been updated during 2.16 Signed-off-by: Wen Zhou <[email protected]> commit 94095f9 Author: Dipanshu Gupta <[email protected]> Date: Tue Jan 28 21:57:25 2025 +0530 Setup admin permissions for hardware profiles (opendatahub-io#1573) commit 3056ab4 Author: Ajay Jaganathan <[email protected]> Date: Tue Jan 28 17:58:06 2025 +0530 (fix): point to correct path for component integration doc (opendatahub-io#1574) commit d538956 Author: Luca Burgazzoli <[email protected]> Date: Tue Jan 28 10:01:48 2025 +0100 chore: use constants from the status package where possible (opendatahub-io#1541) Co-authored-by: Wen Zhou <[email protected]> commit 9aed5e0 Author: Andrew Ballantyne <[email protected]> Date: Mon Jan 27 13:20:04 2025 -0500 Clarify and update permissions (opendatahub-io#1538) * Add readme to explain values of permissions * NIM Accounts are namespaced resources * Update permissions to fulfill doc design * Based on feedback, less hard-fast ruling wording in the README commit 5e60591 Author: Wen Zhou <[email protected]> Date: Mon Jan 27 17:33:51 2025 +0100 test: disable monitoring config in DSCI for ODH e2e test (opendatahub-io#1570) - we do not enable monitoring in ODH logic - we should keep it enable for rhoai branch Signed-off-by: Wen Zhou <[email protected]> commit a8eb6ff Author: Ugo Giordano <[email protected]> Date: Mon Jan 27 16:51:31 2025 +0100 fix lint add updated api doc commit 4b76ca4 Author: Ugo Giordano <[email protected]> Date: Mon Jan 27 16:42:00 2025 +0100 Map component versions to RHOAI status for better visibility commit 48341ff Author: Luca Burgazzoli <[email protected]> Date: Mon Jan 27 15:38:21 2025 +0100 It takes more than 10 minutes for kserve-controller to be created during 2.17 installation (opendatahub-io#1564) * It takes more than 10 minutes for kserve-controller to be created during 2.17 installation * cleanup commit b0a0f87 Author: Wen Zhou <[email protected]> Date: Mon Jan 27 13:53:40 2025 +0100 update: clean up old code before refactor (opendatahub-io#1494) * update: clean up old code before refactor - remove reference we explicilty check on odhdashboardconfig and kserve - remove customized config on controller QPS - remove RemoveLabel which is not called anywhere Signed-off-by: Wen Zhou <[email protected]> * update: - remove function for upgrade cleanup introduced before 2.8 - remove flags to main: operator namespace and application namespace ( operator namespace is passing as env variable, app namespace is done by DSCI ) Signed-off-by: Wen Zhou <[email protected]> * fix: Auth CR is cluster-scoped no need to set namespace for request - application namespace is removed from reconciler of dsci Signed-off-by: Wen Zhou <[email protected]> * fix: wrong code for upgrade path + rebase error Signed-off-by: Wen Zhou <[email protected]> --------- Signed-off-by: Wen Zhou <[email protected]> commit 7b4dfc2 Author: Wen Zhou <[email protected]> Date: Mon Jan 27 12:01:07 2025 +0100 fix: for upgrade case we will need update permission on buildconfig to revmoew ownerref from dsc (opendatahub-io#1567) Signed-off-by: Wen Zhou <[email protected]> commit a00aa61 Author: Wen Zhou <[email protected]> Date: Mon Jan 27 09:00:32 2025 +0100 fix: add matchlabel on NWP for customized appliation (opendatahub-io#1566) - update README and troubleshooting Signed-off-by: Wen Zhou <[email protected]> commit eb42450 Author: Manjunath Kumatagi <[email protected]> Date: Fri Jan 24 19:11:14 2025 +0530 Build platform independent binary based on the target platform (opendatahub-io#1549) commit bc63cfd Author: Wen Zhou <[email protected]> Date: Thu Jan 23 21:04:44 2025 +0100 update: change previous workaround for subscription and add smcp in the list (opendatahub-io#1557) - remove subs from client cache - add smcp into exclude cache Signed-off-by: Wen Zhou <[email protected]> commit 63d4eab Author: Wen Zhou <[email protected]> Date: Thu Jan 23 18:44:37 2025 +0100 fix: missing monitoring NS for NWP if user opt customized app NS (opendatahub-io#1558) Signed-off-by: Wen Zhou <[email protected]> commit 912dcaa Author: Ugo Giordano <[email protected]> Date: Thu Jan 23 16:56:32 2025 +0100 Align get_all_manifests.sh with Kubeflow main branch (opendatahub-io#1550) commit ce7b381 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Thu Jan 23 14:08:54 2025 +0100 Update version to 2.23.1 (opendatahub-io#1553) Co-authored-by: zdtsw <[email protected]> commit 9845f7e Author: Wen Zhou <[email protected]> Date: Thu Jan 23 14:07:25 2025 +0100 update: various fix backport from RHOAI (opendatahub-io#1536) - fix missing RHOAI monitoring namespace for self-managed - fix wrong namespace name in manifests - update hardcode label name - fix misleading log message Signed-off-by: Wen Zhou <[email protected]> commit 871c799 Author: Wen Zhou <[email protected]> Date: Thu Jan 23 13:21:29 2025 +0100 fix: as a workaround for getting knative opreator check, set cache (opendatahub-io#1555) Signed-off-by: Wen Zhou <[email protected]> commit 28d0fa1 Author: Wen Zhou <[email protected]> Date: Thu Jan 23 11:49:37 2025 +0100 fix: add missing namespace for console in managed cluster (opendatahub-io#1552) - blackbox require this - move into const in cluster pkg Signed-off-by: Wen Zhou <[email protected]> commit 5bcbaba Author: Luca Burgazzoli <[email protected]> Date: Wed Jan 22 19:31:20 2025 +0100 Avoid modelmesh and Kserve loop on updating shared CRDs (opendatahub-io#1547) The KServe and ModelMesh are shipping the same CRDs as part of their manifests but with different versions, this cause the respective component reconcilers to keep trying to install their respective version, ending in a infinite loop. This commit does not solve the underlying problem of having two components shipping the same CRDs with different versions, but avoids the infinite reconcile loop. The CRDs that is actually installed on the cluster is undefined, the latest one that is applied wins commit 8c7fef2 Author: Luca Burgazzoli <[email protected]> Date: Wed Jan 22 15:45:51 2025 +0100 chore: remove unused code (opendatahub-io#1543) * chore: remove unused TrimToRFC1123Name function * chore: remove unused pkg/cluster/roles functions * chore: remove unused pkg/cluster/resources functions commit e83f2fc Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Wed Jan 22 13:49:00 2025 +0100 Update version to 2.23.0 (opendatahub-io#1544) Co-authored-by: zdtsw <[email protected]> commit 21eba1b Author: Luca Burgazzoli <[email protected]> Date: Wed Jan 22 12:38:49 2025 +0100 chore: cleanup Monitoring's initialize action (opendatahub-io#1542) The Monitoring controller is initialized only when the platform is managed, hence there's no need to conditionally add manifests commit 5321b8c Author: Luca Burgazzoli <[email protected]> Date: Wed Jan 22 11:05:23 2025 +0100 fix: use Monitoring.Spec.Namespace instead of the DSCI one (opendatahub-io#1540) This reduce the direct dependency from Monitoring to DSCI
commit 8caaedfbbc7da4890f41496275a71e4364730646 Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 16:09:34 2025 +0100 added generated files commit aedbf41 Merge: 9135927 6e134b1 Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 16:00:38 2025 +0100 Merge branch 'main' into RHOAIENG-11648/component-mapping-refactor commit 9135927 Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 15:28:08 2025 +0100 removed releases from dashboard since not needed and renamed ComponentReleaseStatus into ComponentRelease commit 237806d Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 12:56:50 2025 +0100 removed releases from dashboard since not needed commit 6e134b1 Author: Wen Zhou <[email protected]> Date: Wed Jan 29 12:41:18 2025 +0100 fix: missing permission to update prometheusrules (opendatahub-io#1581) Signed-off-by: Wen Zhou <[email protected]> commit a044cda Merge: 2571965 bd00c9b Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 12:13:12 2025 +0100 Merge branch 'main' into RHOAIENG-11648/component-mapping-refactor commit 2571965 Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 11:42:27 2025 +0100 Map component versions to RHOAI status for better visibility commit 0f1cf7dd9ca20e41c97a1590e18dc888b68e9fd5 Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 11:40:58 2025 +0100 fix lint error commit 473e86f55fd87e496c5d4251d075dc1082ce6e4c Author: Ugo Giordano <[email protected]> Date: Mon Jan 27 16:42:00 2025 +0100 Map component versions to RHOAI status for better visibility commit 3d47679 Merge: d706b92 bd00c9b Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 11:32:16 2025 +0100 Merge branch 'main' into RHOAIENG-11648/component-mapping-refactor commit d706b92 Author: Ugo Giordano <[email protected]> Date: Tue Jan 28 18:00:29 2025 +0100 Remove fetch releases action from dashboard & e2e tests commit 4e0deb2 Author: Ugo Giordano <[email protected]> Date: Tue Jan 28 16:10:28 2025 +0100 unit test e2e tests commit bd00c9b Author: Luca Burgazzoli <[email protected]> Date: Tue Jan 28 23:53:01 2025 +0100 Improve Kserve's FeatureTraker handing (opendatahub-io#1562) * Improve Kserve's FeatureTraker handing - Make it possible to set FT's OwnerReference as Controller reference so the kubernetes garbage collector can block owner deletion till the FT has been deleted - Make it possible to set FT's generated resources OwnerReference as Controller reference so the kubernetes garbage collector can block FT deletion till the resources have been deleted - Add an Kserver reconciler action to remove legacy ownership on DSCI/DSC is any and related e2e tests * Update RBACs * Update RBACs * Fix findings * Update pkg/cluster/meta.go Co-authored-by: Gerard Ryan <[email protected]> * Fix renaming * Remove unrelated methods --------- Co-authored-by: Gerard Ryan <[email protected]> commit df5495e Author: Wen Zhou <[email protected]> Date: Tue Jan 28 21:21:23 2025 +0100 docs: remove duplicated files and update integration docs (opendatahub-io#1575) Signed-off-by: Wen Zhou <[email protected]> commit ca2f619 Author: Wen Zhou <[email protected]> Date: Tue Jan 28 21:02:36 2025 +0100 fix: missing update permission on dashboard object (opendatahub-io#1576) - add update on all cases Signed-off-by: Wen Zhou <[email protected]> commit a996732 Author: Wen Zhou <[email protected]> Date: Tue Jan 28 20:50:56 2025 +0100 fix: fix wrong map for DSP images (opendatahub-io#1577) - the old images are from 2.15 which have been updated during 2.16 Signed-off-by: Wen Zhou <[email protected]> commit 94095f9 Author: Dipanshu Gupta <[email protected]> Date: Tue Jan 28 21:57:25 2025 +0530 Setup admin permissions for hardware profiles (opendatahub-io#1573) commit 3056ab4 Author: Ajay Jaganathan <[email protected]> Date: Tue Jan 28 17:58:06 2025 +0530 (fix): point to correct path for component integration doc (opendatahub-io#1574) commit d538956 Author: Luca Burgazzoli <[email protected]> Date: Tue Jan 28 10:01:48 2025 +0100 chore: use constants from the status package where possible (opendatahub-io#1541) Co-authored-by: Wen Zhou <[email protected]> commit 9aed5e0 Author: Andrew Ballantyne <[email protected]> Date: Mon Jan 27 13:20:04 2025 -0500 Clarify and update permissions (opendatahub-io#1538) * Add readme to explain values of permissions * NIM Accounts are namespaced resources * Update permissions to fulfill doc design * Based on feedback, less hard-fast ruling wording in the README commit 5e60591 Author: Wen Zhou <[email protected]> Date: Mon Jan 27 17:33:51 2025 +0100 test: disable monitoring config in DSCI for ODH e2e test (opendatahub-io#1570) - we do not enable monitoring in ODH logic - we should keep it enable for rhoai branch Signed-off-by: Wen Zhou <[email protected]> commit a8eb6ff Author: Ugo Giordano <[email protected]> Date: Mon Jan 27 16:51:31 2025 +0100 fix lint add updated api doc commit 4b76ca4 Author: Ugo Giordano <[email protected]> Date: Mon Jan 27 16:42:00 2025 +0100 Map component versions to RHOAI status for better visibility commit 48341ff Author: Luca Burgazzoli <[email protected]> Date: Mon Jan 27 15:38:21 2025 +0100 It takes more than 10 minutes for kserve-controller to be created during 2.17 installation (opendatahub-io#1564) * It takes more than 10 minutes for kserve-controller to be created during 2.17 installation * cleanup commit b0a0f87 Author: Wen Zhou <[email protected]> Date: Mon Jan 27 13:53:40 2025 +0100 update: clean up old code before refactor (opendatahub-io#1494) * update: clean up old code before refactor - remove reference we explicilty check on odhdashboardconfig and kserve - remove customized config on controller QPS - remove RemoveLabel which is not called anywhere Signed-off-by: Wen Zhou <[email protected]> * update: - remove function for upgrade cleanup introduced before 2.8 - remove flags to main: operator namespace and application namespace ( operator namespace is passing as env variable, app namespace is done by DSCI ) Signed-off-by: Wen Zhou <[email protected]> * fix: Auth CR is cluster-scoped no need to set namespace for request - application namespace is removed from reconciler of dsci Signed-off-by: Wen Zhou <[email protected]> * fix: wrong code for upgrade path + rebase error Signed-off-by: Wen Zhou <[email protected]> --------- Signed-off-by: Wen Zhou <[email protected]> commit 7b4dfc2 Author: Wen Zhou <[email protected]> Date: Mon Jan 27 12:01:07 2025 +0100 fix: for upgrade case we will need update permission on buildconfig to revmoew ownerref from dsc (opendatahub-io#1567) Signed-off-by: Wen Zhou <[email protected]> commit a00aa61 Author: Wen Zhou <[email protected]> Date: Mon Jan 27 09:00:32 2025 +0100 fix: add matchlabel on NWP for customized appliation (opendatahub-io#1566) - update README and troubleshooting Signed-off-by: Wen Zhou <[email protected]> commit eb42450 Author: Manjunath Kumatagi <[email protected]> Date: Fri Jan 24 19:11:14 2025 +0530 Build platform independent binary based on the target platform (opendatahub-io#1549) commit bc63cfd Author: Wen Zhou <[email protected]> Date: Thu Jan 23 21:04:44 2025 +0100 update: change previous workaround for subscription and add smcp in the list (opendatahub-io#1557) - remove subs from client cache - add smcp into exclude cache Signed-off-by: Wen Zhou <[email protected]> commit 63d4eab Author: Wen Zhou <[email protected]> Date: Thu Jan 23 18:44:37 2025 +0100 fix: missing monitoring NS for NWP if user opt customized app NS (opendatahub-io#1558) Signed-off-by: Wen Zhou <[email protected]> commit 912dcaa Author: Ugo Giordano <[email protected]> Date: Thu Jan 23 16:56:32 2025 +0100 Align get_all_manifests.sh with Kubeflow main branch (opendatahub-io#1550) commit ce7b381 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Thu Jan 23 14:08:54 2025 +0100 Update version to 2.23.1 (opendatahub-io#1553) Co-authored-by: zdtsw <[email protected]> commit 9845f7e Author: Wen Zhou <[email protected]> Date: Thu Jan 23 14:07:25 2025 +0100 update: various fix backport from RHOAI (opendatahub-io#1536) - fix missing RHOAI monitoring namespace for self-managed - fix wrong namespace name in manifests - update hardcode label name - fix misleading log message Signed-off-by: Wen Zhou <[email protected]> commit 871c799 Author: Wen Zhou <[email protected]> Date: Thu Jan 23 13:21:29 2025 +0100 fix: as a workaround for getting knative opreator check, set cache (opendatahub-io#1555) Signed-off-by: Wen Zhou <[email protected]> commit 28d0fa1 Author: Wen Zhou <[email protected]> Date: Thu Jan 23 11:49:37 2025 +0100 fix: add missing namespace for console in managed cluster (opendatahub-io#1552) - blackbox require this - move into const in cluster pkg Signed-off-by: Wen Zhou <[email protected]> commit 5bcbaba Author: Luca Burgazzoli <[email protected]> Date: Wed Jan 22 19:31:20 2025 +0100 Avoid modelmesh and Kserve loop on updating shared CRDs (opendatahub-io#1547) The KServe and ModelMesh are shipping the same CRDs as part of their manifests but with different versions, this cause the respective component reconcilers to keep trying to install their respective version, ending in a infinite loop. This commit does not solve the underlying problem of having two components shipping the same CRDs with different versions, but avoids the infinite reconcile loop. The CRDs that is actually installed on the cluster is undefined, the latest one that is applied wins commit 8c7fef2 Author: Luca Burgazzoli <[email protected]> Date: Wed Jan 22 15:45:51 2025 +0100 chore: remove unused code (opendatahub-io#1543) * chore: remove unused TrimToRFC1123Name function * chore: remove unused pkg/cluster/roles functions * chore: remove unused pkg/cluster/resources functions commit e83f2fc Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Wed Jan 22 13:49:00 2025 +0100 Update version to 2.23.0 (opendatahub-io#1544) Co-authored-by: zdtsw <[email protected]> commit 21eba1b Author: Luca Burgazzoli <[email protected]> Date: Wed Jan 22 12:38:49 2025 +0100 chore: cleanup Monitoring's initialize action (opendatahub-io#1542) The Monitoring controller is initialized only when the platform is managed, hence there's no need to conditionally add manifests commit 5321b8c Author: Luca Burgazzoli <[email protected]> Date: Wed Jan 22 11:05:23 2025 +0100 fix: use Monitoring.Spec.Namespace instead of the DSCI one (opendatahub-io#1540) This reduce the direct dependency from Monitoring to DSCI
commit 8caaedfbbc7da4890f41496275a71e4364730646 Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 16:09:34 2025 +0100 added generated files commit aedbf41 Merge: 9135927 6e134b1 Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 16:00:38 2025 +0100 Merge branch 'main' into RHOAIENG-11648/component-mapping-refactor commit 9135927 Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 15:28:08 2025 +0100 removed releases from dashboard since not needed and renamed ComponentReleaseStatus into ComponentRelease commit 237806d Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 12:56:50 2025 +0100 removed releases from dashboard since not needed commit 6e134b1 Author: Wen Zhou <[email protected]> Date: Wed Jan 29 12:41:18 2025 +0100 fix: missing permission to update prometheusrules (opendatahub-io#1581) Signed-off-by: Wen Zhou <[email protected]> commit a044cda Merge: 2571965 bd00c9b Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 12:13:12 2025 +0100 Merge branch 'main' into RHOAIENG-11648/component-mapping-refactor commit 2571965 Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 11:42:27 2025 +0100 Map component versions to RHOAI status for better visibility commit 0f1cf7dd9ca20e41c97a1590e18dc888b68e9fd5 Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 11:40:58 2025 +0100 fix lint error commit 473e86f55fd87e496c5d4251d075dc1082ce6e4c Author: Ugo Giordano <[email protected]> Date: Mon Jan 27 16:42:00 2025 +0100 Map component versions to RHOAI status for better visibility commit 3d47679 Merge: d706b92 bd00c9b Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 11:32:16 2025 +0100 Merge branch 'main' into RHOAIENG-11648/component-mapping-refactor commit d706b92 Author: Ugo Giordano <[email protected]> Date: Tue Jan 28 18:00:29 2025 +0100 Remove fetch releases action from dashboard & e2e tests commit 4e0deb2 Author: Ugo Giordano <[email protected]> Date: Tue Jan 28 16:10:28 2025 +0100 unit test e2e tests commit bd00c9b Author: Luca Burgazzoli <[email protected]> Date: Tue Jan 28 23:53:01 2025 +0100 Improve Kserve's FeatureTraker handing (opendatahub-io#1562) * Improve Kserve's FeatureTraker handing - Make it possible to set FT's OwnerReference as Controller reference so the kubernetes garbage collector can block owner deletion till the FT has been deleted - Make it possible to set FT's generated resources OwnerReference as Controller reference so the kubernetes garbage collector can block FT deletion till the resources have been deleted - Add an Kserver reconciler action to remove legacy ownership on DSCI/DSC is any and related e2e tests * Update RBACs * Update RBACs * Fix findings * Update pkg/cluster/meta.go Co-authored-by: Gerard Ryan <[email protected]> * Fix renaming * Remove unrelated methods --------- Co-authored-by: Gerard Ryan <[email protected]> commit df5495e Author: Wen Zhou <[email protected]> Date: Tue Jan 28 21:21:23 2025 +0100 docs: remove duplicated files and update integration docs (opendatahub-io#1575) Signed-off-by: Wen Zhou <[email protected]> commit ca2f619 Author: Wen Zhou <[email protected]> Date: Tue Jan 28 21:02:36 2025 +0100 fix: missing update permission on dashboard object (opendatahub-io#1576) - add update on all cases Signed-off-by: Wen Zhou <[email protected]> commit a996732 Author: Wen Zhou <[email protected]> Date: Tue Jan 28 20:50:56 2025 +0100 fix: fix wrong map for DSP images (opendatahub-io#1577) - the old images are from 2.15 which have been updated during 2.16 Signed-off-by: Wen Zhou <[email protected]> commit 94095f9 Author: Dipanshu Gupta <[email protected]> Date: Tue Jan 28 21:57:25 2025 +0530 Setup admin permissions for hardware profiles (opendatahub-io#1573) commit 3056ab4 Author: Ajay Jaganathan <[email protected]> Date: Tue Jan 28 17:58:06 2025 +0530 (fix): point to correct path for component integration doc (opendatahub-io#1574) commit d538956 Author: Luca Burgazzoli <[email protected]> Date: Tue Jan 28 10:01:48 2025 +0100 chore: use constants from the status package where possible (opendatahub-io#1541) Co-authored-by: Wen Zhou <[email protected]> commit 9aed5e0 Author: Andrew Ballantyne <[email protected]> Date: Mon Jan 27 13:20:04 2025 -0500 Clarify and update permissions (opendatahub-io#1538) * Add readme to explain values of permissions * NIM Accounts are namespaced resources * Update permissions to fulfill doc design * Based on feedback, less hard-fast ruling wording in the README commit 5e60591 Author: Wen Zhou <[email protected]> Date: Mon Jan 27 17:33:51 2025 +0100 test: disable monitoring config in DSCI for ODH e2e test (opendatahub-io#1570) - we do not enable monitoring in ODH logic - we should keep it enable for rhoai branch Signed-off-by: Wen Zhou <[email protected]> commit a8eb6ff Author: Ugo Giordano <[email protected]> Date: Mon Jan 27 16:51:31 2025 +0100 fix lint add updated api doc commit 4b76ca4 Author: Ugo Giordano <[email protected]> Date: Mon Jan 27 16:42:00 2025 +0100 Map component versions to RHOAI status for better visibility commit 48341ff Author: Luca Burgazzoli <[email protected]> Date: Mon Jan 27 15:38:21 2025 +0100 It takes more than 10 minutes for kserve-controller to be created during 2.17 installation (opendatahub-io#1564) * It takes more than 10 minutes for kserve-controller to be created during 2.17 installation * cleanup commit b0a0f87 Author: Wen Zhou <[email protected]> Date: Mon Jan 27 13:53:40 2025 +0100 update: clean up old code before refactor (opendatahub-io#1494) * update: clean up old code before refactor - remove reference we explicilty check on odhdashboardconfig and kserve - remove customized config on controller QPS - remove RemoveLabel which is not called anywhere Signed-off-by: Wen Zhou <[email protected]> * update: - remove function for upgrade cleanup introduced before 2.8 - remove flags to main: operator namespace and application namespace ( operator namespace is passing as env variable, app namespace is done by DSCI ) Signed-off-by: Wen Zhou <[email protected]> * fix: Auth CR is cluster-scoped no need to set namespace for request - application namespace is removed from reconciler of dsci Signed-off-by: Wen Zhou <[email protected]> * fix: wrong code for upgrade path + rebase error Signed-off-by: Wen Zhou <[email protected]> --------- Signed-off-by: Wen Zhou <[email protected]> commit 7b4dfc2 Author: Wen Zhou <[email protected]> Date: Mon Jan 27 12:01:07 2025 +0100 fix: for upgrade case we will need update permission on buildconfig to revmoew ownerref from dsc (opendatahub-io#1567) Signed-off-by: Wen Zhou <[email protected]> commit a00aa61 Author: Wen Zhou <[email protected]> Date: Mon Jan 27 09:00:32 2025 +0100 fix: add matchlabel on NWP for customized appliation (opendatahub-io#1566) - update README and troubleshooting Signed-off-by: Wen Zhou <[email protected]> commit eb42450 Author: Manjunath Kumatagi <[email protected]> Date: Fri Jan 24 19:11:14 2025 +0530 Build platform independent binary based on the target platform (opendatahub-io#1549) commit bc63cfd Author: Wen Zhou <[email protected]> Date: Thu Jan 23 21:04:44 2025 +0100 update: change previous workaround for subscription and add smcp in the list (opendatahub-io#1557) - remove subs from client cache - add smcp into exclude cache Signed-off-by: Wen Zhou <[email protected]> commit 63d4eab Author: Wen Zhou <[email protected]> Date: Thu Jan 23 18:44:37 2025 +0100 fix: missing monitoring NS for NWP if user opt customized app NS (opendatahub-io#1558) Signed-off-by: Wen Zhou <[email protected]> commit 912dcaa Author: Ugo Giordano <[email protected]> Date: Thu Jan 23 16:56:32 2025 +0100 Align get_all_manifests.sh with Kubeflow main branch (opendatahub-io#1550) commit ce7b381 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Thu Jan 23 14:08:54 2025 +0100 Update version to 2.23.1 (opendatahub-io#1553) Co-authored-by: zdtsw <[email protected]> commit 9845f7e Author: Wen Zhou <[email protected]> Date: Thu Jan 23 14:07:25 2025 +0100 update: various fix backport from RHOAI (opendatahub-io#1536) - fix missing RHOAI monitoring namespace for self-managed - fix wrong namespace name in manifests - update hardcode label name - fix misleading log message Signed-off-by: Wen Zhou <[email protected]> commit 871c799 Author: Wen Zhou <[email protected]> Date: Thu Jan 23 13:21:29 2025 +0100 fix: as a workaround for getting knative opreator check, set cache (opendatahub-io#1555) Signed-off-by: Wen Zhou <[email protected]> commit 28d0fa1 Author: Wen Zhou <[email protected]> Date: Thu Jan 23 11:49:37 2025 +0100 fix: add missing namespace for console in managed cluster (opendatahub-io#1552) - blackbox require this - move into const in cluster pkg Signed-off-by: Wen Zhou <[email protected]> commit 5bcbaba Author: Luca Burgazzoli <[email protected]> Date: Wed Jan 22 19:31:20 2025 +0100 Avoid modelmesh and Kserve loop on updating shared CRDs (opendatahub-io#1547) The KServe and ModelMesh are shipping the same CRDs as part of their manifests but with different versions, this cause the respective component reconcilers to keep trying to install their respective version, ending in a infinite loop. This commit does not solve the underlying problem of having two components shipping the same CRDs with different versions, but avoids the infinite reconcile loop. The CRDs that is actually installed on the cluster is undefined, the latest one that is applied wins commit 8c7fef2 Author: Luca Burgazzoli <[email protected]> Date: Wed Jan 22 15:45:51 2025 +0100 chore: remove unused code (opendatahub-io#1543) * chore: remove unused TrimToRFC1123Name function * chore: remove unused pkg/cluster/roles functions * chore: remove unused pkg/cluster/resources functions commit e83f2fc Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Wed Jan 22 13:49:00 2025 +0100 Update version to 2.23.0 (opendatahub-io#1544) Co-authored-by: zdtsw <[email protected]> commit 21eba1b Author: Luca Burgazzoli <[email protected]> Date: Wed Jan 22 12:38:49 2025 +0100 chore: cleanup Monitoring's initialize action (opendatahub-io#1542) The Monitoring controller is initialized only when the platform is managed, hence there's no need to conditionally add manifests commit 5321b8c Author: Luca Burgazzoli <[email protected]> Date: Wed Jan 22 11:05:23 2025 +0100 fix: use Monitoring.Spec.Namespace instead of the DSCI one (opendatahub-io#1540) This reduce the direct dependency from Monitoring to DSCI
commit 8caaedfbbc7da4890f41496275a71e4364730646 Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 16:09:34 2025 +0100 added generated files commit aedbf41 Merge: 9135927 6e134b1 Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 16:00:38 2025 +0100 Merge branch 'main' into RHOAIENG-11648/component-mapping-refactor commit 9135927 Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 15:28:08 2025 +0100 removed releases from dashboard since not needed and renamed ComponentReleaseStatus into ComponentRelease commit 237806d Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 12:56:50 2025 +0100 removed releases from dashboard since not needed commit 6e134b1 Author: Wen Zhou <[email protected]> Date: Wed Jan 29 12:41:18 2025 +0100 fix: missing permission to update prometheusrules (opendatahub-io#1581) Signed-off-by: Wen Zhou <[email protected]> commit a044cda Merge: 2571965 bd00c9b Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 12:13:12 2025 +0100 Merge branch 'main' into RHOAIENG-11648/component-mapping-refactor commit 2571965 Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 11:42:27 2025 +0100 Map component versions to RHOAI status for better visibility commit 0f1cf7dd9ca20e41c97a1590e18dc888b68e9fd5 Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 11:40:58 2025 +0100 fix lint error commit 473e86f55fd87e496c5d4251d075dc1082ce6e4c Author: Ugo Giordano <[email protected]> Date: Mon Jan 27 16:42:00 2025 +0100 Map component versions to RHOAI status for better visibility commit 3d47679 Merge: d706b92 bd00c9b Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 11:32:16 2025 +0100 Merge branch 'main' into RHOAIENG-11648/component-mapping-refactor commit d706b92 Author: Ugo Giordano <[email protected]> Date: Tue Jan 28 18:00:29 2025 +0100 Remove fetch releases action from dashboard & e2e tests commit 4e0deb2 Author: Ugo Giordano <[email protected]> Date: Tue Jan 28 16:10:28 2025 +0100 unit test e2e tests commit bd00c9b Author: Luca Burgazzoli <[email protected]> Date: Tue Jan 28 23:53:01 2025 +0100 Improve Kserve's FeatureTraker handing (opendatahub-io#1562) * Improve Kserve's FeatureTraker handing - Make it possible to set FT's OwnerReference as Controller reference so the kubernetes garbage collector can block owner deletion till the FT has been deleted - Make it possible to set FT's generated resources OwnerReference as Controller reference so the kubernetes garbage collector can block FT deletion till the resources have been deleted - Add an Kserver reconciler action to remove legacy ownership on DSCI/DSC is any and related e2e tests * Update RBACs * Update RBACs * Fix findings * Update pkg/cluster/meta.go Co-authored-by: Gerard Ryan <[email protected]> * Fix renaming * Remove unrelated methods --------- Co-authored-by: Gerard Ryan <[email protected]> commit df5495e Author: Wen Zhou <[email protected]> Date: Tue Jan 28 21:21:23 2025 +0100 docs: remove duplicated files and update integration docs (opendatahub-io#1575) Signed-off-by: Wen Zhou <[email protected]> commit ca2f619 Author: Wen Zhou <[email protected]> Date: Tue Jan 28 21:02:36 2025 +0100 fix: missing update permission on dashboard object (opendatahub-io#1576) - add update on all cases Signed-off-by: Wen Zhou <[email protected]> commit a996732 Author: Wen Zhou <[email protected]> Date: Tue Jan 28 20:50:56 2025 +0100 fix: fix wrong map for DSP images (opendatahub-io#1577) - the old images are from 2.15 which have been updated during 2.16 Signed-off-by: Wen Zhou <[email protected]> commit 94095f9 Author: Dipanshu Gupta <[email protected]> Date: Tue Jan 28 21:57:25 2025 +0530 Setup admin permissions for hardware profiles (opendatahub-io#1573) commit 3056ab4 Author: Ajay Jaganathan <[email protected]> Date: Tue Jan 28 17:58:06 2025 +0530 (fix): point to correct path for component integration doc (opendatahub-io#1574) commit d538956 Author: Luca Burgazzoli <[email protected]> Date: Tue Jan 28 10:01:48 2025 +0100 chore: use constants from the status package where possible (opendatahub-io#1541) Co-authored-by: Wen Zhou <[email protected]> commit 9aed5e0 Author: Andrew Ballantyne <[email protected]> Date: Mon Jan 27 13:20:04 2025 -0500 Clarify and update permissions (opendatahub-io#1538) * Add readme to explain values of permissions * NIM Accounts are namespaced resources * Update permissions to fulfill doc design * Based on feedback, less hard-fast ruling wording in the README commit 5e60591 Author: Wen Zhou <[email protected]> Date: Mon Jan 27 17:33:51 2025 +0100 test: disable monitoring config in DSCI for ODH e2e test (opendatahub-io#1570) - we do not enable monitoring in ODH logic - we should keep it enable for rhoai branch Signed-off-by: Wen Zhou <[email protected]> commit a8eb6ff Author: Ugo Giordano <[email protected]> Date: Mon Jan 27 16:51:31 2025 +0100 fix lint add updated api doc commit 4b76ca4 Author: Ugo Giordano <[email protected]> Date: Mon Jan 27 16:42:00 2025 +0100 Map component versions to RHOAI status for better visibility commit 48341ff Author: Luca Burgazzoli <[email protected]> Date: Mon Jan 27 15:38:21 2025 +0100 It takes more than 10 minutes for kserve-controller to be created during 2.17 installation (opendatahub-io#1564) * It takes more than 10 minutes for kserve-controller to be created during 2.17 installation * cleanup commit b0a0f87 Author: Wen Zhou <[email protected]> Date: Mon Jan 27 13:53:40 2025 +0100 update: clean up old code before refactor (opendatahub-io#1494) * update: clean up old code before refactor - remove reference we explicilty check on odhdashboardconfig and kserve - remove customized config on controller QPS - remove RemoveLabel which is not called anywhere Signed-off-by: Wen Zhou <[email protected]> * update: - remove function for upgrade cleanup introduced before 2.8 - remove flags to main: operator namespace and application namespace ( operator namespace is passing as env variable, app namespace is done by DSCI ) Signed-off-by: Wen Zhou <[email protected]> * fix: Auth CR is cluster-scoped no need to set namespace for request - application namespace is removed from reconciler of dsci Signed-off-by: Wen Zhou <[email protected]> * fix: wrong code for upgrade path + rebase error Signed-off-by: Wen Zhou <[email protected]> --------- Signed-off-by: Wen Zhou <[email protected]> commit 7b4dfc2 Author: Wen Zhou <[email protected]> Date: Mon Jan 27 12:01:07 2025 +0100 fix: for upgrade case we will need update permission on buildconfig to revmoew ownerref from dsc (opendatahub-io#1567) Signed-off-by: Wen Zhou <[email protected]> commit a00aa61 Author: Wen Zhou <[email protected]> Date: Mon Jan 27 09:00:32 2025 +0100 fix: add matchlabel on NWP for customized appliation (opendatahub-io#1566) - update README and troubleshooting Signed-off-by: Wen Zhou <[email protected]> commit eb42450 Author: Manjunath Kumatagi <[email protected]> Date: Fri Jan 24 19:11:14 2025 +0530 Build platform independent binary based on the target platform (opendatahub-io#1549) commit bc63cfd Author: Wen Zhou <[email protected]> Date: Thu Jan 23 21:04:44 2025 +0100 update: change previous workaround for subscription and add smcp in the list (opendatahub-io#1557) - remove subs from client cache - add smcp into exclude cache Signed-off-by: Wen Zhou <[email protected]> commit 63d4eab Author: Wen Zhou <[email protected]> Date: Thu Jan 23 18:44:37 2025 +0100 fix: missing monitoring NS for NWP if user opt customized app NS (opendatahub-io#1558) Signed-off-by: Wen Zhou <[email protected]> commit 912dcaa Author: Ugo Giordano <[email protected]> Date: Thu Jan 23 16:56:32 2025 +0100 Align get_all_manifests.sh with Kubeflow main branch (opendatahub-io#1550) commit ce7b381 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Thu Jan 23 14:08:54 2025 +0100 Update version to 2.23.1 (opendatahub-io#1553) Co-authored-by: zdtsw <[email protected]> commit 9845f7e Author: Wen Zhou <[email protected]> Date: Thu Jan 23 14:07:25 2025 +0100 update: various fix backport from RHOAI (opendatahub-io#1536) - fix missing RHOAI monitoring namespace for self-managed - fix wrong namespace name in manifests - update hardcode label name - fix misleading log message Signed-off-by: Wen Zhou <[email protected]> commit 871c799 Author: Wen Zhou <[email protected]> Date: Thu Jan 23 13:21:29 2025 +0100 fix: as a workaround for getting knative opreator check, set cache (opendatahub-io#1555) Signed-off-by: Wen Zhou <[email protected]> commit 28d0fa1 Author: Wen Zhou <[email protected]> Date: Thu Jan 23 11:49:37 2025 +0100 fix: add missing namespace for console in managed cluster (opendatahub-io#1552) - blackbox require this - move into const in cluster pkg Signed-off-by: Wen Zhou <[email protected]> commit 5bcbaba Author: Luca Burgazzoli <[email protected]> Date: Wed Jan 22 19:31:20 2025 +0100 Avoid modelmesh and Kserve loop on updating shared CRDs (opendatahub-io#1547) The KServe and ModelMesh are shipping the same CRDs as part of their manifests but with different versions, this cause the respective component reconcilers to keep trying to install their respective version, ending in a infinite loop. This commit does not solve the underlying problem of having two components shipping the same CRDs with different versions, but avoids the infinite reconcile loop. The CRDs that is actually installed on the cluster is undefined, the latest one that is applied wins commit 8c7fef2 Author: Luca Burgazzoli <[email protected]> Date: Wed Jan 22 15:45:51 2025 +0100 chore: remove unused code (opendatahub-io#1543) * chore: remove unused TrimToRFC1123Name function * chore: remove unused pkg/cluster/roles functions * chore: remove unused pkg/cluster/resources functions commit e83f2fc Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Wed Jan 22 13:49:00 2025 +0100 Update version to 2.23.0 (opendatahub-io#1544) Co-authored-by: zdtsw <[email protected]> commit 21eba1b Author: Luca Burgazzoli <[email protected]> Date: Wed Jan 22 12:38:49 2025 +0100 chore: cleanup Monitoring's initialize action (opendatahub-io#1542) The Monitoring controller is initialized only when the platform is managed, hence there's no need to conditionally add manifests commit 5321b8c Author: Luca Burgazzoli <[email protected]> Date: Wed Jan 22 11:05:23 2025 +0100 fix: use Monitoring.Spec.Namespace instead of the DSCI one (opendatahub-io#1540) This reduce the direct dependency from Monitoring to DSCI
commit 8caaedfbbc7da4890f41496275a71e4364730646 Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 16:09:34 2025 +0100 added generated files commit aedbf41 Merge: 9135927 6e134b1 Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 16:00:38 2025 +0100 Merge branch 'main' into RHOAIENG-11648/component-mapping-refactor commit 9135927 Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 15:28:08 2025 +0100 removed releases from dashboard since not needed and renamed ComponentReleaseStatus into ComponentRelease commit 237806d Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 12:56:50 2025 +0100 removed releases from dashboard since not needed commit 6e134b1 Author: Wen Zhou <[email protected]> Date: Wed Jan 29 12:41:18 2025 +0100 fix: missing permission to update prometheusrules (opendatahub-io#1581) Signed-off-by: Wen Zhou <[email protected]> commit a044cda Merge: 2571965 bd00c9b Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 12:13:12 2025 +0100 Merge branch 'main' into RHOAIENG-11648/component-mapping-refactor commit 2571965 Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 11:42:27 2025 +0100 Map component versions to RHOAI status for better visibility commit 0f1cf7dd9ca20e41c97a1590e18dc888b68e9fd5 Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 11:40:58 2025 +0100 fix lint error commit 473e86f55fd87e496c5d4251d075dc1082ce6e4c Author: Ugo Giordano <[email protected]> Date: Mon Jan 27 16:42:00 2025 +0100 Map component versions to RHOAI status for better visibility commit 3d47679 Merge: d706b92 bd00c9b Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 11:32:16 2025 +0100 Merge branch 'main' into RHOAIENG-11648/component-mapping-refactor commit d706b92 Author: Ugo Giordano <[email protected]> Date: Tue Jan 28 18:00:29 2025 +0100 Remove fetch releases action from dashboard & e2e tests commit 4e0deb2 Author: Ugo Giordano <[email protected]> Date: Tue Jan 28 16:10:28 2025 +0100 unit test e2e tests commit bd00c9b Author: Luca Burgazzoli <[email protected]> Date: Tue Jan 28 23:53:01 2025 +0100 Improve Kserve's FeatureTraker handing (opendatahub-io#1562) * Improve Kserve's FeatureTraker handing - Make it possible to set FT's OwnerReference as Controller reference so the kubernetes garbage collector can block owner deletion till the FT has been deleted - Make it possible to set FT's generated resources OwnerReference as Controller reference so the kubernetes garbage collector can block FT deletion till the resources have been deleted - Add an Kserver reconciler action to remove legacy ownership on DSCI/DSC is any and related e2e tests * Update RBACs * Update RBACs * Fix findings * Update pkg/cluster/meta.go Co-authored-by: Gerard Ryan <[email protected]> * Fix renaming * Remove unrelated methods --------- Co-authored-by: Gerard Ryan <[email protected]> commit df5495e Author: Wen Zhou <[email protected]> Date: Tue Jan 28 21:21:23 2025 +0100 docs: remove duplicated files and update integration docs (opendatahub-io#1575) Signed-off-by: Wen Zhou <[email protected]> commit ca2f619 Author: Wen Zhou <[email protected]> Date: Tue Jan 28 21:02:36 2025 +0100 fix: missing update permission on dashboard object (opendatahub-io#1576) - add update on all cases Signed-off-by: Wen Zhou <[email protected]> commit a996732 Author: Wen Zhou <[email protected]> Date: Tue Jan 28 20:50:56 2025 +0100 fix: fix wrong map for DSP images (opendatahub-io#1577) - the old images are from 2.15 which have been updated during 2.16 Signed-off-by: Wen Zhou <[email protected]> commit 94095f9 Author: Dipanshu Gupta <[email protected]> Date: Tue Jan 28 21:57:25 2025 +0530 Setup admin permissions for hardware profiles (opendatahub-io#1573) commit 3056ab4 Author: Ajay Jaganathan <[email protected]> Date: Tue Jan 28 17:58:06 2025 +0530 (fix): point to correct path for component integration doc (opendatahub-io#1574) commit d538956 Author: Luca Burgazzoli <[email protected]> Date: Tue Jan 28 10:01:48 2025 +0100 chore: use constants from the status package where possible (opendatahub-io#1541) Co-authored-by: Wen Zhou <[email protected]> commit 9aed5e0 Author: Andrew Ballantyne <[email protected]> Date: Mon Jan 27 13:20:04 2025 -0500 Clarify and update permissions (opendatahub-io#1538) * Add readme to explain values of permissions * NIM Accounts are namespaced resources * Update permissions to fulfill doc design * Based on feedback, less hard-fast ruling wording in the README commit 5e60591 Author: Wen Zhou <[email protected]> Date: Mon Jan 27 17:33:51 2025 +0100 test: disable monitoring config in DSCI for ODH e2e test (opendatahub-io#1570) - we do not enable monitoring in ODH logic - we should keep it enable for rhoai branch Signed-off-by: Wen Zhou <[email protected]> commit a8eb6ff Author: Ugo Giordano <[email protected]> Date: Mon Jan 27 16:51:31 2025 +0100 fix lint add updated api doc commit 4b76ca4 Author: Ugo Giordano <[email protected]> Date: Mon Jan 27 16:42:00 2025 +0100 Map component versions to RHOAI status for better visibility commit 48341ff Author: Luca Burgazzoli <[email protected]> Date: Mon Jan 27 15:38:21 2025 +0100 It takes more than 10 minutes for kserve-controller to be created during 2.17 installation (opendatahub-io#1564) * It takes more than 10 minutes for kserve-controller to be created during 2.17 installation * cleanup commit b0a0f87 Author: Wen Zhou <[email protected]> Date: Mon Jan 27 13:53:40 2025 +0100 update: clean up old code before refactor (opendatahub-io#1494) * update: clean up old code before refactor - remove reference we explicilty check on odhdashboardconfig and kserve - remove customized config on controller QPS - remove RemoveLabel which is not called anywhere Signed-off-by: Wen Zhou <[email protected]> * update: - remove function for upgrade cleanup introduced before 2.8 - remove flags to main: operator namespace and application namespace ( operator namespace is passing as env variable, app namespace is done by DSCI ) Signed-off-by: Wen Zhou <[email protected]> * fix: Auth CR is cluster-scoped no need to set namespace for request - application namespace is removed from reconciler of dsci Signed-off-by: Wen Zhou <[email protected]> * fix: wrong code for upgrade path + rebase error Signed-off-by: Wen Zhou <[email protected]> --------- Signed-off-by: Wen Zhou <[email protected]> commit 7b4dfc2 Author: Wen Zhou <[email protected]> Date: Mon Jan 27 12:01:07 2025 +0100 fix: for upgrade case we will need update permission on buildconfig to revmoew ownerref from dsc (opendatahub-io#1567) Signed-off-by: Wen Zhou <[email protected]> commit a00aa61 Author: Wen Zhou <[email protected]> Date: Mon Jan 27 09:00:32 2025 +0100 fix: add matchlabel on NWP for customized appliation (opendatahub-io#1566) - update README and troubleshooting Signed-off-by: Wen Zhou <[email protected]> commit eb42450 Author: Manjunath Kumatagi <[email protected]> Date: Fri Jan 24 19:11:14 2025 +0530 Build platform independent binary based on the target platform (opendatahub-io#1549) commit bc63cfd Author: Wen Zhou <[email protected]> Date: Thu Jan 23 21:04:44 2025 +0100 update: change previous workaround for subscription and add smcp in the list (opendatahub-io#1557) - remove subs from client cache - add smcp into exclude cache Signed-off-by: Wen Zhou <[email protected]> commit 63d4eab Author: Wen Zhou <[email protected]> Date: Thu Jan 23 18:44:37 2025 +0100 fix: missing monitoring NS for NWP if user opt customized app NS (opendatahub-io#1558) Signed-off-by: Wen Zhou <[email protected]> commit 912dcaa Author: Ugo Giordano <[email protected]> Date: Thu Jan 23 16:56:32 2025 +0100 Align get_all_manifests.sh with Kubeflow main branch (opendatahub-io#1550) commit ce7b381 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Thu Jan 23 14:08:54 2025 +0100 Update version to 2.23.1 (opendatahub-io#1553) Co-authored-by: zdtsw <[email protected]> commit 9845f7e Author: Wen Zhou <[email protected]> Date: Thu Jan 23 14:07:25 2025 +0100 update: various fix backport from RHOAI (opendatahub-io#1536) - fix missing RHOAI monitoring namespace for self-managed - fix wrong namespace name in manifests - update hardcode label name - fix misleading log message Signed-off-by: Wen Zhou <[email protected]> commit 871c799 Author: Wen Zhou <[email protected]> Date: Thu Jan 23 13:21:29 2025 +0100 fix: as a workaround for getting knative opreator check, set cache (opendatahub-io#1555) Signed-off-by: Wen Zhou <[email protected]> commit 28d0fa1 Author: Wen Zhou <[email protected]> Date: Thu Jan 23 11:49:37 2025 +0100 fix: add missing namespace for console in managed cluster (opendatahub-io#1552) - blackbox require this - move into const in cluster pkg Signed-off-by: Wen Zhou <[email protected]> commit 5bcbaba Author: Luca Burgazzoli <[email protected]> Date: Wed Jan 22 19:31:20 2025 +0100 Avoid modelmesh and Kserve loop on updating shared CRDs (opendatahub-io#1547) The KServe and ModelMesh are shipping the same CRDs as part of their manifests but with different versions, this cause the respective component reconcilers to keep trying to install their respective version, ending in a infinite loop. This commit does not solve the underlying problem of having two components shipping the same CRDs with different versions, but avoids the infinite reconcile loop. The CRDs that is actually installed on the cluster is undefined, the latest one that is applied wins commit 8c7fef2 Author: Luca Burgazzoli <[email protected]> Date: Wed Jan 22 15:45:51 2025 +0100 chore: remove unused code (opendatahub-io#1543) * chore: remove unused TrimToRFC1123Name function * chore: remove unused pkg/cluster/roles functions * chore: remove unused pkg/cluster/resources functions commit e83f2fc Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Wed Jan 22 13:49:00 2025 +0100 Update version to 2.23.0 (opendatahub-io#1544) Co-authored-by: zdtsw <[email protected]> commit 21eba1b Author: Luca Burgazzoli <[email protected]> Date: Wed Jan 22 12:38:49 2025 +0100 chore: cleanup Monitoring's initialize action (opendatahub-io#1542) The Monitoring controller is initialized only when the platform is managed, hence there's no need to conditionally add manifests commit 5321b8c Author: Luca Burgazzoli <[email protected]> Date: Wed Jan 22 11:05:23 2025 +0100 fix: use Monitoring.Spec.Namespace instead of the DSCI one (opendatahub-io#1540) This reduce the direct dependency from Monitoring to DSCI
commit 8caaedfbbc7da4890f41496275a71e4364730646 Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 16:09:34 2025 +0100 added generated files commit aedbf41 Merge: 9135927 6e134b1 Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 16:00:38 2025 +0100 Merge branch 'main' into RHOAIENG-11648/component-mapping-refactor commit 9135927 Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 15:28:08 2025 +0100 removed releases from dashboard since not needed and renamed ComponentReleaseStatus into ComponentRelease commit 237806d Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 12:56:50 2025 +0100 removed releases from dashboard since not needed commit 6e134b1 Author: Wen Zhou <[email protected]> Date: Wed Jan 29 12:41:18 2025 +0100 fix: missing permission to update prometheusrules (opendatahub-io#1581) Signed-off-by: Wen Zhou <[email protected]> commit a044cda Merge: 2571965 bd00c9b Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 12:13:12 2025 +0100 Merge branch 'main' into RHOAIENG-11648/component-mapping-refactor commit 2571965 Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 11:42:27 2025 +0100 Map component versions to RHOAI status for better visibility commit 0f1cf7dd9ca20e41c97a1590e18dc888b68e9fd5 Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 11:40:58 2025 +0100 fix lint error commit 473e86f55fd87e496c5d4251d075dc1082ce6e4c Author: Ugo Giordano <[email protected]> Date: Mon Jan 27 16:42:00 2025 +0100 Map component versions to RHOAI status for better visibility commit 3d47679 Merge: d706b92 bd00c9b Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 11:32:16 2025 +0100 Merge branch 'main' into RHOAIENG-11648/component-mapping-refactor commit d706b92 Author: Ugo Giordano <[email protected]> Date: Tue Jan 28 18:00:29 2025 +0100 Remove fetch releases action from dashboard & e2e tests commit 4e0deb2 Author: Ugo Giordano <[email protected]> Date: Tue Jan 28 16:10:28 2025 +0100 unit test e2e tests commit bd00c9b Author: Luca Burgazzoli <[email protected]> Date: Tue Jan 28 23:53:01 2025 +0100 Improve Kserve's FeatureTraker handing (opendatahub-io#1562) * Improve Kserve's FeatureTraker handing - Make it possible to set FT's OwnerReference as Controller reference so the kubernetes garbage collector can block owner deletion till the FT has been deleted - Make it possible to set FT's generated resources OwnerReference as Controller reference so the kubernetes garbage collector can block FT deletion till the resources have been deleted - Add an Kserver reconciler action to remove legacy ownership on DSCI/DSC is any and related e2e tests * Update RBACs * Update RBACs * Fix findings * Update pkg/cluster/meta.go Co-authored-by: Gerard Ryan <[email protected]> * Fix renaming * Remove unrelated methods --------- Co-authored-by: Gerard Ryan <[email protected]> commit df5495e Author: Wen Zhou <[email protected]> Date: Tue Jan 28 21:21:23 2025 +0100 docs: remove duplicated files and update integration docs (opendatahub-io#1575) Signed-off-by: Wen Zhou <[email protected]> commit ca2f619 Author: Wen Zhou <[email protected]> Date: Tue Jan 28 21:02:36 2025 +0100 fix: missing update permission on dashboard object (opendatahub-io#1576) - add update on all cases Signed-off-by: Wen Zhou <[email protected]> commit a996732 Author: Wen Zhou <[email protected]> Date: Tue Jan 28 20:50:56 2025 +0100 fix: fix wrong map for DSP images (opendatahub-io#1577) - the old images are from 2.15 which have been updated during 2.16 Signed-off-by: Wen Zhou <[email protected]> commit 94095f9 Author: Dipanshu Gupta <[email protected]> Date: Tue Jan 28 21:57:25 2025 +0530 Setup admin permissions for hardware profiles (opendatahub-io#1573) commit 3056ab4 Author: Ajay Jaganathan <[email protected]> Date: Tue Jan 28 17:58:06 2025 +0530 (fix): point to correct path for component integration doc (opendatahub-io#1574) commit d538956 Author: Luca Burgazzoli <[email protected]> Date: Tue Jan 28 10:01:48 2025 +0100 chore: use constants from the status package where possible (opendatahub-io#1541) Co-authored-by: Wen Zhou <[email protected]> commit 9aed5e0 Author: Andrew Ballantyne <[email protected]> Date: Mon Jan 27 13:20:04 2025 -0500 Clarify and update permissions (opendatahub-io#1538) * Add readme to explain values of permissions * NIM Accounts are namespaced resources * Update permissions to fulfill doc design * Based on feedback, less hard-fast ruling wording in the README commit 5e60591 Author: Wen Zhou <[email protected]> Date: Mon Jan 27 17:33:51 2025 +0100 test: disable monitoring config in DSCI for ODH e2e test (opendatahub-io#1570) - we do not enable monitoring in ODH logic - we should keep it enable for rhoai branch Signed-off-by: Wen Zhou <[email protected]> commit a8eb6ff Author: Ugo Giordano <[email protected]> Date: Mon Jan 27 16:51:31 2025 +0100 fix lint add updated api doc commit 4b76ca4 Author: Ugo Giordano <[email protected]> Date: Mon Jan 27 16:42:00 2025 +0100 Map component versions to RHOAI status for better visibility commit 48341ff Author: Luca Burgazzoli <[email protected]> Date: Mon Jan 27 15:38:21 2025 +0100 It takes more than 10 minutes for kserve-controller to be created during 2.17 installation (opendatahub-io#1564) * It takes more than 10 minutes for kserve-controller to be created during 2.17 installation * cleanup commit b0a0f87 Author: Wen Zhou <[email protected]> Date: Mon Jan 27 13:53:40 2025 +0100 update: clean up old code before refactor (opendatahub-io#1494) * update: clean up old code before refactor - remove reference we explicilty check on odhdashboardconfig and kserve - remove customized config on controller QPS - remove RemoveLabel which is not called anywhere Signed-off-by: Wen Zhou <[email protected]> * update: - remove function for upgrade cleanup introduced before 2.8 - remove flags to main: operator namespace and application namespace ( operator namespace is passing as env variable, app namespace is done by DSCI ) Signed-off-by: Wen Zhou <[email protected]> * fix: Auth CR is cluster-scoped no need to set namespace for request - application namespace is removed from reconciler of dsci Signed-off-by: Wen Zhou <[email protected]> * fix: wrong code for upgrade path + rebase error Signed-off-by: Wen Zhou <[email protected]> --------- Signed-off-by: Wen Zhou <[email protected]> commit 7b4dfc2 Author: Wen Zhou <[email protected]> Date: Mon Jan 27 12:01:07 2025 +0100 fix: for upgrade case we will need update permission on buildconfig to revmoew ownerref from dsc (opendatahub-io#1567) Signed-off-by: Wen Zhou <[email protected]> commit a00aa61 Author: Wen Zhou <[email protected]> Date: Mon Jan 27 09:00:32 2025 +0100 fix: add matchlabel on NWP for customized appliation (opendatahub-io#1566) - update README and troubleshooting Signed-off-by: Wen Zhou <[email protected]> commit eb42450 Author: Manjunath Kumatagi <[email protected]> Date: Fri Jan 24 19:11:14 2025 +0530 Build platform independent binary based on the target platform (opendatahub-io#1549) commit bc63cfd Author: Wen Zhou <[email protected]> Date: Thu Jan 23 21:04:44 2025 +0100 update: change previous workaround for subscription and add smcp in the list (opendatahub-io#1557) - remove subs from client cache - add smcp into exclude cache Signed-off-by: Wen Zhou <[email protected]> commit 63d4eab Author: Wen Zhou <[email protected]> Date: Thu Jan 23 18:44:37 2025 +0100 fix: missing monitoring NS for NWP if user opt customized app NS (opendatahub-io#1558) Signed-off-by: Wen Zhou <[email protected]> commit 912dcaa Author: Ugo Giordano <[email protected]> Date: Thu Jan 23 16:56:32 2025 +0100 Align get_all_manifests.sh with Kubeflow main branch (opendatahub-io#1550) commit ce7b381 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Thu Jan 23 14:08:54 2025 +0100 Update version to 2.23.1 (opendatahub-io#1553) Co-authored-by: zdtsw <[email protected]> commit 9845f7e Author: Wen Zhou <[email protected]> Date: Thu Jan 23 14:07:25 2025 +0100 update: various fix backport from RHOAI (opendatahub-io#1536) - fix missing RHOAI monitoring namespace for self-managed - fix wrong namespace name in manifests - update hardcode label name - fix misleading log message Signed-off-by: Wen Zhou <[email protected]> commit 871c799 Author: Wen Zhou <[email protected]> Date: Thu Jan 23 13:21:29 2025 +0100 fix: as a workaround for getting knative opreator check, set cache (opendatahub-io#1555) Signed-off-by: Wen Zhou <[email protected]> commit 28d0fa1 Author: Wen Zhou <[email protected]> Date: Thu Jan 23 11:49:37 2025 +0100 fix: add missing namespace for console in managed cluster (opendatahub-io#1552) - blackbox require this - move into const in cluster pkg Signed-off-by: Wen Zhou <[email protected]> commit 5bcbaba Author: Luca Burgazzoli <[email protected]> Date: Wed Jan 22 19:31:20 2025 +0100 Avoid modelmesh and Kserve loop on updating shared CRDs (opendatahub-io#1547) The KServe and ModelMesh are shipping the same CRDs as part of their manifests but with different versions, this cause the respective component reconcilers to keep trying to install their respective version, ending in a infinite loop. This commit does not solve the underlying problem of having two components shipping the same CRDs with different versions, but avoids the infinite reconcile loop. The CRDs that is actually installed on the cluster is undefined, the latest one that is applied wins commit 8c7fef2 Author: Luca Burgazzoli <[email protected]> Date: Wed Jan 22 15:45:51 2025 +0100 chore: remove unused code (opendatahub-io#1543) * chore: remove unused TrimToRFC1123Name function * chore: remove unused pkg/cluster/roles functions * chore: remove unused pkg/cluster/resources functions commit e83f2fc Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Wed Jan 22 13:49:00 2025 +0100 Update version to 2.23.0 (opendatahub-io#1544) Co-authored-by: zdtsw <[email protected]> commit 21eba1b Author: Luca Burgazzoli <[email protected]> Date: Wed Jan 22 12:38:49 2025 +0100 chore: cleanup Monitoring's initialize action (opendatahub-io#1542) The Monitoring controller is initialized only when the platform is managed, hence there's no need to conditionally add manifests commit 5321b8c Author: Luca Burgazzoli <[email protected]> Date: Wed Jan 22 11:05:23 2025 +0100 fix: use Monitoring.Spec.Namespace instead of the DSCI one (opendatahub-io#1540) This reduce the direct dependency from Monitoring to DSCI
commit 8caaedfbbc7da4890f41496275a71e4364730646 Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 16:09:34 2025 +0100 added generated files commit aedbf41 Merge: 9135927 6e134b1 Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 16:00:38 2025 +0100 Merge branch 'main' into RHOAIENG-11648/component-mapping-refactor commit 9135927 Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 15:28:08 2025 +0100 removed releases from dashboard since not needed and renamed ComponentReleaseStatus into ComponentRelease commit 237806d Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 12:56:50 2025 +0100 removed releases from dashboard since not needed commit 6e134b1 Author: Wen Zhou <[email protected]> Date: Wed Jan 29 12:41:18 2025 +0100 fix: missing permission to update prometheusrules (opendatahub-io#1581) Signed-off-by: Wen Zhou <[email protected]> commit a044cda Merge: 2571965 bd00c9b Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 12:13:12 2025 +0100 Merge branch 'main' into RHOAIENG-11648/component-mapping-refactor commit 2571965 Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 11:42:27 2025 +0100 Map component versions to RHOAI status for better visibility commit 0f1cf7dd9ca20e41c97a1590e18dc888b68e9fd5 Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 11:40:58 2025 +0100 fix lint error commit 473e86f55fd87e496c5d4251d075dc1082ce6e4c Author: Ugo Giordano <[email protected]> Date: Mon Jan 27 16:42:00 2025 +0100 Map component versions to RHOAI status for better visibility commit 3d47679 Merge: d706b92 bd00c9b Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 11:32:16 2025 +0100 Merge branch 'main' into RHOAIENG-11648/component-mapping-refactor commit d706b92 Author: Ugo Giordano <[email protected]> Date: Tue Jan 28 18:00:29 2025 +0100 Remove fetch releases action from dashboard & e2e tests commit 4e0deb2 Author: Ugo Giordano <[email protected]> Date: Tue Jan 28 16:10:28 2025 +0100 unit test e2e tests commit bd00c9b Author: Luca Burgazzoli <[email protected]> Date: Tue Jan 28 23:53:01 2025 +0100 Improve Kserve's FeatureTraker handing (opendatahub-io#1562) * Improve Kserve's FeatureTraker handing - Make it possible to set FT's OwnerReference as Controller reference so the kubernetes garbage collector can block owner deletion till the FT has been deleted - Make it possible to set FT's generated resources OwnerReference as Controller reference so the kubernetes garbage collector can block FT deletion till the resources have been deleted - Add an Kserver reconciler action to remove legacy ownership on DSCI/DSC is any and related e2e tests * Update RBACs * Update RBACs * Fix findings * Update pkg/cluster/meta.go Co-authored-by: Gerard Ryan <[email protected]> * Fix renaming * Remove unrelated methods --------- Co-authored-by: Gerard Ryan <[email protected]> commit df5495e Author: Wen Zhou <[email protected]> Date: Tue Jan 28 21:21:23 2025 +0100 docs: remove duplicated files and update integration docs (opendatahub-io#1575) Signed-off-by: Wen Zhou <[email protected]> commit ca2f619 Author: Wen Zhou <[email protected]> Date: Tue Jan 28 21:02:36 2025 +0100 fix: missing update permission on dashboard object (opendatahub-io#1576) - add update on all cases Signed-off-by: Wen Zhou <[email protected]> commit a996732 Author: Wen Zhou <[email protected]> Date: Tue Jan 28 20:50:56 2025 +0100 fix: fix wrong map for DSP images (opendatahub-io#1577) - the old images are from 2.15 which have been updated during 2.16 Signed-off-by: Wen Zhou <[email protected]> commit 94095f9 Author: Dipanshu Gupta <[email protected]> Date: Tue Jan 28 21:57:25 2025 +0530 Setup admin permissions for hardware profiles (opendatahub-io#1573) commit 3056ab4 Author: Ajay Jaganathan <[email protected]> Date: Tue Jan 28 17:58:06 2025 +0530 (fix): point to correct path for component integration doc (opendatahub-io#1574) commit d538956 Author: Luca Burgazzoli <[email protected]> Date: Tue Jan 28 10:01:48 2025 +0100 chore: use constants from the status package where possible (opendatahub-io#1541) Co-authored-by: Wen Zhou <[email protected]> commit 9aed5e0 Author: Andrew Ballantyne <[email protected]> Date: Mon Jan 27 13:20:04 2025 -0500 Clarify and update permissions (opendatahub-io#1538) * Add readme to explain values of permissions * NIM Accounts are namespaced resources * Update permissions to fulfill doc design * Based on feedback, less hard-fast ruling wording in the README commit 5e60591 Author: Wen Zhou <[email protected]> Date: Mon Jan 27 17:33:51 2025 +0100 test: disable monitoring config in DSCI for ODH e2e test (opendatahub-io#1570) - we do not enable monitoring in ODH logic - we should keep it enable for rhoai branch Signed-off-by: Wen Zhou <[email protected]> commit a8eb6ff Author: Ugo Giordano <[email protected]> Date: Mon Jan 27 16:51:31 2025 +0100 fix lint add updated api doc commit 4b76ca4 Author: Ugo Giordano <[email protected]> Date: Mon Jan 27 16:42:00 2025 +0100 Map component versions to RHOAI status for better visibility commit 48341ff Author: Luca Burgazzoli <[email protected]> Date: Mon Jan 27 15:38:21 2025 +0100 It takes more than 10 minutes for kserve-controller to be created during 2.17 installation (opendatahub-io#1564) * It takes more than 10 minutes for kserve-controller to be created during 2.17 installation * cleanup commit b0a0f87 Author: Wen Zhou <[email protected]> Date: Mon Jan 27 13:53:40 2025 +0100 update: clean up old code before refactor (opendatahub-io#1494) * update: clean up old code before refactor - remove reference we explicilty check on odhdashboardconfig and kserve - remove customized config on controller QPS - remove RemoveLabel which is not called anywhere Signed-off-by: Wen Zhou <[email protected]> * update: - remove function for upgrade cleanup introduced before 2.8 - remove flags to main: operator namespace and application namespace ( operator namespace is passing as env variable, app namespace is done by DSCI ) Signed-off-by: Wen Zhou <[email protected]> * fix: Auth CR is cluster-scoped no need to set namespace for request - application namespace is removed from reconciler of dsci Signed-off-by: Wen Zhou <[email protected]> * fix: wrong code for upgrade path + rebase error Signed-off-by: Wen Zhou <[email protected]> --------- Signed-off-by: Wen Zhou <[email protected]> commit 7b4dfc2 Author: Wen Zhou <[email protected]> Date: Mon Jan 27 12:01:07 2025 +0100 fix: for upgrade case we will need update permission on buildconfig to revmoew ownerref from dsc (opendatahub-io#1567) Signed-off-by: Wen Zhou <[email protected]> commit a00aa61 Author: Wen Zhou <[email protected]> Date: Mon Jan 27 09:00:32 2025 +0100 fix: add matchlabel on NWP for customized appliation (opendatahub-io#1566) - update README and troubleshooting Signed-off-by: Wen Zhou <[email protected]> commit eb42450 Author: Manjunath Kumatagi <[email protected]> Date: Fri Jan 24 19:11:14 2025 +0530 Build platform independent binary based on the target platform (opendatahub-io#1549) commit bc63cfd Author: Wen Zhou <[email protected]> Date: Thu Jan 23 21:04:44 2025 +0100 update: change previous workaround for subscription and add smcp in the list (opendatahub-io#1557) - remove subs from client cache - add smcp into exclude cache Signed-off-by: Wen Zhou <[email protected]> commit 63d4eab Author: Wen Zhou <[email protected]> Date: Thu Jan 23 18:44:37 2025 +0100 fix: missing monitoring NS for NWP if user opt customized app NS (opendatahub-io#1558) Signed-off-by: Wen Zhou <[email protected]> commit 912dcaa Author: Ugo Giordano <[email protected]> Date: Thu Jan 23 16:56:32 2025 +0100 Align get_all_manifests.sh with Kubeflow main branch (opendatahub-io#1550) commit ce7b381 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Thu Jan 23 14:08:54 2025 +0100 Update version to 2.23.1 (opendatahub-io#1553) Co-authored-by: zdtsw <[email protected]> commit 9845f7e Author: Wen Zhou <[email protected]> Date: Thu Jan 23 14:07:25 2025 +0100 update: various fix backport from RHOAI (opendatahub-io#1536) - fix missing RHOAI monitoring namespace for self-managed - fix wrong namespace name in manifests - update hardcode label name - fix misleading log message Signed-off-by: Wen Zhou <[email protected]> commit 871c799 Author: Wen Zhou <[email protected]> Date: Thu Jan 23 13:21:29 2025 +0100 fix: as a workaround for getting knative opreator check, set cache (opendatahub-io#1555) Signed-off-by: Wen Zhou <[email protected]> commit 28d0fa1 Author: Wen Zhou <[email protected]> Date: Thu Jan 23 11:49:37 2025 +0100 fix: add missing namespace for console in managed cluster (opendatahub-io#1552) - blackbox require this - move into const in cluster pkg Signed-off-by: Wen Zhou <[email protected]> commit 5bcbaba Author: Luca Burgazzoli <[email protected]> Date: Wed Jan 22 19:31:20 2025 +0100 Avoid modelmesh and Kserve loop on updating shared CRDs (opendatahub-io#1547) The KServe and ModelMesh are shipping the same CRDs as part of their manifests but with different versions, this cause the respective component reconcilers to keep trying to install their respective version, ending in a infinite loop. This commit does not solve the underlying problem of having two components shipping the same CRDs with different versions, but avoids the infinite reconcile loop. The CRDs that is actually installed on the cluster is undefined, the latest one that is applied wins commit 8c7fef2 Author: Luca Burgazzoli <[email protected]> Date: Wed Jan 22 15:45:51 2025 +0100 chore: remove unused code (opendatahub-io#1543) * chore: remove unused TrimToRFC1123Name function * chore: remove unused pkg/cluster/roles functions * chore: remove unused pkg/cluster/resources functions commit e83f2fc Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Wed Jan 22 13:49:00 2025 +0100 Update version to 2.23.0 (opendatahub-io#1544) Co-authored-by: zdtsw <[email protected]> commit 21eba1b Author: Luca Burgazzoli <[email protected]> Date: Wed Jan 22 12:38:49 2025 +0100 chore: cleanup Monitoring's initialize action (opendatahub-io#1542) The Monitoring controller is initialized only when the platform is managed, hence there's no need to conditionally add manifests commit 5321b8c Author: Luca Burgazzoli <[email protected]> Date: Wed Jan 22 11:05:23 2025 +0100 fix: use Monitoring.Spec.Namespace instead of the DSCI one (opendatahub-io#1540) This reduce the direct dependency from Monitoring to DSCI
commit 8caaedfbbc7da4890f41496275a71e4364730646 Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 16:09:34 2025 +0100 added generated files commit aedbf41 Merge: 9135927 6e134b1 Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 16:00:38 2025 +0100 Merge branch 'main' into RHOAIENG-11648/component-mapping-refactor commit 9135927 Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 15:28:08 2025 +0100 removed releases from dashboard since not needed and renamed ComponentReleaseStatus into ComponentRelease commit 237806d Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 12:56:50 2025 +0100 removed releases from dashboard since not needed commit 6e134b1 Author: Wen Zhou <[email protected]> Date: Wed Jan 29 12:41:18 2025 +0100 fix: missing permission to update prometheusrules (opendatahub-io#1581) Signed-off-by: Wen Zhou <[email protected]> commit a044cda Merge: 2571965 bd00c9b Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 12:13:12 2025 +0100 Merge branch 'main' into RHOAIENG-11648/component-mapping-refactor commit 2571965 Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 11:42:27 2025 +0100 Map component versions to RHOAI status for better visibility commit 0f1cf7dd9ca20e41c97a1590e18dc888b68e9fd5 Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 11:40:58 2025 +0100 fix lint error commit 473e86f55fd87e496c5d4251d075dc1082ce6e4c Author: Ugo Giordano <[email protected]> Date: Mon Jan 27 16:42:00 2025 +0100 Map component versions to RHOAI status for better visibility commit 3d47679 Merge: d706b92 bd00c9b Author: Ugo Giordano <[email protected]> Date: Wed Jan 29 11:32:16 2025 +0100 Merge branch 'main' into RHOAIENG-11648/component-mapping-refactor commit d706b92 Author: Ugo Giordano <[email protected]> Date: Tue Jan 28 18:00:29 2025 +0100 Remove fetch releases action from dashboard & e2e tests commit 4e0deb2 Author: Ugo Giordano <[email protected]> Date: Tue Jan 28 16:10:28 2025 +0100 unit test e2e tests commit bd00c9b Author: Luca Burgazzoli <[email protected]> Date: Tue Jan 28 23:53:01 2025 +0100 Improve Kserve's FeatureTraker handing (opendatahub-io#1562) * Improve Kserve's FeatureTraker handing - Make it possible to set FT's OwnerReference as Controller reference so the kubernetes garbage collector can block owner deletion till the FT has been deleted - Make it possible to set FT's generated resources OwnerReference as Controller reference so the kubernetes garbage collector can block FT deletion till the resources have been deleted - Add an Kserver reconciler action to remove legacy ownership on DSCI/DSC is any and related e2e tests * Update RBACs * Update RBACs * Fix findings * Update pkg/cluster/meta.go Co-authored-by: Gerard Ryan <[email protected]> * Fix renaming * Remove unrelated methods --------- Co-authored-by: Gerard Ryan <[email protected]> commit df5495e Author: Wen Zhou <[email protected]> Date: Tue Jan 28 21:21:23 2025 +0100 docs: remove duplicated files and update integration docs (opendatahub-io#1575) Signed-off-by: Wen Zhou <[email protected]> commit ca2f619 Author: Wen Zhou <[email protected]> Date: Tue Jan 28 21:02:36 2025 +0100 fix: missing update permission on dashboard object (opendatahub-io#1576) - add update on all cases Signed-off-by: Wen Zhou <[email protected]> commit a996732 Author: Wen Zhou <[email protected]> Date: Tue Jan 28 20:50:56 2025 +0100 fix: fix wrong map for DSP images (opendatahub-io#1577) - the old images are from 2.15 which have been updated during 2.16 Signed-off-by: Wen Zhou <[email protected]> commit 94095f9 Author: Dipanshu Gupta <[email protected]> Date: Tue Jan 28 21:57:25 2025 +0530 Setup admin permissions for hardware profiles (opendatahub-io#1573) commit 3056ab4 Author: Ajay Jaganathan <[email protected]> Date: Tue Jan 28 17:58:06 2025 +0530 (fix): point to correct path for component integration doc (opendatahub-io#1574) commit d538956 Author: Luca Burgazzoli <[email protected]> Date: Tue Jan 28 10:01:48 2025 +0100 chore: use constants from the status package where possible (opendatahub-io#1541) Co-authored-by: Wen Zhou <[email protected]> commit 9aed5e0 Author: Andrew Ballantyne <[email protected]> Date: Mon Jan 27 13:20:04 2025 -0500 Clarify and update permissions (opendatahub-io#1538) * Add readme to explain values of permissions * NIM Accounts are namespaced resources * Update permissions to fulfill doc design * Based on feedback, less hard-fast ruling wording in the README commit 5e60591 Author: Wen Zhou <[email protected]> Date: Mon Jan 27 17:33:51 2025 +0100 test: disable monitoring config in DSCI for ODH e2e test (opendatahub-io#1570) - we do not enable monitoring in ODH logic - we should keep it enable for rhoai branch Signed-off-by: Wen Zhou <[email protected]> commit a8eb6ff Author: Ugo Giordano <[email protected]> Date: Mon Jan 27 16:51:31 2025 +0100 fix lint add updated api doc commit 4b76ca4 Author: Ugo Giordano <[email protected]> Date: Mon Jan 27 16:42:00 2025 +0100 Map component versions to RHOAI status for better visibility commit 48341ff Author: Luca Burgazzoli <[email protected]> Date: Mon Jan 27 15:38:21 2025 +0100 It takes more than 10 minutes for kserve-controller to be created during 2.17 installation (opendatahub-io#1564) * It takes more than 10 minutes for kserve-controller to be created during 2.17 installation * cleanup commit b0a0f87 Author: Wen Zhou <[email protected]> Date: Mon Jan 27 13:53:40 2025 +0100 update: clean up old code before refactor (opendatahub-io#1494) * update: clean up old code before refactor - remove reference we explicilty check on odhdashboardconfig and kserve - remove customized config on controller QPS - remove RemoveLabel which is not called anywhere Signed-off-by: Wen Zhou <[email protected]> * update: - remove function for upgrade cleanup introduced before 2.8 - remove flags to main: operator namespace and application namespace ( operator namespace is passing as env variable, app namespace is done by DSCI ) Signed-off-by: Wen Zhou <[email protected]> * fix: Auth CR is cluster-scoped no need to set namespace for request - application namespace is removed from reconciler of dsci Signed-off-by: Wen Zhou <[email protected]> * fix: wrong code for upgrade path + rebase error Signed-off-by: Wen Zhou <[email protected]> --------- Signed-off-by: Wen Zhou <[email protected]> commit 7b4dfc2 Author: Wen Zhou <[email protected]> Date: Mon Jan 27 12:01:07 2025 +0100 fix: for upgrade case we will need update permission on buildconfig to revmoew ownerref from dsc (opendatahub-io#1567) Signed-off-by: Wen Zhou <[email protected]> commit a00aa61 Author: Wen Zhou <[email protected]> Date: Mon Jan 27 09:00:32 2025 +0100 fix: add matchlabel on NWP for customized appliation (opendatahub-io#1566) - update README and troubleshooting Signed-off-by: Wen Zhou <[email protected]> commit eb42450 Author: Manjunath Kumatagi <[email protected]> Date: Fri Jan 24 19:11:14 2025 +0530 Build platform independent binary based on the target platform (opendatahub-io#1549) commit bc63cfd Author: Wen Zhou <[email protected]> Date: Thu Jan 23 21:04:44 2025 +0100 update: change previous workaround for subscription and add smcp in the list (opendatahub-io#1557) - remove subs from client cache - add smcp into exclude cache Signed-off-by: Wen Zhou <[email protected]> commit 63d4eab Author: Wen Zhou <[email protected]> Date: Thu Jan 23 18:44:37 2025 +0100 fix: missing monitoring NS for NWP if user opt customized app NS (opendatahub-io#1558) Signed-off-by: Wen Zhou <[email protected]> commit 912dcaa Author: Ugo Giordano <[email protected]> Date: Thu Jan 23 16:56:32 2025 +0100 Align get_all_manifests.sh with Kubeflow main branch (opendatahub-io#1550) commit ce7b381 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Thu Jan 23 14:08:54 2025 +0100 Update version to 2.23.1 (opendatahub-io#1553) Co-authored-by: zdtsw <[email protected]> commit 9845f7e Author: Wen Zhou <[email protected]> Date: Thu Jan 23 14:07:25 2025 +0100 update: various fix backport from RHOAI (opendatahub-io#1536) - fix missing RHOAI monitoring namespace for self-managed - fix wrong namespace name in manifests - update hardcode label name - fix misleading log message Signed-off-by: Wen Zhou <[email protected]> commit 871c799 Author: Wen Zhou <[email protected]> Date: Thu Jan 23 13:21:29 2025 +0100 fix: as a workaround for getting knative opreator check, set cache (opendatahub-io#1555) Signed-off-by: Wen Zhou <[email protected]> commit 28d0fa1 Author: Wen Zhou <[email protected]> Date: Thu Jan 23 11:49:37 2025 +0100 fix: add missing namespace for console in managed cluster (opendatahub-io#1552) - blackbox require this - move into const in cluster pkg Signed-off-by: Wen Zhou <[email protected]> commit 5bcbaba Author: Luca Burgazzoli <[email protected]> Date: Wed Jan 22 19:31:20 2025 +0100 Avoid modelmesh and Kserve loop on updating shared CRDs (opendatahub-io#1547) The KServe and ModelMesh are shipping the same CRDs as part of their manifests but with different versions, this cause the respective component reconcilers to keep trying to install their respective version, ending in a infinite loop. This commit does not solve the underlying problem of having two components shipping the same CRDs with different versions, but avoids the infinite reconcile loop. The CRDs that is actually installed on the cluster is undefined, the latest one that is applied wins commit 8c7fef2 Author: Luca Burgazzoli <[email protected]> Date: Wed Jan 22 15:45:51 2025 +0100 chore: remove unused code (opendatahub-io#1543) * chore: remove unused TrimToRFC1123Name function * chore: remove unused pkg/cluster/roles functions * chore: remove unused pkg/cluster/resources functions commit e83f2fc Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Wed Jan 22 13:49:00 2025 +0100 Update version to 2.23.0 (opendatahub-io#1544) Co-authored-by: zdtsw <[email protected]> commit 21eba1b Author: Luca Burgazzoli <[email protected]> Date: Wed Jan 22 12:38:49 2025 +0100 chore: cleanup Monitoring's initialize action (opendatahub-io#1542) The Monitoring controller is initialized only when the platform is managed, hence there's no need to conditionally add manifests commit 5321b8c Author: Luca Burgazzoli <[email protected]> Date: Wed Jan 22 11:05:23 2025 +0100 fix: use Monitoring.Spec.Namespace instead of the DSCI one (opendatahub-io#1540) This reduce the direct dependency from Monitoring to DSCI
Description
The KServe and ModelMesh are shipping the same CRDs as part of
their manifests but with different versions, this cause the
respective component reconcilers to keep trying to install
their respective version, ending in a infinite loop.
This commit does not solve the underlying problem of having two
components shipping the same CRDs with different versions, but
avoids the infinite reconcile loop. The CRDs that is actually
installed on the cluster is undefined, the latest one that is
applied wins
https://issues.redhat.com/browse/RHOAIENG-18518
How Has This Been Tested?
kubectl get crd servingruntimes.serving.kserve.io -o yaml -w | grep kubebuilder
kubectl get crd inferenceservices.serving.kserve.io -o yaml -w | grep kubebuilder
Screenshot or short clip
Merge criteria