Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add install for Authroino operator #1519

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: add install for Authroino operator #1519

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tests/e2e/helper_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ const (
servicemeshNamespace = "openshift-operators"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not for this PR, but we should probably have a namespace per operator, since the default namespace suggested by specific operators may be different, i.e. for serverless it is openshift-serverless

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related as well, but I am wondering why one of them toggles "Installing" (I looked the console) when if it's installed it should not change the configuration.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related as well, but I am wondering why one of them toggles "Installing" (I looked the console) when if it's installed it should not change the configuration.
so you already have operatro installed, then run e2e and operator flipped from installed->installing->installed ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, Succeed -> Installing -> Succeed. Not for you?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, rechecked now, did not observe. Some glitch in old cluster may be.

servicemeshOpName = "servicemeshoperator"
serverlessOpName = "serverless-operator"
authorinoOpName = "authorino-operator"
ownedNamespaceNumber = 1 // set to 4 for RHOAI
deleteConfigMap = "delete-configmap-name"
operatorReadyTimeout = 2 * time.Minute
Expand Down Expand Up @@ -445,6 +446,7 @@ func ensureServicemeshOperators(t *testing.T, tc *testContext) error { //nolint:
ops := []string{
serverlessOpName,
servicemeshOpName,
authorinoOpName,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created that time bomb, but probably makes sense to rename ensureServicemeshOperators to ensureDependencyOperators or something (did @VaishnaviHire already do it somewhere?)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated the fuction name to ensureDependencyOperators

}
var errors *multierror.Error
c := make(chan error)
Expand Down