test: add install for Authroino operator #1519
Conversation
|
/test opendatahub-operator-e2e |
| @@ -436,6 +437,7 @@ func ensureServicemeshOperators(t *testing.T, tc *testContext) error { //nolint: | |||
| ops := []string{ | |||
| serverlessOpName, | |||
| servicemeshOpName, | |||
| authorinoOpName, | |||
There was a problem hiding this comment.
I created that time bomb, but probably makes sense to rename ensureServicemeshOperators to ensureDependencyOperators or something (did @VaishnaviHire already do it somewhere?)
There was a problem hiding this comment.
updated the fuction name to ensureDependencyOperators
|
/test opendatahub-operator-e2e |
|
Look good to me. Not adding lgtm since it's do-not-merge |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ykaliuta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
i probably need to get openshift/release#60470 out first, |
- without authorino installed, we have functions for dependency are not tested Signed-off-by: Wen Zhou <[email protected]>
|
New changes are detected. LGTM label has been removed. |
|
with authorino publish their statble release on 4.14-4.15 ocp, this should work without openshift/release#60470 |
| @@ -36,6 +36,7 @@ const ( | |||
| servicemeshNamespace = "openshift-operators" | |||
There was a problem hiding this comment.
not for this PR, but we should probably have a namespace per operator, since the default namespace suggested by specific operators may be different, i.e. for serverless it is openshift-serverless
There was a problem hiding this comment.
Not related as well, but I am wondering why one of them toggles "Installing" (I looked the console) when if it's installed it should not change the configuration.
There was a problem hiding this comment.
Not related as well, but I am wondering why one of them toggles "Installing" (I looked the console) when if it's installed it should not change the configuration.
so you already have operatro installed, then run e2e and operator flipped from installed->installing->installed ?
There was a problem hiding this comment.
Yes, Succeed -> Installing -> Succeed. Not for you?
There was a problem hiding this comment.
Hmm, rechecked now, did not observe. Some glitch in old cluster may be.
|
@zdtsw: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
How Has This Been Tested?
Screenshot or short clip
Merge criteria