feat: added integration tests to cover evicted pods in post conditions

tests/integration/features/fixtures/cluster_test_fixtures.go

@@ -79,6 +79,15 @@
 	return svc, err
 }
 
+func GetPod(ctx context.Context, client client.Client, namespace, name string) (*corev1.Pod, error) {
+	pod := &corev1.Pod{}
+	err := client.Get(ctx, types.NamespacedName{
+		Name: name, Namespace: namespace,
+	}, pod)
+
+	return pod, err
+}
+
 func CreateService(ctx context.Context, client client.Client, namespace, svcName string) (*corev1.Service, error) {
 	if err := client.Create(ctx, &corev1.Service{
 		ObjectMeta: metav1.ObjectMeta{
@@ -101,6 +110,27 @@
 	return GetService(ctx, client, namespace, svcName)
 }
 
+func CreatePod(ctx context.Context, client client.Client, namespace, name string) (*corev1.Pod, error) {
+	if err := client.Create(ctx, &corev1.Pod{
+		ObjectMeta: metav1.ObjectMeta{
+			Name:      name,
+			Namespace: namespace,
+		},
+		Spec: corev1.PodSpec{
+			Containers: []corev1.Container{
+				{
+					Name:  "test",
+					Image: "test",
+				},
+			},
+		},
+	}); err != nil {
+		return nil, err
+	}
+
+	return GetPod(ctx, client, namespace, name)
+}
+
 func CreateSecret(name, namespace string) feature.Action {
 	return func(ctx context.Context, cli client.Client, f *feature.Feature) error {
 		secret := &corev1.Secret{

tests/integration/features/postconditions_int_test.go

@@ -0,0 +1,106 @@
+package features_test
+
+import (
+	"context"
+
+	corev1 "k8s.io/api/core/v1"
+
+	dsciv1 "github.com/opendatahub-io/opendatahub-operator/v2/apis/dscinitialization/v1"
+	"github.com/opendatahub-io/opendatahub-operator/v2/pkg/feature"
+	"github.com/opendatahub-io/opendatahub-operator/v2/tests/envtestutil"
+	"github.com/opendatahub-io/opendatahub-operator/v2/tests/integration/features/fixtures"
+
+	. "github.com/onsi/ginkgo/v2"
+	. "github.com/onsi/gomega"
+)
+
+var _ = Describe("feature postconditions", func() {
+	Context("wait for pods to be ready", func() {
+		var (
+			objectCleaner *envtestutil.Cleaner
+			namespace     string
+			dsci          *dsciv1.DSCInitialization
+		)
+
+		BeforeEach(func(ctx context.Context) {
+			objectCleaner = envtestutil.CreateCleaner(envTestClient, envTest.Config, fixtures.Timeout, fixtures.Interval)
+
+			testFeatureName := "test-pods-ready"
+			namespace = envtestutil.AppendRandomNameTo(testFeatureName)
+			dsciName := envtestutil.AppendRandomNameTo(testFeatureName)
+			dsci = fixtures.NewDSCInitialization(ctx, envTestClient, dsciName, namespace)
+		})
+
+		AfterEach(func(ctx context.Context) {
+			objectCleaner.DeleteAll(ctx, dsci)
+		})
+
+		It("should succeed when all pods in the namespace are ready", func(ctx context.Context) {
+			// given
+			ns := fixtures.NewNamespace(namespace)
+			Expect(envTestClient.Create(ctx, ns)).To(Succeed())
+
+			podReady, err := fixtures.CreatePod(ctx, envTestClient, namespace, "test-pod")
+			Expect(err).ToNot(HaveOccurred())
+
+			podReady.Status.Phase = corev1.PodSucceeded
+
+			Expect(envTestClient.Status().Update(ctx, podReady)).To(Succeed())
+
+			// when
+			featuresHandler := feature.ClusterFeaturesHandler(dsci, func(registry feature.FeaturesRegistry) error {
+				errFeatureAdd := registry.Add(feature.Define("check-pods-ready").
+					PostConditions(feature.WaitForPodsToBeReady(namespace)),
+				)
+
+				Expect(errFeatureAdd).ToNot(HaveOccurred())
+
+				return nil
+			})
+
+			// then
+			Expect(featuresHandler.Apply(ctx, envTestClient)).To(Succeed())
+		})
+
+		It("should succeed when there are evicted pods in the namespace", func(ctx context.Context) {
+			// given
+			ns := fixtures.NewNamespace(namespace)
+			Expect(envTestClient.Create(ctx, ns)).To(Succeed())
+
+			podReady, err := fixtures.CreatePod(ctx, envTestClient, namespace, "test-pod")
+			Expect(err).ToNot(HaveOccurred())
+
+			podReady.Status.Phase = corev1.PodSucceeded
+
+			Expect(envTestClient.Status().Update(ctx, podReady)).To(Succeed())
+
+			podEvicted, err := fixtures.CreatePod(ctx, envTestClient, namespace, "test-pod-evicted")
+			Expect(err).ToNot(HaveOccurred())
+
+			podEvicted.Status.Phase = corev1.PodFailed
+			podEvicted.Status.Reason = "Evicted"
+			podEvicted.Status.Conditions = []corev1.PodCondition{
+				{
+					Type:   corev1.PodReady,
+					Status: corev1.ConditionFalse,
+				},
+			}
+
+			Expect(envTestClient.Status().Update(ctx, podEvicted)).To(Succeed())
+
+			// when
+			featuresHandler := feature.ClusterFeaturesHandler(dsci, func(registry feature.FeaturesRegistry) error {
+				errFeatureAdd := registry.Add(feature.Define("check-pods-ready").
+					PostConditions(feature.WaitForPodsToBeReady(namespace)),
+				)
+
+				Expect(errFeatureAdd).ToNot(HaveOccurred())
+
+				return nil
+			})
+
+			// then
+			Expect(featuresHandler.Apply(ctx, envTestClient)).To(Succeed())
+		})
+	})
+})