-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added integration tests to cover evicted pods in post conditions #1399
base: main
Are you sure you want to change the base?
feat: added integration tests to cover evicted pods in post conditions #1399
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1399 +/- ##
==========================================
+ Coverage 19.88% 20.04% +0.15%
==========================================
Files 160 160
Lines 10818 10843 +25
==========================================
+ Hits 2151 2173 +22
- Misses 8440 8442 +2
- Partials 227 228 +1 ☔ View full report in Codecov by Sentry. |
/cc @zdtsw |
objectCleaner.DeleteAll(ctx, dsci) | ||
}) | ||
|
||
It("should succeed when all pods in the namespace are ready", func(ctx context.Context) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i guess here is
It("should succeed when expected pod in the namespace is ready", func(ctx context.Context) {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise, i am fine with the change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
condition feature.WaitForPodsToBeReady
will be satisfied only if all pods in the namespace are "Ready", in the test case there's only one pod but "should succeed when all pods in the namespace are ready" should still be valid, I can add more pods in the test if you think is necessary
@Al-Pragliola this PR should now targeting |
a52d606
to
d3dfb03
Compare
/retest |
/test opendatahub-operator-e2e |
done! thanks @lburgazzoli |
/test opendatahub-operator-e2e |
Signed-off-by: Alessio Pragliola <[email protected]>
Signed-off-by: Alessio Pragliola <[email protected]>
d3dfb03
to
7546b8d
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Tracking issue: RHOAIENG-15614
Description
Seeing that testing in a real cluster can be quite problematic, I added integration tests to cover scenarios with evicted pods, I didn't add a negative test because it takes 5 minutes to fail and the timeout duration is not configurable.
How Has This Been Tested?
make test
Screenshot or short clip
Merge criteria