Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20250116-Main sync from incubating #350

Merged
merged 30 commits into from
Jan 16, 2025

Conversation

Jooho
Copy link
Contributor

@Jooho Jooho commented Jan 16, 2025

Description

This is exception case. it should be synced from odh-2.22 tag but we have most commits from incubating to main. So this time we sync from incubating to main branch.

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Jooho and others added 29 commits November 20, 2024 23:54
[RHOAIENG-16263]Disable dashboard and fix servingruntime display name
…datahub-io#311)

* [RHOAIENG-13638] - Do not allow isvc creation in protected namespace

chore: Fixes [RHOAIENG-13638] - Kserve model is not Ready after a kserve model is created and deleted from istio-system namespace

Signed-off-by: Spolti <[email protected]>

* review suggestions

Signed-off-by: Spolti <[email protected]>

* Update controllers/webhook/isvc_validator.go

Co-authored-by: Edgar Hernández <[email protected]>
Signed-off-by: Spolti <[email protected]>

---------

Signed-off-by: Spolti <[email protected]>
Co-authored-by: Edgar Hernández <[email protected]>
…hub-io#320)

* feat: added performance metric grpahs config for nvidia nim

Signed-off-by: Tomer Figenblat <[email protected]>

* chore: modifyed the runtime id annotation

Co-authored-by: Edgar Hernández <[email protected]>
Signed-off-by: Tomer Figenblat <[email protected]>

---------

Signed-off-by: Tomer Figenblat <[email protected]>
Co-authored-by: Edgar Hernández <[email protected]>
Signed-off-by: Mariah Holder <[email protected]>
Grab the old release tag based on creation date
Signed-off-by: Mariah Holder <[email protected]>
Co-authored-by: Mariah Holder <[email protected]>
* Migration to kubebuilder v4

Signed-off-by: Edgar Hernández <[email protected]>

* Restore MR E2Es

Signed-off-by: Edgar Hernández <[email protected]>

* Restore top-level files

Signed-off-by: Edgar Hernández <[email protected]>

* Cleaning

Signed-off-by: Edgar Hernández <[email protected]>

* Fixing Makefile and Containerfile

Signed-off-by: Edgar Hernández <[email protected]>

* Linter fixes

Signed-off-by: Edgar Hernández <[email protected]>

* Initial rework of manifests

Signed-off-by: Edgar Hernández <[email protected]>

* Fix manifests

Signed-off-by: Edgar Hernández <[email protected]>

* Fix lint issues

Signed-off-by: Edgar Hernández <[email protected]>

* Deactivate E2Es

Because setup is not automated, yet.

Signed-off-by: Edgar Hernández <[email protected]>

* Feedback: Filippe

Signed-off-by: Edgar Hernández <[email protected]>

* Feedback: Filippe

Test differences after `go mod tidy`

Signed-off-by: Edgar Hernández <[email protected]>

* Apply suggestions from code review: Filippe

Co-authored-by: Filippe Spolti <[email protected]>
Signed-off-by: Edgar Hernández <[email protected]>

* Feedback: Filippe

* Pin go-toolset base image in Containerfile.
* Add `gosec` linter

Signed-off-by: Edgar Hernández <[email protected]>

* Update config/prometheus/monitor.yaml

Co-authored-by: Filippe Spolti <[email protected]>
Signed-off-by: Edgar Hernández <[email protected]>

* Feedback: Filippe

* Small change to comments in Makefile, to make the text clearer.
* Remove (again) `gosec` linter

Signed-off-by: Edgar Hernández <[email protected]>

* Fix panic on controller startup

Signed-off-by: Edgar Hernández <[email protected]>

---------

Signed-off-by: Edgar Hernández <[email protected]>
Co-authored-by: Filippe Spolti <[email protected]>
…b-io#340)

* chore: use naming convention for resources created by nim

Signed-off-by: Tomer Figenblat <[email protected]>

* test: added assertions for dyamic nim resources name

Signed-off-by: Tomer Figenblat <[email protected]>

---------

Signed-off-by: Tomer Figenblat <[email protected]>
…tahub-io#342)

* initial commit for clean up of nim and managed set as default

Signed-off-by: mtrujillo <[email protected]>

* remove space

Signed-off-by: mtrujillo <[email protected]>

* fix code length for linting

Signed-off-by: mtrujillo <[email protected]>

* fixed comments / adjusted import

Signed-off-by: mtrujillo <[email protected]>

---------

Signed-off-by: mtrujillo <[email protected]>
* chore: added new graph object for nim runtimes

Signed-off-by: Tomer Figenblat <[email protected]>

* chore: added REQUEST_OUTCOMES nim graph

Signed-off-by: Tomer Figenblat <[email protected]>

* chore: added fixed typo in nim query object

Signed-off-by: Tomer Figenblat <[email protected]>

* chore: fixed typo in nim query object

Signed-off-by: Tomer Figenblat <[email protected]>

* chore: added initial query for nim gpu cache usage

Signed-off-by: Tomer Figenblat <[email protected]>

* chore: rewrite queries for nim new graphs

Signed-off-by: Tomer Figenblat <[email protected]>

---------

Signed-off-by: Tomer Figenblat <[email protected]>
Signed-off-by: Steve Grubb <[email protected]>
Co-authored-by: Steve Grubb <[email protected]>
…nferenceServices (opendatahub-io#339)

* Implementation of ODH defaulters for InferenceGraph and InferenceService

On creation of InferenceGraph or InferenceService resources, the following default annotations will be added:
* `serving.knative.openshift.io/enablePassthrough: true`
* `sidecar.istio.io/inject: true`
* `sidecar.istio.io/rewriteAppHTTPProbers: true`

The annotations are added only for Serverless mode, and only if they are missing.

Signed-off-by: Edgar Hernández <[email protected]>

* Feedback: Filippe

Extract "ENABLE_WEBHOOKS" string to constant

Signed-off-by: Edgar Hernández <[email protected]>

---------

Signed-off-by: Edgar Hernández <[email protected]>
* Authorization for InferenceGraph (Serverless)

This adds a new controller for KServe InferenceGraph resources. This new controller will have the responsibility of creating Authorino AuthConfig resources (similarly to InferenceServices case), when authorization is available in ODH platform.

InferenceGraphs can now be annotated with `security.opendatahub.io/enable-auth: "true"` to secure InferenceGraphs and only serve requests that are authorized.

Signed-off-by: Edgar Hernández <[email protected]>

* Feedback: Filippe - Event when auth is not available

Signed-off-by: Edgar Hernández <[email protected]>

---------

Signed-off-by: Edgar Hernández <[email protected]>
…-io#347)

* [RHOAIENG-10293] add metrics resources for rawdeployment

Signed-off-by: Vedant Mahabaleshwarkar <[email protected]>

* [RHOAIENG-10293] address feedback

Signed-off-by: Vedant Mahabaleshwarkar <[email protected]>

---------

Signed-off-by: Vedant Mahabaleshwarkar <[email protected]>
@openshift-ci openshift-ci bot requested a review from israel-hdez January 16, 2025 19:10
@openshift-ci openshift-ci bot requested a review from spolti January 16, 2025 19:10
Copy link
Contributor

openshift-ci bot commented Jan 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jooho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: jooho lee <[email protected]>

update go.mod

Signed-off-by: jooho lee <[email protected]>
@mholder6
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 16, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 2c88d33 into opendatahub-io:main Jan 16, 2025
8 checks passed
Jooho added a commit that referenced this pull request Jan 17, 2025
openshift-merge-bot bot pushed a commit that referenced this pull request Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.