Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grab the old release tag based on creation date #327

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Grab the old release tag based on creation date #327

merged 1 commit into from
Dec 6, 2024

Conversation

hdefazio
Copy link
Contributor

@hdefazio hdefazio commented Dec 6, 2024

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@hdefazio hdefazio requested a review from mholder6 December 6, 2024 21:00
@openshift-ci openshift-ci bot added the approved label Dec 6, 2024
mholder6
mholder6 approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@mholder6 mholder6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 6, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hdefazio, mholder6

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mholder6 mholder6 merged commit 4548d44 into opendatahub-io:incubating Dec 6, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mholder6 mholder6 mholder6 approved these changes

@spolti spolti Awaiting requested review from spolti

@terrytangyuan terrytangyuan Awaiting requested review from terrytangyuan

Assignees

@mholder6 mholder6

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hdefazio @mholder6