Revert "Use update time to detect if kmem limits have been set" #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert: opencontainers#935 Fixes: opencontainers#946 I can reproduce opencontainers#946 on some machines, the problem is on some machines, it could be very fast that modify time of `memory.kmem.limit_in_bytes` could be the same as before it's modified. And now we'll call `SetKernelMemory` twice on container creation which cause the second time failure. Revert this before we find a better solution. Signed-off-by: Qiang Huang <[email protected]>
|
We should reopen #841 if we merge this. |
|
As the problem that we'll call |
|
LGTM. I see this alot, and was one of my concerns with the original PR (using the modified time for attach logic). We should figure out a proper fix for this problem. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert: #935
Fixes: #946
I can reproduce #946 on some machines, the problem is on
some machines, it could be very fast that modify time
of
memory.kmem.limit_in_bytescould be the same asbefore it's modified.
And now we'll call
SetKernelMemorytwice on containercreation which cause the second time fail.
Revert this before we find a better solution.
Signed-off-by: Qiang Huang [email protected]