Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestRunWithKernelMemory failed #946

Closed
haiyanmeng opened this issue Jul 14, 2016 · 3 comments
Closed

TestRunWithKernelMemory failed #946

haiyanmeng opened this issue Jul 14, 2016 · 3 comments

Comments

@haiyanmeng
Copy link
Contributor

It seems that the commit 8dd3d63 broke the TestRunWithKernelMemory test somehow. Here is the error in the output of make test:

--- FAIL: TestRunWithKernelMemory (0.13s)^M
    exec_test.go:671: runContainer failed with kernel memory limit: process_linux.go:291: setting cgroup config for ready process caused "cannot set kmem.limit_in_bytes after task have joined this cgroup"^M

Its previou commit 9d7831e works well for me.
@cyphar
Copy link
Member

cyphar commented Jul 18, 2016

/cc @vishh

@haiyanmeng haiyanmeng mentioned this issue Jul 18, 2016
Closed
@cyphar cyphar mentioned this issue Jul 19, 2016
Closed
@haiyanmeng haiyanmeng mentioned this issue Jul 21, 2016
Closed
hqhq added a commit to hqhq/runc that referenced this issue Jul 21, 2016
@hqhq
Revert "Use update time to detect if kmem limits have been set"
15c93ee 
Revert: opencontainers#935
Fixes: opencontainers#946

I can reproduce opencontainers#946 on some machines, the problem is on
some machines, it could be very fast that modify time
of `memory.kmem.limit_in_bytes` could be the same as
before it's modified.

And now we'll call `SetKernelMemory` twice on container
creation which cause the second time failure.

Revert this before we find a better solution.

Signed-off-by: Qiang Huang <[email protected]>
@hqhq hqhq mentioned this issue Jul 21, 2016
Merged
@hqhq
Copy link
Contributor

hqhq commented Jul 21, 2016

I can reproduce this problem on some machines, I opened a PR to revert that commit.
#961

@cyphar
Copy link
Member

cyphar commented Jul 21, 2016

@hqhq I was about to do the same, it's been bothering me for a few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cyphar @haiyanmeng @hqhq