Release 1.2.0-rc.2

[lifubang]

[1.2.0-rc.2] - 2024-06-26

TRUE or FALSE, it's a problem!

Important Notes

• libcontainer/cgroups users who want to manage cgroup devices need to explicitly
  import libcontainer/cgroups/devices. (Decouple setting cgroup device rules from cgroup manager #3452, libct: decouple libct/cg/devices #4248)
• If building with Go 1.22.x, make sure to use 1.22.4 or a later version.
  (see runc doesn't work with go1.22  #4233 for more details)

Added

• CI: add actuated-arm64. (CI: add actuated-arm64 #4142)

Fixed

• cgroup v2: do not set swap to 0 or unlimited when it's not available. (tests/int: swap-related fixes #4188)
• Set the default value of CpuBurst to nil instead of 0. (runc update will clear cpu burst value #4210, set the default value of CpuBurst to nil instead of 0 #4211)
• runc exec: fix setting rlimit_nofile. (racy RLIMIT_NOFILE setting with Go 1.19+ #4195, Fix set nofile rlimit error #4265, Add a correct GoDoc format comment for ClearRlimitNofileCache #4282, Rlimit cache rework for Go 1.23+ #4290)
• libct/cg/fs: fix setting rt_period vs rt_runtime. (When runc updates the values ​​of cpu-rt-period and cpu-rt-runtime synchronously, an error occurs. #4094, libct/cg/fs: fix setting rt_period vs rt_runtime #4258)
• script/*: fix gpg usage wrt keyboxd. (script/*: fix gpg usage wrt keyboxd #4189)
• Fix a debug log message for user namespaces in nsexec. (fix a debug msg for user ns in nsexec #4311)
• libct/cg: write unified resources line by line. (libct/cg: write unified resources line by line #4186)
• libct.Start: fix locking, do not allow a second container init. (libct.Start: fix locking, do not allow a second container init #4271)
• Fix tests in debian testing (mount_sshfs.bats). (Fix tests in debian testing (mount_sshfs.bats) - minimal fix #4245)
• Fix checkpoint/restore tests on actuated-arm64. (fix checkpoint/restore tests on actuated-arm64 #4276)
• Fix codespell warnings. (Fix codespell warnings #4291)
• libct/cg/dev: fix TestSetV1Allow panic. (libct/cg/dev: fix TestSetV1Allow panic #4295)
• tests/int/scheduler: require smp. (tests/int/scheduler: require smp #4298)

Changed

• libcontainer: allow containers to make apps think fips is enabled/disabled for testing. (libcontainer: force apps to think fips is enabled/disabled for testing #4246)
• libct/cg/fs: don't write cpu_burst twice on ENOENT. (libct/cg/fs: don't write cpu_burst twice on ENOENT #4259)
• Allow overriding VERSION value in Makefile. (allow overriding VERSION value in Makefile #4269)
• Make trimpath optional. (make trimpath optional #3908)
• Remove unused system.Execv. (Remove unused system.Execv #4268)
• Stop blacklisting Go 1.22+, drop Go < 1.21 support, use Go 1.22 in CI. (Stop blacklisting Go 1.22+, drop Go < 1.21 support, use Go 1.22 in CI #4292)
• Improve some error messages for runc exec. (Some nits I found from older PRs #4320)
• ci/actuated: re-enable CRIU tests. (ci/actuated: re-enable CRIU tests #4252)
• Vagrantfile.fedora: bump Fedora to 39. (Vagrantfile.fedora: bump Fedora to 39 #4256)
• ci/gha: bump golangci-lint[-action]. (ci/gha: bump golangci-lint[-action] #4255)
• tests/int/tty: increase the timeout. (tests/int/tty: increase the timeout #4260)
• [ci] use go mod instead of go get in spec.bats. ([ci] use go mod instead of go get in spec.bats #4264)
• tests/int/checkpoint: rm double logging. (tests/int/checkpoint: rm double logging #4251)
• ci/gha: bump golangci-lint-action from 5 to 6. (ci/gha: bump golangci-lint-action from 5 to 6 #4275)
• .cirrus.yml: rm FIXME from rootless fs on CentOS 7. (.cirrus.yml: rm FIXME from rootless fs on CentOS 7 #4279)
• vendor: golang.org/x/[email protected]. (vendor: golang.org/x/[email protected] #4280)
• Dockerfile: bump Debian to 12, Go to 1.21. (Dockerfile: bump Debian to 12, Go to 1.21 #4296)
• ci: pin codespell. (ci: pin codespell #4301)
• ci: workaround for centos stream 8 being EOLed. (ci: workaround for centos stream 8 being EOLed #4304)
• ci/cirrus: rm centos stream 8. (ci/cirrus: rm centos stream 8 #4307)
• ci/gha: switch to ubuntu 24.04. (ci/gha: switch to ubuntu 24.04 #4286)
• Vagrantfile.fedora: bump to F40. (Vagrantfile.fedora: bump to F40 #4285)

[rata]

LGTM, thanks for creating this PR so promptly!

It would also LGTM without listing the changes for ci, dependencies and tests. But I think like this is fine, no need to change it :)

[kolyshkin]

Left some notes.

Additionally, we need to release 1.1.13 first and then incorporate 1.1.13 release notes here, and make sure there are no overlaps.

[kolyshkin]

draft until 1.1.13 is released

[lifubang]

Additionally, we need to release 1.1.13 first and then incorporate 1.1.13 release notes here, and make sure there are no overlaps.

Yes, I'll address all your requested changes and update the 1.1.13 release notes after v1.1.13 released.

[kolyshkin]

Yes, I'll address all your requested changes and update the 1.1.13 release notes after v1.1.13 released.

It's time! :)

[lifubang]

@kolyshkin Ready to go!

[rata]

Did some nit comments. But this mostly LGTM

[rata]

LGTM, thanks!!

[kolyshkin]

@lifubang can we fix the changelog to be sorted by version number, not by the release date?

And change the release date, to, say, next Tuesday (25th of June).

[kolyshkin]

@lifubang can we fix the changelog to be sorted by version number, not by the release date?

I see this is being addressed by #4322 (which we need to merge before this one).

[kolyshkin]

needs a rebase

[kolyshkin]

LGTM

[rata]

Sorry I took some time, I was afk.

Added some nits, but this mostly LGTM.

[rata]

LGTM, thanks!

Let's see if we can still make the release today, as the changelog says 🤞

[kolyshkin]

This should not be here since it's also in v1.1.13 but it's too late to fix this. I will remove this line in the github release notes.

[kolyshkin]

Same here. Sorry I overlooked this.

[kolyshkin]

same here

[kolyshkin]

same here

[kolyshkin]

same here, it's in 1.1.13.