Fix codespell warnings #4291
Merged
Fix codespell warnings #4291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
./features.go:30: tru ==> through, true ... ./utils_linux.go:147: infront ==> in front Signed-off-by: Kir Kolyshkin <[email protected]>
lifubang
approved these changes
May 24, 2024
AkihiroSuda
reviewed
May 24, 2024
| // it creates a temp file with the paths filename + '.' infront of it | ||
| // then renames the file | ||
| // createPidFile creates a file containing the PID, | ||
| // doing so atomically (via create and rename). |
There was a problem hiding this comment.
Why remove the description about the file name?
There was a problem hiding this comment.
Two reasons:
- This is a minor internal implementation detail. For a user, it doesn't matter how exactly the temporary file name is constructed.
- It is very clear from the code how it's done. In general, it makes sense to comment the code which is not obvious. This code is quite obvious and thus does not need a comment.
AkihiroSuda
approved these changes
May 24, 2024
lifubang
added
the
backport/1.1-todo
This was referenced Jun 1, 2024
kolyshkin
added
backport/1.1-done
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently released codespell 2.3.0 finds some new issues:
Fix those.