Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow libcontainer/configs to be imported on Windows #2514

Merged
merged 1 commit into from
Jul 8, 2020

Conversation

rhatdan
Copy link
Contributor

@rhatdan rhatdan commented Jul 8, 2020

Signed-off-by: Daniel J Walsh [email protected]

@rhatdan
Copy link
Contributor Author

rhatdan commented Jul 8, 2020

Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrunalp mrunalp merged commit ce54a9d into opencontainers:master Jul 8, 2020
@kolyshkin
Copy link
Contributor

Related: containers/buildah#2652

@rhatdan looks like this PR is not needed any longer, or am I missing something? Asking as I'd like to revert it.

@rhatdan
Copy link
Contributor Author

rhatdan commented Dec 7, 2020

Sure, as long as Podman does not need it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants