Makefile: tweak the cross-compile target #2652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What `go tool dist list` says the toolchain supports changes, so this change removes these attempted cross-compile build targets. * GOOS=darwin, GOARCH unspecified * GOOS=darwin, GOARCH=386 Replace our use of slices of github.com/opencontainers/runc/libcontainer/configs.Device structures with a locally-defined type alias so that we can avoid importing the package on non-Unixy systems. The result is not going to be a very useful binary on non-Linux systems, but it helps ensure that our subpackages won't break compilation for other projects who consume us as a library. Signed-off-by: Nalin Dahyabhai <[email protected]>
nalind
force-pushed
the
cross-tweaks
branch
from
8000d01 to
bf41a3d
Compare
|
LGTM |
|
bors r+ |
|
Build succeeded: |
kolyshkin
added a commit
to kolyshkin/runc
that referenced
this pull request
Dec 3, 2020
This was initially added by commit d78ee47 but later moved from libcontainer/configs to libcontainer/devices by commit 677baf2. Looks like since commit 677baf2 and also [1] there is no use for this, thus removing. [1] containers/buildah#2652 igned-off-by: Kir Kolyshkin <[email protected]>
kolyshkin
added a commit
to kolyshkin/runc
that referenced
this pull request
Dec 3, 2020
This was initially added by commit d78ee47 but later moved from libcontainer/configs to libcontainer/devices by commit 677baf2. Looks like since commit 677baf2 and also [1] there is no use for this, thus removing. [1] containers/buildah#2652 Signed-off-by: Kir Kolyshkin <[email protected]>
kolyshkin
added a commit
to kolyshkin/runc
that referenced
this pull request
Dec 3, 2020
This was initially added by commit d78ee47 but later moved from libcontainer/configs to libcontainer/devices by commit 677baf2. Looks like since commit 677baf2 and also [1] there is no use for this, thus removing. [1] containers/buildah#2652 Signed-off-by: Kir Kolyshkin <[email protected]>
kolyshkin
added a commit
to kolyshkin/runc
that referenced
this pull request
Jan 6, 2021
This was initially added by commit d78ee47 but later moved from libcontainer/configs to libcontainer/devices by commit 677baf2. Looks like since commit 677baf2 and also [1] there is no use for this, thus removing. [1] containers/buildah#2652 Signed-off-by: Kir Kolyshkin <[email protected]>
thaJeztah
pushed a commit
to thaJeztah/runc
that referenced
this pull request
Apr 2, 2021
This was initially added by commit d78ee47 but later moved from libcontainer/configs to libcontainer/devices by commit 677baf2. Looks like since commit 677baf2 and also [1] there is no use for this, thus removing. [1] containers/buildah#2652 Signed-off-by: Kir Kolyshkin <[email protected]>
AdamKorcz
pushed a commit
to AdamKorcz/runc
that referenced
this pull request
May 22, 2021
This was initially added by commit d78ee47 but later moved from libcontainer/configs to libcontainer/devices by commit 677baf2. Looks like since commit 677baf2 and also [1] there is no use for this, thus removing. [1] containers/buildah#2652 Signed-off-by: Kir Kolyshkin <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
What
go tool dist listsays the toolchain supports changes, so this change removes these attempted cross-compile build targets.Replace our use of slices of github.com/opencontainers/runc/libcontainer/configs.Device structures with a locally-defined type alias so that we can avoid importing the package on non-Unixy systems. The result is not going to be a very useful binary on non-Linux systems, but it helps ensure that our subpackages won't break compilation for other projects who consume us as a library.
How to verify it
CI all the way.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Don't try to actually run the non-Linux binaries.
Does this PR introduce a user-facing change?