-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue/86 move functions from ocf dashboard #87
Merged
peterdudfield
merged 15 commits into
main
from
issue/86-move-functions-from-OCF-dashboard
Jan 5, 2024
Merged
Issue/86 move functions from ocf dashboard #87
peterdudfield
merged 15 commits into
main
from
issue/86-move-functions-from-OCF-dashboard
Jan 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add get all site groups to read functions
so I think this fails at the moment due to linting, this can be fixing using the 'make format' and then checked with `make format' |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #87 +/- ##
==========================================
+ Coverage 98.01% 98.33% +0.31%
==========================================
Files 12 12
Lines 353 420 +67
==========================================
+ Hits 346 413 +67
Misses 7 7 ☔ View full report in Codecov by Sentry. |
peterdudfield
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Moves SQLAlchemy database functions from
ocf-dashboard
to the datamodel.Fixes #86 (see also openclimatefix/analysis-dashboard#89
How Has This Been Tested?
pytests for the functions have passed
If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?
Checklist: