Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/86 move functions from ocf dashboard #87

Merged
merged 15 commits into from
Jan 5, 2024

Conversation

rachel-labri-tipton
Copy link
Contributor

Pull Request

Description

Moves SQLAlchemy database functions from ocf-dashboard to the datamodel.

Fixes #86 (see also openclimatefix/analysis-dashboard#89

How Has This Been Tested?

pytests for the functions have passed

  • Yes

If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield
Copy link
Contributor

so I think this fails at the moment due to linting, this can be fixing using the 'make format' and then checked with `make format'

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (51eb33b) 98.01% compared to head (037dabe) 98.33%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #87      +/-   ##
==========================================
+ Coverage   98.01%   98.33%   +0.31%     
==========================================
  Files          12       12              
  Lines         353      420      +67     
==========================================
+ Hits          346      413      +67     
  Misses          7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterdudfield peterdudfield merged commit 0996c51 into main Jan 5, 2024
4 checks passed
@peterdudfield peterdudfield deleted the issue/86-move-functions-from-OCF-dashboard branch January 5, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move SQLAlchemy functions from ocf dashboard to here
2 participants