Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move get_data.py functions to pv-site-datamodel #89

Closed
rachel-labri-tipton opened this issue Oct 16, 2023 · 4 comments · Fixed by #266
Closed

move get_data.py functions to pv-site-datamodel #89

rachel-labri-tipton opened this issue Oct 16, 2023 · 4 comments · Fixed by #266
Assignees

Comments

@rachel-labri-tipton
Copy link
Collaborator

Detailed Description

The get_data.py file contains functions that might be more useful in the pv-site-datamodel.

Context

See the following issue:
openclimatefix/pv-site-datamodel#86
These functions were written as the dashboard was being developed when the datamodel didn't offer a way of getting the needed data.

Possible Implementation

  • Move functions to the pv-site-datamodel.
  • Once the datamodel is updated and deployed, update the ocf-dashboard to import the functions.
@MAYANK12SHARMA
Copy link
Contributor

Hi @peterdudfield,

Has this issue been resolved, or is there still something left to address?

@peterdudfield
Copy link
Contributor

Yea, would be good to move https://github.com/openclimatefix/analysis-dashboard/blob/main/src/get_data.py these to pv-site-datamodel. Might need to check whats there first

@MAYANK12SHARMA
Copy link
Contributor

MAYANK12SHARMA commented Jan 23, 2025

Hii @peterdudfield, I have updated the code by removing two function that was defined in pv_site_datamodel project.

@MAYANK12SHARMA
Copy link
Contributor

Hii @peterdudfield, would you like to review the pr for this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants