-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move get_data.py functions to pv-site-datamodel #89
Comments
Hi @peterdudfield, Has this issue been resolved, or is there still something left to address? |
Yea, would be good to move https://github.com/openclimatefix/analysis-dashboard/blob/main/src/get_data.py these to pv-site-datamodel. Might need to check whats there first |
Hii @peterdudfield, I have updated the code by removing two function that was defined in pv_site_datamodel project. |
Hii @peterdudfield, would you like to review the pr for this issue? |
Detailed Description
The
get_data.py
file contains functions that might be more useful in thepv-site-datamodel
.Context
See the following issue:
openclimatefix/pv-site-datamodel#86
These functions were written as the dashboard was being developed when the datamodel didn't offer a way of getting the needed data.
Possible Implementation
The text was updated successfully, but these errors were encountered: