Step.perform() -> Step.perform(Command, Logger)

[amihaiemil]

Refactoring; PR for #155

[coveralls]

Coverage decreased (-0.3%) to 82.523% when pulling eaa7ec1 on 155 into 1243e87 on master.

[amihaiemil]

@rultor merge

[rultor]

@rultor merge

@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here

[rultor]

@rultor merge

@amihaiemil Oops, I failed. You can see the full log here (spent 2min)

2017-06-19 16:43:50,390 DEBUG - http-outgoing-15 << "[0x9]      "textContent": ["text <em>content</em>..."][\n]"
2017-06-19 16:43:50,390 DEBUG - http-outgoing-15 << "      }[\n]"
2017-06-19 16:43:50,390 DEBUG - http-outgoing-15 << "    },{[\n]"
2017-06-19 16:43:50,390 DEBUG - http-outgoing-15 << "      "_index" : "testindex",[\n]"
2017-06-19 16:43:50,390 DEBUG - http-outgoing-15 << "      "_type" : "tech",[\n]"
2017-06-19 16:43:50,390 DEBUG - http-outgoing-15 << "      "_id" : "http://amihaiemil.com/page34.html",[\n]"
2017-06-19 16:43:50,390 DEBUG - http-outgoing-15 << "      "_score" : 1.0,[\n]"
2017-06-19 16:43:50,390 DEBUG - http-outgoing-15 << "      "_source" : {[\n]"
2017-06-19 16:43:50,390 DEBUG - http-outgoing-15 << "        "id" : "http://amihaiemil.com/page1.html",[\n]"
2017-06-19 16:43:50,390 DEBUG - http-outgoing-15 << "        "name" : "page.html",[\n]"
2017-06-19 16:43:50,390 DEBUG - http-outgoing-15 << "        "url" : "http://amihaiemil.com/some/other/page.html",[\n]"
2017-06-19 16:43:50,390 DEBUG - http-outgoing-15 << "        "title" : "page | title",[\n]"
2017-06-19 16:43:50,390 DEBUG - http-outgoing-15 << "        "textContent" : "text content...",[\n]"
2017-06-19 16:43:50,390 DEBUG - http-outgoing-15 << "        "category" : "mischelaneous",[\n]"
2017-06-19 16:43:50,390 DEBUG - http-outgoing-15 << "        "links" : [ ][\n]"
2017-06-19 16:43:50,390 DEBUG - http-outgoing-15 << "      },[\n]"
2017-06-19 16:43:50,390 DEBUG - http-outgoing-15 << "[0x9]  "highlight": {[\n]"
2017-06-19 16:43:50,390 DEBUG - http-outgoing-15 << "[0x9]      "textContent": ["text <em>content</em>..."][\n]"
2017-06-19 16:43:50,391 DEBUG - http-outgoing-15 << "      }[\n]"
2017-06-19 16:43:50,391 DEBUG - http-outgoing-15 << "    } ][\n]"
2017-06-19 16:43:50,391 DEBUG - http-outgoing-15 << "  }[\n]"
2017-06-19 16:43:50,391 DEBUG - http-outgoing-15 << "}"
2017-06-19 16:43:50,391 DEBUG - http-outgoing-15 << HTTP/1.1 200 OK
2017-06-19 16:43:50,391 DEBUG - http-outgoing-15 << Server: com.jcabi.http.mock.MkGrizzlyAdapter query #1, 1 answer(s) left
2017-06-19 16:43:50,391 DEBUG - http-outgoing-15 << Content-Type: text/plain; charset=iso-8859-1
2017-06-19 16:43:50,391 DEBUG - http-outgoing-15 << Content-Length: 5345
2017-06-19 16:43:50,391 DEBUG - http-outgoing-15 << Date: Mon, 19 Jun 2017 16:43:50 GMT
2017-06-19 16:43:50,391 DEBUG - Connection can be kept alive for 60000 MILLISECONDS
2017-06-19 16:43:50,395 DEBUG - Connection [id: 15][route: {}->http://localhost:38762] can be kept alive for 60.0 seconds
2017-06-19 16:43:50,395 DEBUG - Connection released: [id: 15][route: {}->http://localhost:38762][total kept alive: 1; route allocated: 1 of 50; total allocated: 1 of 50]
2017-06-19 16:43:51,384 INFO - stopped on port #38762
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.045 sec

Results :

Tests in error: 
  illegalStateOnMissingRegion(com.amihaiemil.charles.aws.AmazonEsRepositoryTestCase): Unable to execute HTTP request: Connect to localhost:8080 [localhost/127.0.0.1, localhost/0:0:0:0:0:0:0:1] failed: Connection refused (Connection refused)

Tests run: 112, Failures: 0, Errors: 1, Skipped: 0

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 33.017 s
[INFO] Finished at: 2017-06-19T16:43:51+00:00
[INFO] Final Memory: 33M/452M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.12.4:test (default-test) on project charles-rest: There are test failures.
[ERROR] 
[ERROR] Please refer to /home/r/repo/target/surefire-reports for the individual test results.
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
container 0ddf10a55f4c5f31b07451d5f9234b12ff2dfeb5997fb5483e00af2a00cd935b is dead
Mon Jun 19 18:44:29 CEST 2017