Skip to content
This repository has been archived by the owner on Dec 5, 2020. It is now read-only.

Step.perform() -> Step.perform(Command, Logger) #155

Closed
amihaiemil opened this issue Dec 8, 2016 · 4 comments
Closed

Step.perform() -> Step.perform(Command, Logger) #155

amihaiemil opened this issue Dec 8, 2016 · 4 comments

Comments

@amihaiemil
Copy link
Member

Class Brain is growing bigger and bigger with quite long methods and duplicated code.
It should be broken down in more components and maybe made imutable.

Idea: Brain might work with Knowledges or Understandings. These would be responsible for returning the Steps to be executed. In other words: "the agent (brain) has knowledge of how to index a site, index a page, delete an index etc"

@amihaiemil
Copy link
Member Author

amihaiemil commented Dec 8, 2016

This is postponed to version 1.1.0, since we should publish the release soon and do not have time to keep going back and refactor code. Also, no more actions/commands steps will be implemented until then.

@amihaiemil
Copy link
Member Author

@charlesmike hello ... are you off regex?

@charlesmike
Copy link
Member

@charlesmike hello ... are you off regex?

Hi @amihaiemil! I can help you index your Github-hosted website, provided that the repository name respects the format owner.github.io (or has a gh-pages branch) and the command is given by the repo's owner.

More on commands here.

@amihaiemil amihaiemil changed the title Refactor class Brain Step.perform() -> Step.perform(Command, Logger) Jun 15, 2017
@amihaiemil
Copy link
Member Author

The Command and Logger should be passed as params in the perform(...) method to:

  1. make the building of the Steps pyramid easier and more readable
  2. make sure all the steps in the pyramid work on the same command and with the same logger (right now, you can add any steps on top of eachother, and each step may work with a different command)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants