Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #660 #745

Closed
RHJihan opened this issue Dec 24, 2022 · 1 comment
Closed

Fix for #660 #745

RHJihan opened this issue Dec 24, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@RHJihan
Copy link
Contributor

RHJihan commented Dec 24, 2022

Description
An option in Preference to toggle Force show suggestions everywhere that will override mShouldShowSuggestions = !(mIsPasswordField || flagNoSuggestions); to mShouldShowSuggestions = !mIsPasswordField;

This will fix #660 as a workaround.
@Helium314, Would you please look at it?
@RHJihan RHJihan added the enhancement New feature or request label Dec 24, 2022
odmfl added a commit to odmfl/openboard that referenced this issue Jan 3, 2023
@odmfl
optimize keyboard height,and fix suggestions
23b19ab 
problems not visible in many apps like
playstore, kiwi browser...

Fix openboard-team#660 openboard-team#745 openboard-team#747 openboard-team#275 openboard-team#418 openboard-team#507 openboard-team#345
@odmfl odmfl mentioned this issue Jan 3, 2023
Closed
@odmfl
Copy link

odmfl commented Jan 3, 2023

resolved in PR #750 no need to add any other options or weird stuff, this follows the normal behavior of the aosp keyboard

@RHJihan RHJihan closed this as completed Jan 3, 2023
@odmfl odmfl mentioned this issue Jul 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RHJihan @odmfl