added emoji search and other fixes

[odmfl]

Fiix #35 #197 #527 #660 #745 #747 #275 #418 #507 #345

for gesture typing function, you don't need google external library, you can have a look at this build and related commits https://github.com/wordmage/openboard/commits/master

[Helium314]

How does this emoji search compare to using an emoji dictionary (examples in openboard-team/openboard#35 (comment), sample files available in the dict folder)?

To me a dictionary seems superior / more flexible, because this way each user can choose whether they want emoji suggestions, as well as the language.

for gesture typing function, you don't need google external library, you can have a look at this build and related commits

I think you already read in the discussion that these files are missing license information

Also, please don't mash several independent changes into a single PR. Just create several PRs, this simplifies checking and discussions a lot.

[odmfl]

Yes actually it would be better to use an emoji dictionary, perhaps by downloading them as for dictionaries

As for gesture typing I read the licensing issue, one would have to rewrite the code.
Using the external library for gesture typing is a good trick to bypass the license.

I honestly don’t know how to do individual PR, sorry.
However if you want I can eliminate the PR and you take only the best PR.

[RHJihan]

I don't know if it's good or bad. (with dictionaries/experimental/dict/emoji_en.dict)

[Helium314]

The wordlist.combined file is created from emoji-en-US.json in this PR. The main issue with this dictionary is that it has more than 85 entries for face, 19 for smile, and more than 200 for nation and country.
openboard-team/openboard#749 (comment) seems to be a comment on the same thing.

So while this shows that emoji dictionaries word and do what they should, I think the dictionary is not suitable. Maybe we can find a better list somewhere...

[Helium314]

Is there anything else in this PR other than the emoji search and the height / spacing changes that are also in #8?

[odmfl]

Is there anything else in this PR other than the emoji search and the height / spacing changes that are also in #8?

there's something about the tips that weren't appearing in certain apps

[Helium314]

What's the difference to the current version?

[odmfl]

What's the difference to the current version?

nothing, you already fixed it.

[odmfl]

The wordlist.combined file is created from emoji-en-US.json in this PR. The main issue with this dictionary is that it has more than 85 entries for face, 19 for smile, and more than 200 for nation and country. openboard-team#749 (comment) seems to be a comment on the same thing.

So while this shows that emoji dictionaries word and do what they should, I think the dictionary is not suitable. Maybe we can find a better list somewhere...

however, if it helps, there is indic keyboard which has an emoji search that I think is based on the dictionary, but honestly I don't like it, because it doesn't appear in the suggestions, however I leave you the commits to take a look

https://github.com/search?q=repo%3Asmc%2FIndic-Keyboard+search+emoji&type=commits&s=author-date&o=asc

smc/Indic-Keyboard@be965d9

[Helium314]

Maybe I'll try creating a dictionary from aliases and tags in https://github.com/github/gemoji/blob/master/db/emoji.json
On first glance this looks more suitable than the emoji-en-US.json of the current test dictionary.

[odmfl]

Maybe I'll try creating a dictionary from aliases and tags in https://github.com/github/gemoji/blob/master/db/emoji.json
On first glance this looks more suitable than the emoji-en-US.json of the current test dictionary.

Yes it could be an excellent solution, perhaps even managing to support different languages

[Helium314]

I updated the dictionary.
Did only a short test, but it seems considerably better.

Still, many emoji keywords actually consist of several words separated by _, e.g. "person_white_hair". Most likely this is useless, as I wouldn't expect anyone to enter "person_white_hair". So essentially these emojis should either be removed, or the words adjusted to really be single words.
This would possibly need to be done manually, and thus be a lot of work. And there is the danger of having too many emojis for a keyword, like in emoji-en-US.json

[odmfl]

The new dictionary seems to work fine. Emoji dictionaries should also be created for other languages. However I close the PR, better to make separate changes