-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Base: Correlate Mesh & Particle Groups #243
Base: Correlate Mesh & Particle Groups #243
Conversation
This allows to add an optional attribute to particle groups and mesh records to cross-correlate projections and probes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this nice addition, @ax3l . This would definitely simply some things in VisualPIC!
I have one question though: the implementation here works well to link mesh records to particle groups, but this means that both have to exist. However, it can happen sometimes that, for example, the simulation output contains the charge density field associated to a particle species, but does not contain the species itself as particle group. In this case, the mesh is therefore not linked to a particle group, but simply to a species in the simulation. Would this be a problem here?
That's a good point. I think we can add a note for implementers to clarify. It's still really useful to reference a particle group name for meshes like |
Clarify that referencing particle groups and mesh records that are skipped in output is ok.
Looks good, thanks a lot!
That's also a nice convention. I'll keep it in mind for when I have to implement it in Wake-T. |
Description
This allows to add an optional attribute to particle groups and mesh records to cross-correlate projections and probes.
Implements issue: #238
Affected Components
base
Logic Changes
TODO: (write this)
Writer Changes
None
Reader Changes
TODO: (write this)
What would a reader need to change? Link implementation examples!
openPMD-validator
:openPMD-viewer
:VisualPIC
: https://github.com/AngelFP/VisualPICyt
: noneVisIt
: noneconverter
: noneopenPMD-api
: noneData Updater
None