Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base: Correlate Mesh & Particle Groups #243

Merged
merged 2 commits into from
Mar 9, 2021

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Feb 1, 2021

Description

This allows to add an optional attribute to particle groups and mesh records to cross-correlate projections and probes.

Implements issue: #238

Affected Components

  • base

Logic Changes

TODO: (write this)

Writer Changes

None

Reader Changes

TODO: (write this)

What would a reader need to change? Link implementation examples!

Data Updater

None

This allows to add an optional attribute to particle groups and
mesh records to cross-correlate projections and probes.
@ax3l ax3l added the minor change backwards-compatible change label Feb 1, 2021
@ax3l ax3l added this to the openPMD 2.X milestone Feb 1, 2021
@ax3l ax3l requested review from RemiLehe and AngelFP February 1, 2021 19:28
Copy link
Member

@AngelFP AngelFP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this nice addition, @ax3l . This would definitely simply some things in VisualPIC!

I have one question though: the implementation here works well to link mesh records to particle groups, but this means that both have to exist. However, it can happen sometimes that, for example, the simulation output contains the charge density field associated to a particle species, but does not contain the species itself as particle group. In this case, the mesh is therefore not linked to a particle group, but simply to a species in the simulation. Would this be a problem here?

@ax3l
Copy link
Member Author

ax3l commented Feb 3, 2021

That's a good point. I think we can add a note for implementers to clarify.

It's still really useful to reference a particle group name for meshes like <species>_chargeDensity, even if the particle output is disabled for an openPMD series.

STANDARD.md Show resolved Hide resolved
STANDARD.md Show resolved Hide resolved
Clarify that referencing particle groups and mesh records that are
skipped in output is ok.
@AngelFP
Copy link
Member

AngelFP commented Feb 10, 2021

Looks good, thanks a lot!

It's still really useful to reference a particle group name for meshes like <species>_chargeDensity, even if the particle output is disabled for an openPMD series.

That's also a nice convention. I'll keep it in mind for when I have to implement it in Wake-T.

@RemiLehe RemiLehe merged commit 07bb7c5 into openPMD:upcoming-2.0.0 Mar 9, 2021
@ax3l ax3l deleted the topic-correlatedMeshParticles branch March 23, 2021 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor change backwards-compatible change
Projects
Status: Implemented
Development

Successfully merging this pull request may close these issues.

3 participants