Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deactivate identification of field-related species #25

Merged
merged 1 commit into from
Sep 9, 2021

Conversation

AngelFP
Copy link
Owner

@AngelFP AngelFP commented Sep 8, 2021

This PR deactivates a feature in the openPMD folder scanner which tries to determine whether a field corresponds to a particle species. The implementation was only valid for FBPIC and could lead to problems in other cases where an '_' was present in the field name. A better way of identifying whether a field belongs to a species will be implemented once openPMD 2.0 is released, as this feature will be added to the standard as an optional parameter (see openPMD/openPMD-standard#243, openPMD/openPMD-standard#238).

@AngelFP AngelFP merged commit 235f33b into general_redesign Sep 9, 2021
@AngelFP AngelFP deleted the feature/deactivate-field-species branch September 9, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant