Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial experimental .NET CLR runtime metrics #1035

Merged
merged 36 commits into from
Aug 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
54833c4
Add initial experimental .NET CLR runtime metrics
stevejgordon May 14, 2024
c6b3628
Fixing lint failures
stevejgordon May 14, 2024
c80a739
PR feedback
stevejgordon May 14, 2024
8cc3175
Update model/metrics/clr-metrics.yaml
stevejgordon May 15, 2024
6b0a6e9
Update model/metrics/clr-metrics.yaml
stevejgordon May 15, 2024
866a85c
Regen after generator fixes
stevejgordon May 15, 2024
8f95fd1
Update model/metrics/clr-metrics.yaml
stevejgordon May 16, 2024
f1dd3dd
Update based on PR feedback
stevejgordon May 16, 2024
4ae73ed
Rename to dotnet and address PR feedback
stevejgordon Jun 18, 2024
d08792a
Fix issue templates
stevejgordon Jun 18, 2024
72c1657
Update dotnet attribute registry
stevejgordon Jun 21, 2024
1a27404
Switch to error.type attribute for exceptions
stevejgordon Jun 21, 2024
fe47a31
Add brief to gc.heap.generation members
stevejgordon Jun 21, 2024
a5da35c
Fix DocumentStatus URL
stevejgordon Jun 21, 2024
cdbef6a
Move implementation hints to notes in yaml
stevejgordon Jun 21, 2024
3d14868
Update with proposed renames
stevejgordon Jun 21, 2024
630ee50
Fix YAML
stevejgordon Jun 21, 2024
aa4eb33
Fix trailing quote in note in YAML
stevejgordon Jun 21, 2024
1aefc29
PR renaming feedback
stevejgordon Jun 28, 2024
5d63a8f
Add CPU metrics
stevejgordon Jun 28, 2024
a4ad895
Fix unit on dotnet.thread_pool.queue.length
stevejgordon Jul 2, 2024
dc63af3
Fix typo in metric name
stevejgordon Jul 10, 2024
88fd58c
Clarify memory committed
stevejgordon Jul 10, 2024
90a9356
Update tables and TOC
stevejgordon Jul 10, 2024
f8866a1
Apply latest naming suggestions
stevejgordon Jul 11, 2024
eab22b2
Add meter name notes, cleanup MD and ordering
stevejgordon Jul 11, 2024
c48510f
Update codeowners
stevejgordon Jul 11, 2024
8e90ea0
Update model/metrics/dotnet-metrics.yaml
stevejgordon Jul 16, 2024
8717a40
Add display name and regen tables
stevejgordon Jul 16, 2024
b4b98c0
Update model/metrics/dotnet-metrics.yaml
stevejgordon Aug 5, 2024
085e331
Update tables
stevejgordon Aug 5, 2024
fbd75f2
Update attribute registry
stevejgordon Aug 5, 2024
6b7a0ed
Clarify gc collections note
stevejgordon Aug 7, 2024
47ed007
Merge branch 'main' into dotnet-runtime-metrics
lmolkova Aug 23, 2024
d104216
Apply suggestions from code review
lmolkova Aug 23, 2024
6dcfd10
regenrate table
lmolkova Aug 23, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions .chloggen/clr-runtime.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
# Use this changelog template to create an entry for release notes.
#
# If your change doesn't affect end users you should instead start
# your pull request title with [chore] or use the "Skip Changelog" label.

# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: new_component

# The name of the area of concern in the attributes-registry, (e.g. http, cloud, db)
component: dotnet

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Adds experimental metrics for the .NET Common Language Runtime (CLR)."

# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
# The values here must be integers.
issues: [956]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext:
11 changes: 7 additions & 4 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,13 @@
/model/registry/oci.yaml @open-telemetry/specs-semconv-approvers @open-telemetry/semconv-container-approvers

# .NET semantic conventions approvers
/model/metrics/dotnet/ @open-telemetry/specs-semconv-approvers @open-telemetry/semconv-dotnet-approver @open-telemetry/semconv-http-approvers
/model/registry/aspnetcore.yaml @open-telemetry/specs-semconv-approvers @open-telemetry/semconv-dotnet-approver @open-telemetry/semconv-http-approvers
/model/registry/signalr.yaml @open-telemetry/specs-semconv-approvers @open-telemetry/semconv-dotnet-approver @open-telemetry/semconv-http-approvers
/docs/dotnet/ @open-telemetry/specs-semconv-approvers @open-telemetry/semconv-dotnet-approver @open-telemetry/semconv-http-approvers
/model/metrics/dotnet/ @open-telemetry/specs-semconv-approvers @open-telemetry/semconv-dotnet-approver @open-telemetry/semconv-http-approvers
/model/registry/aspnetcore.yaml @open-telemetry/specs-semconv-approvers @open-telemetry/semconv-dotnet-approver @open-telemetry/semconv-http-approvers
/model/registry/signalr.yaml @open-telemetry/specs-semconv-approvers @open-telemetry/semconv-dotnet-approver @open-telemetry/semconv-http-approvers
/docs/dotnet/ @open-telemetry/specs-semconv-approvers @open-telemetry/semconv-dotnet-approver @open-telemetry/semconv-http-approvers
/model/metrics/dotnet-metrics.yaml @open-telemetry/specs-semconv-approvers @open-telemetry/semconv-dotnet-approver
/model/registry/dotnet.yaml @open-telemetry/specs-semconv-approvers @open-telemetry/semconv-dotnet-approver
/docs/runtime/dotnet-metrics.md @open-telemetry/specs-semconv-approvers @open-telemetry/semconv-dotnet-approver

# Gen-AI semantic conventions approvers
/model/registry/gen-ai.yaml @open-telemetry/specs-semconv-approvers @open-telemetry/semconv-llm-approvers
Expand Down
1 change: 1 addition & 0 deletions .github/ISSUE_TEMPLATE/bug_report.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ body:
- area:device
- area:disk
- area:dns
- area:dotnet
- area:error
- area:event
- area:exception
Expand Down
1 change: 1 addition & 0 deletions .github/ISSUE_TEMPLATE/change_proposal.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ body:
- area:device
- area:disk
- area:dns
- area:dotnet
- area:error
- area:event
- area:exception
Expand Down
1 change: 1 addition & 0 deletions .github/ISSUE_TEMPLATE/new-conventions.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ body:
- area:device
- area:disk
- area:dns
- area:dotnet
- area:error
- area:event
- area:exception
Expand Down
1 change: 1 addition & 0 deletions docs/attributes-registry/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ Currently, the following namespaces exist:
- [Device](device.md)
- [Disk](disk.md)
- [Dns](dns.md)
- [Dotnet](dotnet.md)
- [Enduser](enduser.md)
- [Error](error.md)
- [Event](event.md)
Expand Down
25 changes: 25 additions & 0 deletions docs/attributes-registry/dotnet.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
<!--- Hugo front matter used to generate the website version of this page:
--->

<!-- NOTE: THIS FILE IS AUTOGENERATED. DO NOT EDIT BY HAND. -->
<!-- see templates/registry/markdown/attribute_namespace.md.j2 -->

# Dotnet

## .NET Attributes

This document defines .NET related attributes.

| Attribute | Type | Description | Examples | Stability |
| --------------------------- | ------ | ------------------------------------------------------ | ---------------------- | ---------------------------------------------------------------- |
| `dotnet.gc.heap.generation` | string | Name of the garbage collector managed heap generation. | `gen0`; `gen1`; `gen2` | ![Experimental](https://img.shields.io/badge/-experimental-blue) |

`dotnet.gc.heap.generation` has the following list of well-known values. If one of them applies, then the respective value MUST be used; otherwise, a custom value MAY be used.

| Value | Description | Stability |
| ------ | ------------------ | ---------------------------------------------------------------- |
| `gen0` | Generation 0 | ![Experimental](https://img.shields.io/badge/-experimental-blue) |
| `gen1` | Generation 1 | ![Experimental](https://img.shields.io/badge/-experimental-blue) |
| `gen2` | Generation 2 | ![Experimental](https://img.shields.io/badge/-experimental-blue) |
| `loh` | Large Object Heap | ![Experimental](https://img.shields.io/badge/-experimental-blue) |
| `poh` | Pinned Object Heap | ![Experimental](https://img.shields.io/badge/-experimental-blue) |
1 change: 1 addition & 0 deletions docs/runtime/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ semantic conventions when instrumenting runtime environments.
- [JVM](jvm-metrics.md)
- [Node.js](nodejs-metrics.md)
- [V8 JS Engine](v8js-metrics.md)
- [.NET](dotnet-metrics.md)

### Attributes

Expand Down
Loading
Loading