Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OTEL_RESOURCE_ATTRIBUTES instead of OTEL_RESOURCE_LABELS. #758

Conversation

carlosalberto
Copy link
Contributor

Follow up to #666

The reason being that Resource Labels were (relatively recently) renamed to Resource Attributes.

@carlosalberto
Copy link
Contributor Author

@open-telemetry/specs-approvers please review this one - it's (I think) a straightforward item.

@carlosalberto carlosalberto merged commit 0bc38e4 into open-telemetry:master Aug 6, 2020
codeboten pushed a commit to codeboten/opentelemetry-go that referenced this pull request Aug 6, 2020
codeboten pushed a commit to codeboten/opentelemetry-python that referenced this pull request Aug 6, 2020
The environment variable OTEL_RESOURCE has been renamed to OTEL_RESOURCE_ATTRIBUTES as per the specification open-telemetry/opentelemetry-specification#758
MrAlias pushed a commit to open-telemetry/opentelemetry-go that referenced this pull request Aug 7, 2020
* Renaming OTEL_RESOURCE_LABELS env var

As per the specification here open-telemetry/opentelemetry-specification#758

* update changelog
davydog187 added a commit to davydog187/opentelemetry-erlang that referenced this pull request Oct 30, 2020
Ran into an issue getting Lightstep running locally, and realized it was
due to a name change on the `OTEL_RESOURCE_LABELS` env variable. It
recently changed in the spec.

open-telemetry/opentelemetry-specification#758
https://github.com/open-telemetry/opentelemetry-specification/blob/c9eeaaec21a3afa421546dd9c92221ba537dde82/specification/sdk-environment-variables.md
shbieng added a commit to shbieng/opentelemetry-go that referenced this pull request Aug 26, 2022
* Renaming OTEL_RESOURCE_LABELS env var

As per the specification here open-telemetry/opentelemetry-specification#758

* update changelog
carlosalberto added a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:sdk Related to the SDK spec:resource Related to the specification/resource directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants