Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the env var/system property for resource labels #1511

Closed
jkwatson opened this issue Aug 5, 2020 · 2 comments
Closed

Update the env var/system property for resource labels #1511

jkwatson opened this issue Aug 5, 2020 · 2 comments
Labels
good first issue help wanted release:required-for-ga Required for 1.0 GA release SDK

Comments

@jkwatson
Copy link
Contributor

jkwatson commented Aug 5, 2020

Now that open-telemetry/opentelemetry-specification#666 has been merged, we should use the standard env var/system property for Resources. See EnvAutodetectResource.java for details.
@jkwatson
Copy link
Contributor Author

jkwatson commented Aug 5, 2020

Maybe not needed if open-telemetry/opentelemetry-specification#758 gets merged. ;)

@jkwatson
Copy link
Contributor Author

jkwatson commented Aug 6, 2020

closing, since the spec got updated to match us.

@jkwatson jkwatson closed this as completed Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted release:required-for-ga Required for 1.0 GA release SDK
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jkwatson