add console as a supported env variable exporter type #3742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeboten
pushed a commit
to codeboten/opentelemetry-go-contrib
that referenced
this pull request
Oct 26, 2023
This adds support for the standard output exporter for traces and metrics. To remain consistent with other implementations, i used the key `console` as the identifier for the exporter. This change is related to the specification pull request open-telemetry/opentelemetry-specification#3742 Signed-off-by: Alex Boten <[email protected]>
tylerbenson
approved these changes
Oct 26, 2023
pellared
reviewed
Oct 30, 2023
pellared
approved these changes
Oct 30, 2023
tylerbenson
reviewed
Oct 30, 2023
|
Note to reviewers that |
codeboten
pushed a commit
to codeboten/opentelemetry-go-contrib
that referenced
this pull request
Nov 1, 2023
This adds support for the standard output exporter for traces and metrics. To remain consistent with other implementations, i used the key `console` as the identifier for the exporter. This change is related to the specification pull request open-telemetry/opentelemetry-specification#3742 Signed-off-by: Alex Boten <[email protected]>
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
1 task
|
For completness: Following the spec compliance matrix the following languages have support for OTEL_TRACES_EXPORTER and besides I listed how an enduser can set the console exporter:
Rust, C++, Go and Swift are listed with not supported/unknown. .NET is also listed as not supported, but the .NET auto instrumentation has the following construct (see https://opentelemetry.io/docs/instrumentation/net/getting-started/ & https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/blob/main/docs/config.md#internal-logs): |
|
Go will add support for |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
jack-berg
reviewed
Nov 17, 2023
added 2 commits
November 20, 2023 20:55
This PR is a follow up to open-telemetry#3740 and open-telemetry#3741. As some languages (the ones I looked at were: python, js, ruby) already support the `console` type of exporter, I thought it would be good if the spec confirmed it. Signed-off-by: Alex Boten <[email protected]>
Signed-off-by: Alex Boten <[email protected]>
codeboten
force-pushed
the
codeboten/env-var-exporters-console
branch
from
15892d7 to
1fcefba
Compare
pellared
approved these changes
Nov 21, 2023
carlosalberto
approved these changes
Nov 21, 2023
jack-berg
approved these changes
Nov 21, 2023
added 2 commits
November 24, 2023 08:19
pellared
approved these changes
Nov 27, 2023
MrAlias
reviewed
Nov 27, 2023
Co-authored-by: Tyler Yahn <[email protected]>
Co-authored-by: Tyler Yahn <[email protected]>
Co-authored-by: Tyler Yahn <[email protected]>
MrAlias
approved these changes
Nov 27, 2023
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
…#3742) ## Changes This PR is a follow up to open-telemetry#3740 and open-telemetry#3741. As some languages (the ones I looked at were: python, js, ruby) already support the `console` type of exporter, I thought it would be good if the spec confirmed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR is a follow up to #3740 and #3741. As some languages (the ones I looked at were: python, js, ruby) already support the
consoletype of exporter, I thought it would be good if the spec confirmed it.CHANGELOG.mdfile updated for non-trivial changesKeeping in draft until the other PRs are reviewed.