-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
autoexport: Add support for console exporters #4486
autoexport: Add support for console exporters #4486
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4486 +/- ##
=======================================
- Coverage 80.9% 80.9% -0.1%
=======================================
Files 150 150
Lines 10304 10313 +9
=======================================
+ Hits 8339 8345 +6
- Misses 1825 1827 +2
- Partials 140 141 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
open-telemetry/opentelemetry-specification#3742: it would be good to make sure there is an agreement on the "name" before merging 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reviewing @pellared, I agree that having a consistent name would be good :) This is at least consistent w/ 3 (python, js, ruby) implementations. Java uses the term logging
https://github.com/open-telemetry/opentelemetry-java/blob/main/sdk-extensions/autoconfigure/README.md#logging-exporter which I worry is causing the same confusion as the logging
exporter did in the Collector before it was renamed to debug
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is at least consistent w/ 3 (python, js, ruby) implementations.
I suggest calling it out in open-telemetry/opentelemetry-specification#3742
This adds support for the standard output exporter for traces and metrics. To remain consistent with other implementations, i used the key `console` as the identifier for the exporter. This change is related to the specification pull request open-telemetry/opentelemetry-specification#3742 Signed-off-by: Alex Boten <[email protected]>
Signed-off-by: Alex Boten <[email protected]>
Co-authored-by: Robert Pająk <[email protected]>
24b5797
to
df4f253
Compare
Signed-off-by: Alex Boten <[email protected]>
This adds support for the standard output exporter for traces and metrics. To remain consistent with other implementations, i used the key
console
as the identifier for the exporter. This change is related to the specification pull request open-telemetry/opentelemetry-specification#3742