Lay initial groundwork for file configuration #3360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
approved these changes
Apr 3, 2023
codeboten
approved these changes
Apr 3, 2023
trask
approved these changes
Apr 4, 2023
arminru
added
area:sdk
bogdandrutu
reviewed
Apr 4, 2023
specification/configuration/schema/opentelemetry_configuration.json
Outdated
Show resolved
Hide resolved
codeboten
reviewed
Apr 4, 2023
specification/configuration/schema/opentelemetry_configuration.json
Outdated
Show resolved
Hide resolved
carlosalberto
approved these changes
Apr 11, 2023
reyang
reviewed
Apr 11, 2023
…y-specification into file-configuration-init
…g/opentelemetry-specification into file-configuration-init
reyang
approved these changes
Apr 11, 2023
This was referenced Apr 24, 2023
jack-berg
added a commit
that referenced
this pull request
Oct 16, 2023
Part of incorporating [OTEP #225](open-telemetry/oteps#225) into the specification. Followup to #3360.
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
Initial followup to [OTEP open-telemetry#225](open-telemetry/oteps#225). This lays the initial groundwork for file configuration in the specification. There are placeholders TODOs for many various followup tasks. Additional work is also needed to figure out how to merge [SDK Configuration](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/sdk-configuration.md), [SDK Environment Variables](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/sdk-environment-variables.md) and file configuration into a cohesive story. This PR proposes the configuration schema live in `opentelemetry-specification/specification/configuration/schema/`, which implies that at some point additional build steps will be needed to confirm changes to the schema are valid and allowed. cc @MrAlias, @codeboten
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
…#3437) Part of incorporating [OTEP open-telemetry#225](open-telemetry/oteps#225) into the specification. Followup to open-telemetry#3360.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial followup to OTEP #225.
This lays the initial groundwork for file configuration in the specification. There are placeholders TODOs for many various followup tasks. Additional work is also needed to figure out how to merge SDK Configuration, SDK Environment Variables and file configuration into a cohesive story.
This PR proposes the configuration schema live in
opentelemetry-specification/specification/configuration/schema/, which implies that at some point additional build steps will be needed to confirm changes to the schema are valid and allowed.cc @MrAlias, @codeboten