Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should file configuration schema live in a separate repository? #3379

Closed
jack-berg opened this issue Apr 11, 2023 · 2 comments · Fixed by #3412
Closed

Should file configuration schema live in a separate repository? #3379

jack-berg opened this issue Apr 11, 2023 · 2 comments · Fixed by #3412
Assignees
Labels
spec:miscellaneous For issues that don't match any other spec label

Comments

@jack-berg
Copy link
Member

As discussed here the file configuration scheme will likely have versioning and stability guarantees that are different that the spec's. Also, there will eventually need to be additional build steps that confirm that changes to the schema are syntactically correct and allowed, similar to the build steps in place for opentelemetry-proto.

This suggests that it may be appropriate for the the configuration schema to live in its own repository. A counterargument is that separating the schema from the specification text that references it may cause confusion and require more coordination when making changes that impact both.

Do we want to move the file configuration schema to its own repository? If so, when is the appropriate time to move it?

@jack-berg jack-berg added the spec:miscellaneous For issues that don't match any other spec label label Apr 11, 2023
@reyang
Copy link
Member

reyang commented Apr 11, 2023

Q: Do we want to move the file configuration schema to its own repository?
My vote: YES.

Q: If so, when is the appropriate time to move it?
My vote: Now (ideally before we start).

@jack-berg
Copy link
Member Author

I opened this community issue #1425.

I don't think #3360 should be blocked by this because the schema is trivial at this point, so will go ahead and merge it. Let's hold off on additional schema changes until the new repo is set up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:miscellaneous For issues that don't match any other spec label
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants