Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark "Instrumentation Units" and "Instrumentation Types" sections of the general metric semantic conventions as stable #3294

Merged
merged 8 commits into from
Apr 14, 2023
Merged

Mark "Instrumentation Units" and "Instrumentation Types" sections of the general metric semantic conventions as stable #3294

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6cdece8
Mark parts of general metric semconv as stable
trask Mar 6, 2023
6eb346e
Add change entry log
trask Mar 6, 2023
8b6c611
update
trask Mar 6, 2023
fe2a67a
Merge remote-tracking branch 'upstream/main' into general-metric-semconv
trask Apr 2, 2023
3de4d3a
Merge remote-tracking branch 'upstream/main' into general-metric-semconv
trask Apr 4, 2023
42d12ba
Merge remote-tracking branch 'upstream/main' into general-metric-semconv
trask Apr 12, 2023
d410e58
Fix merge
trask Apr 13, 2023
cceb85d
Merge branch 'main' into general-metric-semconv
trask Apr 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,10 @@ release.

### Semantic Conventions

- Mark "Instrumentation Units" and "Instrumentation Types" sections of the general
metric semantic conventions as stable
([#3294](https://github.com/open-telemetry/opentelemetry-specification/pull/3294))

### Compatibility

### OpenTelemetry Protocol
Expand Down
10 changes: 6 additions & 4 deletions specification/metrics/semantic_conventions/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ linkTitle: Semantic Conventions
<!-- omit in toc -->
# Metrics Semantic Conventions

**Status**: [Experimental](../../document-status.md)
**Status**: [Mixed](../../document-status.md)

<!-- toc -->

Expand Down Expand Up @@ -173,10 +173,10 @@ instrument creation, but can be added if there is ambiguity.

### Instrument Units

**Status**: [Stable](../../document-status.md)
jack-berg marked this conversation as resolved.
Show resolved Hide resolved

Units should follow the
[Unified Code for Units of Measure](http://unitsofmeasure.org/ucum.html) (need
more clarification in
[#705](https://github.com/open-telemetry/opentelemetry-specification/issues/705)).
[Unified Code for Units of Measure](http://unitsofmeasure.org/ucum.html).
trask marked this conversation as resolved.
Show resolved Hide resolved

- Instruments for **utilization** metrics (that measure the fraction out of a
total) are dimensionless and SHOULD use the default unit `1` (the unity).
Expand All @@ -195,6 +195,8 @@ use `{packet}`, `{error}`, `{fault}`, etc.

### Instrument Types

**Status**: [Stable](../../document-status.md)

The semantic metric conventions specification is written to use the names of the synchronous instrument types,
like `Counter` or `UpDownCounter`. However, compliant implementations MAY use the asynchronous equivalent instead,
like `Asynchronous Counter` or `Asynchronous UpDownCounter`.
Expand Down