Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark "Instrumentation Units" and "Instrumentation Types" sections of the general metric semantic conventions as stable #3294

Merged
merged 8 commits into from
Apr 14, 2023

Conversation

trask
Copy link
Member

@trask trask commented Mar 6, 2023

Fixes #3291
Closes #705

Changes

Marks Instrumentation Units and Instrumentation Types sections of the general metric semantic conventions as stable.

@trask trask changed the title Mark parts of general metric semconv as stable Mark "Instrumentation Units" and "Instrumentation Types" sections of the general metric semantic conventions as stable Mar 6, 2023
@trask trask marked this pull request as ready for review March 6, 2023 20:34
@trask trask requested review from a team March 6, 2023 20:34
@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Mar 24, 2023
@MrAlias MrAlias removed the Stale label Mar 24, 2023
@github-actions
Copy link

github-actions bot commented Apr 1, 2023

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Apr 1, 2023
@trask trask removed the Stale label Apr 2, 2023
@bogdandrutu
Copy link
Member

Please rebase

@trask
Copy link
Member Author

trask commented Apr 4, 2023

I'd suggest merging (or rejecting) #3312 first before merging this

@jack-berg
Copy link
Member

@reyang brings up a good question about our unit recommendation for utilization metrics, which we say should use 1 as the unit. This language seems inspired by UCUM but not necessarily consistent with other recommendations we make about unit. For example, we say that unit should be specified using case sensitive ("c/s") variant of unit, but 1 doesn't meet this criteria.

@trask
Copy link
Member Author

trask commented Apr 12, 2023

@reyang brings up a good question about our unit recommendation for utilization metrics, which we say should use 1 as the unit. This language seems inspired by UCUM but not necessarily consistent with other recommendations we make about unit. For example, we say that unit should be specified using case sensitive ("c/s") variant of unit, but 1 doesn't meet this criteria.

I think 1 is an important unit for a lot of cases, e.g. it's the implicit unit for {request}.

@trask
Copy link
Member Author

trask commented Apr 12, 2023

@reyang brings up a good question about our unit recommendation for utilization metrics, which we say should use 1 as the unit. This language seems inspired by UCUM but not necessarily consistent with other recommendations we make about unit. For example, we say that unit should be specified using case sensitive ("c/s") variant of unit, but 1 doesn't meet this criteria.

I think 1 is an important unit for a lot of cases, e.g. it's the implicit unit for {request}.

oh, I see your point, {request} is a c/s, e.g. {rbc} at https://ucum.org/ucum#section-Examples-for-some-Non-Units.

but maybe not 1 itself(?)

@trask
Copy link
Member Author

trask commented Apr 12, 2023

Once #3312 is merged, I will add a note to this PR covering @jack-berg's #3312 (comment):

We could add a bullet to this PR which makes recommendations by domains. Something like:

* When measuring durations, seconds (i.e. `s`) SHOULD be used.

@jack-berg
Copy link
Member

@trask I opened #3388 to address using seconds for durations. This allows us to keep the scope of this PR isolated to changing the stability status.

@trask
Copy link
Member Author

trask commented Apr 13, 2023

@reyang brings up a good question about our unit recommendation for utilization metrics, which we say should use 1 as the unit. This language seems inspired by UCUM but not necessarily consistent with other recommendations we make about unit. For example, we say that unit should be specified using case sensitive ("c/s") variant of unit, but 1 doesn't meet this criteria.

I sent #3393 to try to resolve this

@reyang reyang merged commit 9eb6ca7 into open-telemetry:main Apr 14, 2023
@trask trask deleted the general-metric-semconv branch April 14, 2023 17:19
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mark General Metric Semantic Conventions stable Standardization of Units needed
8 participants