Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate histogram min and max fields into histogram language, add… #1983

Merged
merged 15 commits into from
Oct 21, 2021
Merged

Incorporate histogram min and max fields into histogram language, add… #1983

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
3c62dc8
Incorporate histogram min and max fields into histogram language, add…
jack-berg Oct 1, 2021
e4b7959
Change default aggregation temporality to Delta
jack-berg Oct 1, 2021
edc9936
Rename zero bucket histogram to degenerate histogram
jack-berg Oct 4, 2021
873395a
Remove monotonic parameter from histgoram aggregation, rename degener…
jack-berg Oct 8, 2021
24f5279
Adjust language on exemplar resevoir selection
jack-berg Oct 8, 2021
5b45a54
Merge branch 'main' of github.com:open-telemetry/opentelemetry-specif…
jack-berg Oct 12, 2021
4383290
Merge branch 'main' into metrics-sdk-min-max
reyang Oct 12, 2021
219642d
Fix type in anchor
jack-berg Oct 12, 2021
121e739
Remove extra line
jack-berg Oct 13, 2021
1496aa0
Merge branch 'main' of github.com:open-telemetry/opentelemetry-specif…
jack-berg Oct 19, 2021
e2f6e1c
Remove trivial histogram aggregation
jack-berg Oct 19, 2021
ceb61da
Merge branch 'main' into metrics-sdk-min-max
reyang Oct 19, 2021
620fc31
Add RecordMinMax to Explicit Bucket Histogram
jack-berg Oct 19, 2021
fc56646
Merge branch 'main' into metrics-sdk-min-max
reyang Oct 20, 2021
bbf527a
Merge branch 'main' into metrics-sdk-min-max
jmacd Oct 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ release.
### Metrics

- Add optional min / max fields to histogram data model.
([#1915](https://github.com/open-telemetry/opentelemetry-specification/pull/1915))
([#1915](https://github.com/open-telemetry/opentelemetry-specification/pull/1915),
[#1983](https://github.com/open-telemetry/opentelemetry-specification/pull/1983))
- Add exponential histogram to the metrics data model.
([#1935](https://github.com/open-telemetry/opentelemetry-specification/pull/1935))
- Add clarifications on how to handle numerical limits.
Expand Down
9 changes: 6 additions & 3 deletions specification/metrics/sdk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,6 +385,7 @@ This Aggregation honors the following configuration parameters:
| --- | --- | --- | --- |
| Temporality | Delta, Cumulative | Cumulative | See [Temporality](./datamodel.md#temporality). |
| Boundaries | double\[\] | [ 0, 5, 10, 25, 50, 75, 100, 250, 500, 1000 ] | Array of increasing values representing explicit bucket boundary values.<br><br>The Default Value represents the following buckets:<br>(-&infin;, 0], (0, 5.0], (5.0, 10.0], (10.0, 25.0], (25.0, 50.0], (50.0, 75.0], (75.0, 100.0], (100.0, 250.0], (250.0, 500.0], (500.0, 1000.0], (1000.0, +&infin;) |
| RecordMinMax | true, false | true | Whether to record min and max. |

Note: This aggregator should not fill out `sum` when used with instruments
that record negative measurements, e.g. `UpDownCounter` or `ObservableGauge`.
Expand All @@ -393,6 +394,8 @@ This Aggregation informs the SDK to collect:

- Count of `Measurement` values falling within explicit bucket boundaries.
- Arithmetic sum of `Measurement` values in population.
- Min (optional) `Measurement` value in population.
- Max (optional) `Measurement` value in population.

## Attribute limits

Expand Down Expand Up @@ -485,9 +488,9 @@ The SDK will come with two types of built-in exemplar reservoirs:
1. SimpleFixedSizeExemplarReservoir
2. AlignedHistogramBucketExemplarReservoir

By default, fixed sized histogram aggregators will use
`AlignedHistogramBucketExemplarReservoir` and all other aggregaators will use
`SimpleFixedSizeExemplarReservoir`.
By default, explicit bucket histogram aggregators with more than 1 bucket will
use `AlignedHistogramBucketExemplarReservoir`. All other aggregators will
use `SimpleFixedSizeExemplarReservoir`.

*SimpleExemplarReservoir*
This Exemplar reservoir MAY take a configuration parameter for the size of
Expand Down