Incorporate histogram min and max fields into histogram language, add… #1983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… zero bucket histogram aggregation
jack-berg
commented
Oct 1, 2021
jack-berg
commented
Oct 1, 2021
jack-berg
commented
Oct 1, 2021
reyang
added
area:sdk
bogdandrutu
previously requested changes
Oct 5, 2021
…ate histogram to trivial histogram
jack-berg
commented
Oct 8, 2021
jsuereth
reviewed
Oct 8, 2021
jsuereth
approved these changes
Oct 8, 2021
There was a problem hiding this comment.
Approving the overall call-out to users that a 1-bucket histogram = Min/Max/Sum/Count and is useful.
Naming - I'm sure there will be debates on specific name. I made some comments/possible suggestions but I don't feel strongly about any particular name for this one.
As a side comment, we use this degenerate case of a single-bucket explicit histogram in the Java SDK metric tests.
jmacd
approved these changes
Oct 8, 2021
jmacd
approved these changes
Oct 8, 2021
…ication into metrics-sdk-min-max
…ication into metrics-sdk-min-max
reyang
approved these changes
Oct 20, 2021
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
open-telemetry#1983) * Incorporate histogram min and max fields into histogram language, add zero bucket histogram aggregation * Change default aggregation temporality to Delta * Rename zero bucket histogram to degenerate histogram * Remove monotonic parameter from histgoram aggregation, rename degenerate histogram to trivial histogram * Adjust language on exemplar resevoir selection * Fix type in anchor * Remove extra line * Remove trivial histogram aggregation * Add RecordMinMax to Explicit Bucket Histogram Co-authored-by: Reiley Yang <[email protected]> Co-authored-by: Joshua MacDonald <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… zero bucket histogram aggregation
Resolves #1902.
Changes