-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow implementations to use their own default for OTLP compression. #1923
Allow implementations to use their own default for OTLP compression. #1923
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good from JS perspective. Sorry for late review i had vacation
As discussed in the SIG, I think the best that we do this:
|
@tigrannajaryan Updated it to match the feedback, please review again. @dyladan FYI, now the new explicit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except the "none" part.
@tigrannajaryan @yurishkuro Used |
As discussed in yesterday's Spec SIG call, allow SIGs to define their own default. Specially important as OTel JS will be going GA very soon, and we want to allow it to use gzip as their default (at least for the browser case) - also a motivating reason to include this change in this week's Specification release.
(Also removed the mention of SIGs supporting other compression methods, as they should be vetted first by the Collector, etc)
Alternative to #1895
cc @dyladan @bogdandrutu