Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example in documentation #551

Merged
merged 4 commits into from
Apr 8, 2020
Merged

Fix example in documentation #551

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
54d42fd
Fix example in documentation
ocelotl Apr 4, 2020
e4a741c
Update getting started guide too
c24t Apr 7, 2020
12629d0
Merge branch 'master' into issue_550
c24t Apr 7, 2020
79bbc07
Merge branch 'master' into issue_550
c24t Apr 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions docs/getting-started.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,12 +184,14 @@ And let's write a small Flask application that sends an HTTP request, activating
.. code-block:: python

# flask_example.py
from opentelemetry.ext.flask import FlaskInstrumentor
FlaskInstrumentor().instrument() # This needs to be executed before importing Flask

import flask
import requests

import opentelemetry.ext.http_requests
from opentelemetry import trace
from opentelemetry.ext.flask import instrument_app
from opentelemetry.sdk.trace import TracerProvider
from opentelemetry.sdk.trace.export import ConsoleSpanExporter
from opentelemetry.sdk.trace.export import SimpleExportSpanProcessor
Expand All @@ -201,7 +203,6 @@ And let's write a small Flask application that sends an HTTP request, activating

app = flask.Flask(__name__)
opentelemetry.ext.http_requests.enable(trace.get_tracer_provider())
instrument_app(app)

@app.route("/")
def hello():
Expand Down
4 changes: 2 additions & 2 deletions ext/opentelemetry-ext-flask/src/opentelemetry/ext/flask/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@

.. code-block:: python

from opentelemetry.ext.flask import FlaskInstrumentor
FlaskInstrumentor().instrument() # This needs to be executed before importing Flask
from flask import Flask
from opentelemetry.ext.flask import instrument_app

app = Flask(__name__)
instrument_app(app) # This is where the magic happens. ✨

@app.route("/")
def hello():
Expand Down