-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix example in documentation #551
Conversation
Out of curiosity, was there a reason the flask instrumentation interface was changed? The previous version of having a function that takes the flask app as a param which can be called in the flask apps bootstrap method feels closer to the usual pattern of how other flask extensions are integrated. Imo having an instrumentation class that has to be called in a specific order and relies on side effects feels a lot less clear for someone consuming / integrating the extension. |
Hello This was changed because we introduced support for auto instrumentation in #327. With this new feature came a standard API for instrumentors (the This being said, having to call |
I believe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes #550
This fix requires to run code before an
import
statement, which is frowned upon by PEP8 format checkers because this is considered an error (E402). Nevertheless, I prefer to add this as a fix now in order to have at least a functional example. Avoiding this error will require more functionality added to the instrumentor.