Make sure Resources follow semantic conventions #1480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding default service name population
hectorhdzg
requested review from
a team,
codeboten and
aabmass
and removed request for
a team
|
|
hectorhdzg
changed the title
lzchen
reviewed
Dec 15, 2020
lzchen
reviewed
Dec 15, 2020
lzchen
reviewed
Dec 15, 2020
lzchen
approved these changes
Dec 15, 2020
codeboten
suggested changes
Jan 5, 2021
There was a problem hiding this comment.
Blocking on removing a duplicated variable, otherwise it looks good. Were the semantic conventions generated? If not, is this something that would be doable using the generator: https://github.com/open-telemetry/build-tools/tree/master/semantic-conventions?
| CONTAINER_IMAGE_NAME = "container.image.name" | ||
| CONTAINER_IMAGE_TAG = "container.image.tag" | ||
| CONTAINER_NAME = "container.name" | ||
| CONTAINER_NAME = "container.name" |
| @@ -38,7 +38,11 @@ def test_resource(self): | |||
| def test_resource_empty(self): | |||
There was a problem hiding this comment.
wonder if this test should be renamed since it's not using the empty resource (there's a separate create_empty method for empty resources)
|
@hectorhdzg |
Merged
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding global variables with supported resources
Adding default service name population
Fixes #1477