Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The SDK MUST set a default value for the attribute service.name if it was not specified #1526

Closed
srikanthccv opened this issue Jan 13, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@srikanthccv
Copy link
Member

The service.name attribute of Resource is mandatory and SDK should set the default value if not specified. This attribute is necessary for certain backends such as Jaeger to identify the service that produced the spans.

From specs

The SDK MUST set a default value for the following attributes if they were not specified, even if the resource would otherwise not be present at all:

  • service.name

[1]: MUST be the same for all instances of horizontally scaled services. If the value was not specified, SDKs MUST fallback to unknown_service: concatenated with process.executable.name, e.g. unknown_service:bash. If process.executable.name is not available, the value MUST be set to unknown_service.

@srikanthccv srikanthccv added the bug Something isn't working label Jan 13, 2021
@codeboten
Copy link
Contributor

This issue is still being discussed here: open-telemetry/opentelemetry-specification#1237

@srikanthccv
Copy link
Member Author

@codeboten This PR open-telemetry/opentelemetry-specification#1269 says it fixes the mentioned issue and it got merged. The issue would have been auto-closed but description formatting prevented that.

@srikanthccv
Copy link
Member Author

It seems there are some updates to spec around this issue. Resource merge behaviour is updated with this PR open-telemetry/opentelemetry-specification#1345.

@srikanthccv
Copy link
Member Author

This is fixed in #1480 hence closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants