Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Resource merge method precedence for conflict key and empty string #1543

Closed
srikanthccv opened this issue Jan 22, 2021 · 0 comments · Fixed by #1544
Closed

Update Resource merge method precedence for conflict key and empty string #1543

srikanthccv opened this issue Jan 22, 2021 · 0 comments · Fixed by #1544
Labels
bug Something isn't working

Comments

@srikanthccv
Copy link
Member

srikanthccv commented Jan 22, 2021 •
edited
Loading

Recently spec has been updated for Resource

From specs

The resulting resource MUST have all attributes that are on any of the two input resources. If a key exists on both the old and updating resource, the value of the updating resource MUST be picked (even if the updated value is empty).

This is kind of related to #1526.
@srikanthccv srikanthccv added the bug Something isn't working label Jan 22, 2021
@srikanthccv srikanthccv mentioned this issue Jan 22, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Resource merge key conflict precedence srikanthccv/opentelemetry-python
2 participants
@lzchen @srikanthccv