-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add instrumentation for aioredis #569
base: main
Are you sure you want to change the base?
Conversation
This reverts commit 395ede5.
@mnbbrown |
+1 |
+1 |
@mnbbrown any chances to get this merged? |
|
||
# We provide extras_require parameter to setuptools.setup later which | ||
# overwrites the extra_require section from setup.cfg. To support extra_require | ||
# secion in setup.cfg, we load it here and merge it with the extra_require param. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# secion in setup.cfg, we load it here and merge it with the extra_require param. | |
# section in setup.cfg, we load it here and merge it with the extra_require param. |
@mnbbrown, any chance you can pick this up again? Please leave a comment if you can't. Maybe other contributors can continue your work and submit new pull request. |
Description
This adds instrumentation support for aioredis. It replicates the functionality of the existing
redis
instrumentation.Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.