Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instrumentation for aioredis #569

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

mnbbrown
Copy link
Contributor

@mnbbrown mnbbrown commented Jul 7, 2021

Description

This adds instrumentation support for aioredis. It replicates the functionality of the existing redis instrumentation.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@lzchen
Copy link
Contributor

lzchen commented Feb 2, 2022

@mnbbrown
Are you still working on this? Please mark this as a PR if you want reviews on this.

@mojtabaahn
Copy link

+1

@sd2k sd2k mentioned this pull request Apr 29, 2022
8 tasks
@leandrorebelo
Copy link

+1

@a5r0n
Copy link

a5r0n commented Dec 21, 2022

@mnbbrown any chances to get this merged?


# We provide extras_require parameter to setuptools.setup later which
# overwrites the extra_require section from setup.cfg. To support extra_require
# secion in setup.cfg, we load it here and merge it with the extra_require param.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# secion in setup.cfg, we load it here and merge it with the extra_require param.
# section in setup.cfg, we load it here and merge it with the extra_require param.

@srikanthccv
Copy link
Member

@mnbbrown, any chance you can pick this up again? Please leave a comment if you can't. Maybe other contributors can continue your work and submit new pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants