Instrument redis.asyncio clients #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sd2k
force-pushed
the
instrument-redis-asyncio
branch
from
d8629ee to
b191b0b
Compare
sd2k
force-pushed
the
instrument-redis-asyncio
branch
from
b191b0b to
20c01f2
Compare
srikanthccv
reviewed
May 1, 2022
...tion/opentelemetry-instrumentation-redis/src/opentelemetry/instrumentation/redis/__init__.py
Outdated
Show resolved
Hide resolved
sd2k
force-pushed
the
instrument-redis-asyncio
branch
from
20c01f2 to
0765def
Compare
lzchen
reviewed
May 2, 2022
...tion/opentelemetry-instrumentation-redis/src/opentelemetry/instrumentation/redis/__init__.py
Show resolved
Hide resolved
sd2k
force-pushed
the
instrument-redis-asyncio
branch
from
9b8d8f4 to
0498d3e
Compare
srikanthccv
approved these changes
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds instrumentation to async Redis clients in the Redis library.
As of redis-py 4.2.0, async support has been merged into the main redis-py library (basically taken from aioredis, I believe). Instrumentation should work in the same way as the sync Redis clients.
No dependency changes are required in the actual package; we only activate async instrumentation if the Redis version is high enough. The
docker-teststestenv has its Redis version bumped to one that include async support, however.Should supersede #569 since aioredis is no longer recommended.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
test_redis_functional.pyDoes This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.