Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing dependencies #360

Merged
merged 3 commits into from
Mar 10, 2021
Merged

Add missing dependencies #360

merged 3 commits into from
Mar 10, 2021

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented Mar 3, 2021

Fixes #359

Description

Adds missing dependencies for some instrumentations.

Fixes #359

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@ocelotl ocelotl added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 3, 2021
@ocelotl ocelotl requested a review from a team March 3, 2021 00:34
@ocelotl ocelotl self-assigned this Mar 3, 2021
@ocelotl ocelotl requested review from toumorokoshi and hectorhdzg and removed request for a team March 3, 2021 00:34
Copy link
Member

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@lzchen lzchen merged commit 5f88452 into open-telemetry:main Mar 10, 2021
@ocelotl ocelotl deleted the issue_359 branch March 10, 2021 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some instrumentations are missing the instrumentation dependency
5 participants